mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 03/13] sparc/irq: use seq_put_decimal_ull_width() for decimal values
@ 2024-11-08 16:11 David Wang
  2025-01-17 15:28 ` Andreas Larsson
  0 siblings, 1 reply; 2+ messages in thread
From: David Wang @ 2024-11-08 16:11 UTC (permalink / raw)
  To: davem, andreas; +Cc: linux-kernel, sparclinux, David Wang

Performance improvement for reading /proc/interrupts on arch sparc

Signed-off-by: David Wang <00107082@163.com>
---
 arch/sparc/kernel/irq_32.c | 12 ++++++------
 arch/sparc/kernel/irq_64.c |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/sparc/kernel/irq_32.c b/arch/sparc/kernel/irq_32.c
index 8605dd710f3c..5210991429d5 100644
--- a/arch/sparc/kernel/irq_32.c
+++ b/arch/sparc/kernel/irq_32.c
@@ -199,18 +199,18 @@ int arch_show_interrupts(struct seq_file *p, int prec)
 	int j;
 
 #ifdef CONFIG_SMP
-	seq_printf(p, "RES: ");
+	seq_printf(p, "RES:");
 	for_each_online_cpu(j)
-		seq_printf(p, "%10u ", cpu_data(j).irq_resched_count);
+		seq_put_decimal_ull_width(p, " ", cpu_data(j).irq_resched_count, 10);
 	seq_printf(p, "     IPI rescheduling interrupts\n");
-	seq_printf(p, "CAL: ");
+	seq_printf(p, "CAL:");
 	for_each_online_cpu(j)
-		seq_printf(p, "%10u ", cpu_data(j).irq_call_count);
+		seq_put_decimal_ull_width(p, " ", cpu_data(j).irq_call_count, 10);
 	seq_printf(p, "     IPI function call interrupts\n");
 #endif
-	seq_printf(p, "NMI: ");
+	seq_printf(p, "NMI:");
 	for_each_online_cpu(j)
-		seq_printf(p, "%10u ", cpu_data(j).counter);
+		seq_put_decimal_ull_width(p, " ", cpu_data(j).counter, 10);
 	seq_printf(p, "     Non-maskable interrupts\n");
 	return 0;
 }
diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c
index 01ee800efde3..9ab6e79b617b 100644
--- a/arch/sparc/kernel/irq_64.c
+++ b/arch/sparc/kernel/irq_64.c
@@ -304,9 +304,9 @@ int arch_show_interrupts(struct seq_file *p, int prec)
 {
 	int j;
 
-	seq_printf(p, "NMI: ");
+	seq_printf(p, "NMI:");
 	for_each_online_cpu(j)
-		seq_printf(p, "%10u ", cpu_data(j).__nmi_count);
+		seq_put_decimal_ull_width(p, " ", cpu_data(j).__nmi_count, 10);
 	seq_printf(p, "     Non-maskable interrupts\n");
 	return 0;
 }
-- 
2.39.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 03/13] sparc/irq: use seq_put_decimal_ull_width() for decimal values
  2024-11-08 16:11 [PATCH 03/13] sparc/irq: use seq_put_decimal_ull_width() for decimal values David Wang
@ 2025-01-17 15:28 ` Andreas Larsson
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Larsson @ 2025-01-17 15:28 UTC (permalink / raw)
  To: David Wang, davem; +Cc: linux-kernel, sparclinux

On 2024-11-08 17:11, David Wang wrote:
> Performance improvement for reading /proc/interrupts on arch sparc
> 
> Signed-off-by: David Wang <00107082@163.com>
> ---
>  arch/sparc/kernel/irq_32.c | 12 ++++++------
>  arch/sparc/kernel/irq_64.c |  4 ++--
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/sparc/kernel/irq_32.c b/arch/sparc/kernel/irq_32.c
> index 8605dd710f3c..5210991429d5 100644
> --- a/arch/sparc/kernel/irq_32.c
> +++ b/arch/sparc/kernel/irq_32.c
> @@ -199,18 +199,18 @@ int arch_show_interrupts(struct seq_file *p, int prec)
>  	int j;
>  
>  #ifdef CONFIG_SMP
> -	seq_printf(p, "RES: ");
> +	seq_printf(p, "RES:");
>  	for_each_online_cpu(j)
> -		seq_printf(p, "%10u ", cpu_data(j).irq_resched_count);
> +		seq_put_decimal_ull_width(p, " ", cpu_data(j).irq_resched_count, 10);
>  	seq_printf(p, "     IPI rescheduling interrupts\n");
> -	seq_printf(p, "CAL: ");
> +	seq_printf(p, "CAL:");
>  	for_each_online_cpu(j)
> -		seq_printf(p, "%10u ", cpu_data(j).irq_call_count);
> +		seq_put_decimal_ull_width(p, " ", cpu_data(j).irq_call_count, 10);
>  	seq_printf(p, "     IPI function call interrupts\n");
>  #endif
> -	seq_printf(p, "NMI: ");
> +	seq_printf(p, "NMI:");
>  	for_each_online_cpu(j)
> -		seq_printf(p, "%10u ", cpu_data(j).counter);
> +		seq_put_decimal_ull_width(p, " ", cpu_data(j).counter, 10);
>  	seq_printf(p, "     Non-maskable interrupts\n");
>  	return 0;
>  }
> diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c
> index 01ee800efde3..9ab6e79b617b 100644
> --- a/arch/sparc/kernel/irq_64.c
> +++ b/arch/sparc/kernel/irq_64.c
> @@ -304,9 +304,9 @@ int arch_show_interrupts(struct seq_file *p, int prec)
>  {
>  	int j;
>  
> -	seq_printf(p, "NMI: ");
> +	seq_printf(p, "NMI:");
>  	for_each_online_cpu(j)
> -		seq_printf(p, "%10u ", cpu_data(j).__nmi_count);
> +		seq_put_decimal_ull_width(p, " ", cpu_data(j).__nmi_count, 10);
>  	seq_printf(p, "     Non-maskable interrupts\n");
>  	return 0;
>  }

Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Tested-by: Andreas Larsson <andreas@gaisler.com>

Picking this up to my for-next.

Thanks,
Andreas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-17 15:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-08 16:11 [PATCH 03/13] sparc/irq: use seq_put_decimal_ull_width() for decimal values David Wang
2025-01-17 15:28 ` Andreas Larsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®