From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Lee Chun-Yi" <jlee@suse.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Ike Panhc" <ike.pan@canonical.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Alexis Belmonte" <alexbelm48@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
<platform-driver-x86@vger.kernel.org>,
"open list:THINKPAD ACPI EXTRAS DRIVER"
<ibm-acpi-devel@lists.sourceforge.net>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v6 13/22] ACPI: platform_profile: Add profile attribute for class interface
Date: Fri, 8 Nov 2024 22:41:42 -0600 [thread overview]
Message-ID: <20241109044151.29804-14-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241109044151.29804-1-mario.limonciello@amd.com>
Reading and writing the `profile` sysfs file will use the callbacks for
the platform profile handler to read or set the given profile.
Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v6:
* Fix return
v5:
* Drop recovery flow
* Don't get profile before setting (not needed)
* Simplify casting for call to _store_class_profile()
* Only notify legacy interface of changes
* Adjust mutex use
---
drivers/acpi/platform_profile.c | 106 ++++++++++++++++++++++++++++++++
1 file changed, 106 insertions(+)
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 86d0eb7cc6fc3..c5487d3928c1b 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -46,6 +46,58 @@ static ssize_t _commmon_choices_show(unsigned long *choices, char *buf)
return len;
}
+/**
+ * _store_class_profile - Set the profile for a class device
+ * @dev: The class device
+ * @data: The profile to set
+ */
+static int _store_class_profile(struct device *dev, void *data)
+{
+ struct platform_profile_handler *handler;
+ int *i = (int *)data;
+ int err;
+
+ lockdep_assert_held(&profile_lock);
+ handler = dev_get_drvdata(dev);
+ if (!test_bit(*i, handler->choices))
+ return -EOPNOTSUPP;
+
+ handler = dev_get_drvdata(dev);
+ err = handler->profile_set(handler, *i);
+ if (err)
+ return err;
+
+ return 0;
+}
+
+/**
+ * get_class_profile - Show the current profile for a class device
+ * @dev: The class device
+ * @profile: The profile to return
+ * Return: 0 on success, -errno on failure
+ */
+static int get_class_profile(struct device *dev,
+ enum platform_profile_option *profile)
+{
+ struct platform_profile_handler *handler;
+ enum platform_profile_option val;
+ int err;
+
+ lockdep_assert_held(&profile_lock);
+ handler = dev_get_drvdata(dev);
+ err = handler->profile_get(handler, &val);
+ if (err) {
+ pr_err("Failed to get profile for handler %s\n", handler->name);
+ return err;
+ }
+
+ if (WARN_ON(val >= PLATFORM_PROFILE_LAST))
+ return -EINVAL;
+ *profile = val;
+
+ return 0;
+}
+
/**
* name_show - Show the name of the profile handler
* @dev: The device
@@ -85,12 +137,66 @@ static ssize_t choices_show(struct device *dev,
return -ERESTARTSYS;
}
+/**
+ * profile_show - Show the current profile for a class device
+ * @dev: The device
+ * @attr: The attribute
+ * @buf: The buffer to write to
+ * Return: The number of bytes written
+ */
+static ssize_t profile_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ enum platform_profile_option profile = PLATFORM_PROFILE_LAST;
+ int err;
+
+ scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
+ err = get_class_profile(dev, &profile);
+ if (err)
+ return err;
+ }
+
+ return sysfs_emit(buf, "%s\n", profile_names[profile]);
+}
+
+/**
+ * profile_store - Set the profile for a class device
+ * @dev: The device
+ * @attr: The attribute
+ * @buf: The buffer to read from
+ * @count: The number of bytes to read
+ * Return: The number of bytes read
+ */
+static ssize_t profile_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ int i, ret;
+
+ i = sysfs_match_string(profile_names, buf);
+ if (i < 0)
+ return -EINVAL;
+
+ scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
+ ret = _store_class_profile(dev, &i);
+ if (ret)
+ return ret;
+ }
+
+ sysfs_notify(acpi_kobj, NULL, "platform_profile");
+
+ return count;
+}
+
static DEVICE_ATTR_RO(name);
static DEVICE_ATTR_RO(choices);
+static DEVICE_ATTR_RW(profile);
static struct attribute *profile_attrs[] = {
&dev_attr_name.attr,
&dev_attr_choices.attr,
+ &dev_attr_profile.attr,
NULL
};
ATTRIBUTE_GROUPS(profile);
--
2.43.0
next prev parent reply other threads:[~2024-11-09 4:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 4:41 [PATCH v6 00/22] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 01/22] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 02/22] platform/x86/dell: dell-pc: Create platform device Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 03/22] ACPI: platform_profile: Add device pointer into platform profile handler Mario Limonciello
2024-11-17 18:58 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 04/22] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 05/22] ACPI: platform_profile: Pass the profile handler into platform_profile_notify() Mario Limonciello
2024-11-17 19:01 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 06/22] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 07/22] ACPI: platform_profile: Move matching string for new profile out of mutex Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 08/22] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 09/22] ACPI: platform_profile: Use `scoped_cond_guard` Mario Limonciello
2024-11-17 19:56 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 10/22] ACPI: platform_profile: Create class for ACPI platform profile Mario Limonciello
2024-11-17 19:11 ` Armin Wolf
2024-11-19 12:35 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 11/22] ACPI: platform_profile: Add name attribute to class interface Mario Limonciello
2024-11-18 19:43 ` Armin Wolf
2024-11-19 0:28 ` Armin Wolf
2024-11-19 4:09 ` Mario Limonciello
2024-11-19 12:26 ` Armin Wolf
2024-11-19 16:15 ` Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 12/22] ACPI: platform_profile: Add choices attribute for " Mario Limonciello
2024-11-09 4:41 ` Mario Limonciello [this message]
2024-11-09 4:41 ` [PATCH v6 14/22] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-11-17 19:21 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 15/22] ACPI: platform_profile: Only show profiles common for all handlers Mario Limonciello
2024-11-18 19:46 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 16/22] ACPI: platform_profile: Add concept of a "custom" profile Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 17/22] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-11-18 19:51 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 18/22] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-11-18 19:53 ` Armin Wolf
2024-11-19 13:00 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 19/22] ACPI: platform_profile: Notify class device from platform_profile_notify() Mario Limonciello
2024-11-17 19:26 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 20/22] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-11-17 19:27 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 21/22] platform/x86/amd: pmf: Drop all quirks Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 22/22] Documentation: Add documentation about class interface for platform profiles Mario Limonciello
2024-11-17 19:34 ` Armin Wolf
2024-11-12 20:16 ` [PATCH v6 00/22] Add support for binding ACPI platform profile to multiple drivers Rafael J. Wysocki
2024-11-12 20:20 ` Mario Limonciello
2024-11-12 20:25 ` Rafael J. Wysocki
2024-11-14 21:57 ` Armin Wolf
2024-11-18 21:05 ` Armin Wolf
2024-11-19 4:13 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109044151.29804-14-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=aichao@kylinos.cn \
--cc=alexbelm48@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=luzmaximilian@gmail.com \
--cc=matthew.schwartz@linux.dev \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=soyer@irl.hu \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®