From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Lee Chun-Yi" <jlee@suse.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Ike Panhc" <ike.pan@canonical.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Alexis Belmonte" <alexbelm48@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
<platform-driver-x86@vger.kernel.org>,
"open list:THINKPAD ACPI EXTRAS DRIVER"
<ibm-acpi-devel@lists.sourceforge.net>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Armin Wolf" <W_Armin@gmx.de>
Subject: [PATCH v6 02/22] platform/x86/dell: dell-pc: Create platform device
Date: Fri, 8 Nov 2024 22:41:31 -0600 [thread overview]
Message-ID: <20241109044151.29804-3-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241109044151.29804-1-mario.limonciello@amd.com>
In order to have a device for the platform profile core to reference
create a platform device for dell-pc.
While doing this change the memory allocation for the thermal handler
to be device managed to follow the lifecycle of that device.
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v6:
* Use PLATFORM_DEVID_NONE (Armin)
v5:
* use platform_device_register_simple()
---
drivers/platform/x86/dell/dell-pc.c | 32 +++++++++++++++++++++--------
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/dell/dell-pc.c b/drivers/platform/x86/dell/dell-pc.c
index 3cf79e55e3129..805497e44b3a5 100644
--- a/drivers/platform/x86/dell/dell-pc.c
+++ b/drivers/platform/x86/dell/dell-pc.c
@@ -18,10 +18,13 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/platform_profile.h>
+#include <linux/platform_device.h>
#include <linux/slab.h>
#include "dell-smbios.h"
+static struct platform_device *platform_device;
+
static const struct dmi_system_id dell_device_table[] __initconst = {
{
.ident = "Dell Inc.",
@@ -244,9 +247,15 @@ static int thermal_init(void)
if (!supported_modes)
return 0;
- thermal_handler = kzalloc(sizeof(*thermal_handler), GFP_KERNEL);
- if (!thermal_handler)
+ platform_device = platform_device_register_simple("dell-pc", PLATFORM_DEVID_NONE, NULL, 0);
+ if (!platform_device)
return -ENOMEM;
+
+ thermal_handler = devm_kzalloc(&platform_device->dev, sizeof(*thermal_handler), GFP_KERNEL);
+ if (!thermal_handler) {
+ ret = -ENOMEM;
+ goto cleanup_platform_device;
+ }
thermal_handler->name = "dell-pc";
thermal_handler->profile_get = thermal_platform_profile_get;
thermal_handler->profile_set = thermal_platform_profile_set;
@@ -262,20 +271,25 @@ static int thermal_init(void)
/* Clean up if failed */
ret = platform_profile_register(thermal_handler);
- if (ret) {
- kfree(thermal_handler);
- thermal_handler = NULL;
- }
+ if (ret)
+ goto cleanup_thermal_handler;
+
+ return 0;
+
+cleanup_thermal_handler:
+ thermal_handler = NULL;
+
+cleanup_platform_device:
+ platform_device_unregister(platform_device);
return ret;
}
static void thermal_cleanup(void)
{
- if (thermal_handler) {
+ if (thermal_handler)
platform_profile_remove();
- kfree(thermal_handler);
- }
+ platform_device_unregister(platform_device);
}
static int __init dell_init(void)
--
2.43.0
next prev parent reply other threads:[~2024-11-09 4:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 4:41 [PATCH v6 00/22] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 01/22] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-11-09 4:41 ` Mario Limonciello [this message]
2024-11-09 4:41 ` [PATCH v6 03/22] ACPI: platform_profile: Add device pointer into platform profile handler Mario Limonciello
2024-11-17 18:58 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 04/22] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 05/22] ACPI: platform_profile: Pass the profile handler into platform_profile_notify() Mario Limonciello
2024-11-17 19:01 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 06/22] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 07/22] ACPI: platform_profile: Move matching string for new profile out of mutex Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 08/22] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 09/22] ACPI: platform_profile: Use `scoped_cond_guard` Mario Limonciello
2024-11-17 19:56 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 10/22] ACPI: platform_profile: Create class for ACPI platform profile Mario Limonciello
2024-11-17 19:11 ` Armin Wolf
2024-11-19 12:35 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 11/22] ACPI: platform_profile: Add name attribute to class interface Mario Limonciello
2024-11-18 19:43 ` Armin Wolf
2024-11-19 0:28 ` Armin Wolf
2024-11-19 4:09 ` Mario Limonciello
2024-11-19 12:26 ` Armin Wolf
2024-11-19 16:15 ` Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 12/22] ACPI: platform_profile: Add choices attribute for " Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 13/22] ACPI: platform_profile: Add profile " Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 14/22] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-11-17 19:21 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 15/22] ACPI: platform_profile: Only show profiles common for all handlers Mario Limonciello
2024-11-18 19:46 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 16/22] ACPI: platform_profile: Add concept of a "custom" profile Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 17/22] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-11-18 19:51 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 18/22] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-11-18 19:53 ` Armin Wolf
2024-11-19 13:00 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 19/22] ACPI: platform_profile: Notify class device from platform_profile_notify() Mario Limonciello
2024-11-17 19:26 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 20/22] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-11-17 19:27 ` Armin Wolf
2024-11-09 4:41 ` [PATCH v6 21/22] platform/x86/amd: pmf: Drop all quirks Mario Limonciello
2024-11-09 4:41 ` [PATCH v6 22/22] Documentation: Add documentation about class interface for platform profiles Mario Limonciello
2024-11-17 19:34 ` Armin Wolf
2024-11-12 20:16 ` [PATCH v6 00/22] Add support for binding ACPI platform profile to multiple drivers Rafael J. Wysocki
2024-11-12 20:20 ` Mario Limonciello
2024-11-12 20:25 ` Rafael J. Wysocki
2024-11-14 21:57 ` Armin Wolf
2024-11-18 21:05 ` Armin Wolf
2024-11-19 4:13 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109044151.29804-3-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=W_Armin@gmx.de \
--cc=aichao@kylinos.cn \
--cc=alexbelm48@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=luzmaximilian@gmail.com \
--cc=matthew.schwartz@linux.dev \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=soyer@irl.hu \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®