From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net, Andrew Lunn <andrew@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Herve Codina" <herve.codina@bootlin.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH net-next v2 00/10] net: freescale: ucc_geth: Phylink conversion
Date: Thu, 14 Nov 2024 16:35:51 +0100 [thread overview]
Message-ID: <20241114153603.307872-1-maxime.chevallier@bootlin.com> (raw)
Hello everyone,
This is V2 of the ucc_geth phylink conversion.
There were two main reviews from the first iteration :
- The WoL configuration was not accounting for most of the WoL flags.
The Wol config was reworked (however, not tested unfortunately) to
better account for what the PHY and MAC can deal with. However this
is still a topic I'm not fully mastering... I think the modifications
done to patch 4 addresses the shortcomings, but it does look a bit
convoluted to me.
- The last patch of the series, that does the phylink conversion, was
hard to digest. To address that, I've split it up a bit more by
introducing the phy_interface_mode_is_reduced() in a dedicated patch
(patch 9), and by moving around some internal functions in a
dedicated patch as well (patch 8).
Thanks Andrew and Russell for the reviews on V1.
Best regards,
Maxime
Link to V1: https://lore.kernel.org/netdev/20241107170255.1058124-1-maxime.chevallier@bootlin.com/
Maxime Chevallier (10):
net: freescale: ucc_geth: Drop support for the "interface" DT property
net: freescale: ucc_geth: split adjust_link for phylink conversion
net: freescale: ucc_geth: Use netdev->phydev to access the PHY
net: freescale: ucc_geth: Fix WOL configuration
net: freescale: ucc_geth: Use the correct type to store WoL opts
net: freescale: ucc_geth: Simplify frame length check
net: freescale: ucc_geth: Hardcode the preamble length to 7 bytes
net: freescale: ucc_geth: Move the serdes configuration around
net: freescale: ucc_geth: Introduce a helper to check Reduced modes
net: freescale: ucc_geth: phylink conversion
drivers/net/ethernet/freescale/Kconfig | 3 +-
drivers/net/ethernet/freescale/ucc_geth.c | 601 +++++++-----------
drivers/net/ethernet/freescale/ucc_geth.h | 22 +-
.../net/ethernet/freescale/ucc_geth_ethtool.c | 74 +--
4 files changed, 265 insertions(+), 435 deletions(-)
--
2.47.0
next reply other threads:[~2024-11-14 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 15:35 Maxime Chevallier [this message]
2024-11-14 15:35 ` [PATCH net-next v2 01/10] net: freescale: ucc_geth: Drop support for the "interface" DT property Maxime Chevallier
2024-11-15 12:19 ` Simon Horman
2024-11-20 8:43 ` Maxime Chevallier
2024-11-14 15:35 ` [PATCH net-next v2 02/10] net: freescale: ucc_geth: split adjust_link for phylink conversion Maxime Chevallier
2024-11-14 15:35 ` [PATCH net-next v2 03/10] net: freescale: ucc_geth: Use netdev->phydev to access the PHY Maxime Chevallier
2024-11-14 15:35 ` [PATCH net-next v2 04/10] net: freescale: ucc_geth: Fix WOL configuration Maxime Chevallier
2024-11-14 15:35 ` [PATCH net-next v2 05/10] net: freescale: ucc_geth: Use the correct type to store WoL opts Maxime Chevallier
2024-11-14 15:35 ` [PATCH net-next v2 06/10] net: freescale: ucc_geth: Simplify frame length check Maxime Chevallier
2024-11-14 15:35 ` [PATCH net-next v2 07/10] net: freescale: ucc_geth: Hardcode the preamble length to 7 bytes Maxime Chevallier
2024-11-14 15:35 ` [PATCH net-next v2 08/10] net: freescale: ucc_geth: Move the serdes configuration around Maxime Chevallier
2024-11-14 15:36 ` [PATCH net-next v2 09/10] net: freescale: ucc_geth: Introduce a helper to check Reduced modes Maxime Chevallier
2024-11-14 15:36 ` [PATCH net-next v2 10/10] net: freescale: ucc_geth: phylink conversion Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114153603.307872-1-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®