* [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SC8180X compatible
2024-11-16 11:31 [PATCH 0/2] Fix SC8180X cpufreq dt-bindings error Konrad Dybcio
@ 2024-11-16 11:31 ` Konrad Dybcio
2024-11-16 11:31 ` [PATCH 2/2] arm64: dts: qcom: sc8180x: Add a SoC-specific compatible to cpufreq-hw Konrad Dybcio
2024-11-18 4:29 ` [PATCH 0/2] Fix SC8180X cpufreq dt-bindings error Viresh Kumar
2 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2024-11-16 11:31 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Marijn Suijten, linux-pm, devicetree, linux-kernel,
linux-arm-msm, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Add a SoC-specific compatible for SC8180X. It has 2 domains and uses
the older, non-EPSS hardware.
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index 729f68c1f81d32e54e170879c4f7dd91c0d7c80a..e937eb7355e7fb74c0aeafb4cb9f5ed80d96e6c3 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -23,6 +23,7 @@ properties:
- enum:
- qcom,qcm2290-cpufreq-hw
- qcom,sc7180-cpufreq-hw
+ - qcom,sc8180x-cpufreq-hw
- qcom,sdm670-cpufreq-hw
- qcom,sdm845-cpufreq-hw
- qcom,sm6115-cpufreq-hw
@@ -135,6 +136,7 @@ allOf:
- qcom,qdu1000-cpufreq-epss
- qcom,sa8255p-cpufreq-epss
- qcom,sc7180-cpufreq-hw
+ - qcom,sc8180x-cpufreq-hw
- qcom,sc8280xp-cpufreq-epss
- qcom,sdm670-cpufreq-hw
- qcom,sdm845-cpufreq-hw
--
2.47.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/2] arm64: dts: qcom: sc8180x: Add a SoC-specific compatible to cpufreq-hw
2024-11-16 11:31 [PATCH 0/2] Fix SC8180X cpufreq dt-bindings error Konrad Dybcio
2024-11-16 11:31 ` [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SC8180X compatible Konrad Dybcio
@ 2024-11-16 11:31 ` Konrad Dybcio
2024-11-17 13:11 ` Dmitry Baryshkov
2024-11-18 4:29 ` [PATCH 0/2] Fix SC8180X cpufreq dt-bindings error Viresh Kumar
2 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2024-11-16 11:31 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Marijn Suijten, linux-pm, devicetree, linux-kernel,
linux-arm-msm, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Comply with bindings guidelines and get rid of errors such as:
cpufreq@18323000: compatible: 'oneOf' conditional failed, one must be fixed:
['qcom,cpufreq-hw'] is too short
Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 717ec4ad63f3035b839d85fb1dd375fac9b0a2b7..745a7d0b8381046dda40dc31e61df905824d6388 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -3889,7 +3889,7 @@ lmh@18358800 {
};
cpufreq_hw: cpufreq@18323000 {
- compatible = "qcom,cpufreq-hw";
+ compatible = "qcom,sc8180x-cpufreq-hw", "qcom,cpufreq-hw";
reg = <0 0x18323000 0 0x1400>, <0 0x18325800 0 0x1400>;
reg-names = "freq-domain0", "freq-domain1";
--
2.47.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sc8180x: Add a SoC-specific compatible to cpufreq-hw
2024-11-16 11:31 ` [PATCH 2/2] arm64: dts: qcom: sc8180x: Add a SoC-specific compatible to cpufreq-hw Konrad Dybcio
@ 2024-11-17 13:11 ` Dmitry Baryshkov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-11-17 13:11 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Rafael J. Wysocki, Viresh Kumar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Bjorn Andersson, Vinod Koul, Marijn Suijten, linux-pm,
devicetree, linux-kernel, linux-arm-msm, Konrad Dybcio
On Sat, Nov 16, 2024 at 12:31:18PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Comply with bindings guidelines and get rid of errors such as:
>
> cpufreq@18323000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['qcom,cpufreq-hw'] is too short
>
> Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Fix SC8180X cpufreq dt-bindings error
2024-11-16 11:31 [PATCH 0/2] Fix SC8180X cpufreq dt-bindings error Konrad Dybcio
2024-11-16 11:31 ` [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SC8180X compatible Konrad Dybcio
2024-11-16 11:31 ` [PATCH 2/2] arm64: dts: qcom: sc8180x: Add a SoC-specific compatible to cpufreq-hw Konrad Dybcio
@ 2024-11-18 4:29 ` Viresh Kumar
2 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2024-11-18 4:29 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Rafael J. Wysocki, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam, Bjorn Andersson, Vinod Koul,
Marijn Suijten, linux-pm, devicetree, linux-kernel,
linux-arm-msm, Konrad Dybcio
On 16-11-24, 12:31, Konrad Dybcio wrote:
> Add the bindings and dt bits to fix:
>
> cpufreq@18323000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['qcom,cpufreq-hw'] is too short
>
> No functional changes.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Konrad Dybcio (2):
> dt-bindings: cpufreq: cpufreq-qcom-hw: Add SC8180X compatible
> arm64: dts: qcom: sc8180x: Add a SoC-specific compatible to cpufreq-hw
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread