From: Advait Dhamorikar <advaitdhamorikar@gmail.com>
To: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>
Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
Advait Dhamorikar <advaitdhamorikar@gmail.com>
Subject: [PATCH-next] afs: Remove logically dead code
Date: Sat, 16 Nov 2024 12:06:13 +0530 [thread overview]
Message-ID: <20241116063613.15120-1-advaitdhamorikar@gmail.com> (raw)
Initially ret is initialized to 0 and its value is then never updated
again, thus the indicated dead code may have performed some action;
that action will never occur.
Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
---
fs/afs/dir.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index b6a202fd9926..afa7c24828ec 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -502,8 +502,6 @@ static int afs_dir_iterate_contents(struct inode *dir, struct dir_context *ctx)
iterate_folioq(&iter, iov_iter_count(&iter), dvnode, ctx,
afs_dir_iterate_step);
- if (ret == -ESTALE)
- afs_invalidate_dir(dvnode, afs_dir_invalid_iter_stale);
return ret;
}
--
2.34.1
next reply other threads:[~2024-11-16 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 6:36 Advait Dhamorikar [this message]
2024-11-18 15:18 ` David Howells
2024-11-18 19:16 ` Advait Dhamorikar
2024-11-18 16:09 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241116063613.15120-1-advaitdhamorikar@gmail.com \
--to=advaitdhamorikar@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®