From: David Howells <dhowells@redhat.com>
To: Advait Dhamorikar <advaitdhamorikar@gmail.com>
Cc: dhowells@redhat.com, Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH-next] afs: Remove logically dead code
Date: Mon, 18 Nov 2024 16:09:48 +0000 [thread overview]
Message-ID: <940273.1731946188@warthog.procyon.org.uk> (raw)
In-Reply-To: <883923.1731943099@warthog.procyon.org.uk>
I think the attached change is what I want.
David
---
diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index b6a202fd9926..2adc034603f2 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -499,11 +499,11 @@ static int afs_dir_iterate_contents(struct inode *dir, struct dir_context *ctx)
iov_iter_folio_queue(&iter, ITER_SOURCE, dvnode->directory, 0, 0, i_size);
iov_iter_advance(&iter, round_down(ctx->pos, AFS_DIR_BLOCK_SIZE));
- iterate_folioq(&iter, iov_iter_count(&iter), dvnode, ctx,
- afs_dir_iterate_step);
-
- if (ret == -ESTALE)
+ if (!iterate_folioq(&iter, iov_iter_count(&iter), dvnode, ctx,
+ afs_dir_iterate_step)) {
afs_invalidate_dir(dvnode, afs_dir_invalid_iter_stale);
+ ret = -ESTALE;
+ }
return ret;
}
prev parent reply other threads:[~2024-11-18 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 6:36 Advait Dhamorikar
2024-11-18 15:18 ` David Howells
2024-11-18 19:16 ` Advait Dhamorikar
2024-11-18 16:09 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=940273.1731946188@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=advaitdhamorikar@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®