From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Hans Verkuil" <hverkuil@xs4all.nl>,
"Sebastian Fricke" <sebastian.fricke@collabora.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nicolas Dufresne" <nicolas@ndufresne.ca>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Jianhua Lu" <lujianhua000@gmail.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dikshita Agarwal" <quic_dikshita@quicinc.com>,
"Vedang Nagar" <quic_vnagar@quicinc.com>
Subject: [PATCH v6 12/28] media: iris: implement enum_fmt and enum_framesizes ioctls
Date: Wed, 20 Nov 2024 20:16:02 +0530 [thread overview]
Message-ID: <20241120-qcom-video-iris-v6-12-a8cf6704e992@quicinc.com> (raw)
In-Reply-To: <20241120-qcom-video-iris-v6-0-a8cf6704e992@quicinc.com>
From: Vedang Nagar <quic_vnagar@quicinc.com>
Implement enum_fmt and enum_framesizes ioctls with necessary hooks.
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
---
.../platform/qcom/iris/iris_platform_common.h | 4 +++
.../platform/qcom/iris/iris_platform_sm8550.c | 4 +++
drivers/media/platform/qcom/iris/iris_vdec.c | 17 ++++++++++
drivers/media/platform/qcom/iris/iris_vdec.h | 1 +
drivers/media/platform/qcom/iris/iris_vidc.c | 39 ++++++++++++++++++++++
5 files changed, 65 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
index d508477b066e..75d4932df910 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_common.h
+++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
@@ -43,6 +43,10 @@ struct ubwc_config_data {
};
struct platform_inst_caps {
+ u32 min_frame_width;
+ u32 max_frame_width;
+ u32 min_frame_height;
+ u32 max_frame_height;
u32 max_mbpf;
};
struct iris_core_power {
diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
index bc4769732aad..37c0130d7059 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
+++ b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
@@ -11,6 +11,10 @@
#define VIDEO_ARCH_LX 1
static struct platform_inst_caps platform_inst_cap_sm8550 = {
+ .min_frame_width = 96,
+ .max_frame_width = 8192,
+ .min_frame_height = 96,
+ .max_frame_height = 8192,
.max_mbpf = (8192 * 4352) / 256,
};
diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
index 11a2507fc35f..742b45432481 100644
--- a/drivers/media/platform/qcom/iris/iris_vdec.c
+++ b/drivers/media/platform/qcom/iris/iris_vdec.c
@@ -58,6 +58,23 @@ void iris_vdec_inst_deinit(struct iris_inst *inst)
kfree(inst->fmt_src);
}
+int iris_vdec_enum_fmt(struct iris_inst *inst, struct v4l2_fmtdesc *f)
+{
+ switch (f->type) {
+ case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
+ f->pixelformat = V4L2_PIX_FMT_H264;
+ f->flags = V4L2_FMT_FLAG_COMPRESSED | V4L2_FMT_FLAG_DYN_RESOLUTION;
+ break;
+ case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
+ f->pixelformat = V4L2_PIX_FMT_NV12;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
int iris_vdec_try_fmt(struct iris_inst *inst, struct v4l2_format *f)
{
struct v4l2_pix_format_mplane *pixmp = &f->fmt.pix_mp;
diff --git a/drivers/media/platform/qcom/iris/iris_vdec.h b/drivers/media/platform/qcom/iris/iris_vdec.h
index 85e93f33e9e7..ae456676e578 100644
--- a/drivers/media/platform/qcom/iris/iris_vdec.h
+++ b/drivers/media/platform/qcom/iris/iris_vdec.h
@@ -10,6 +10,7 @@ struct iris_inst;
void iris_vdec_inst_init(struct iris_inst *inst);
void iris_vdec_inst_deinit(struct iris_inst *inst);
+int iris_vdec_enum_fmt(struct iris_inst *inst, struct v4l2_fmtdesc *f);
int iris_vdec_try_fmt(struct iris_inst *inst, struct v4l2_format *f);
int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f);
diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c
index 6a32fd8d6123..bc77dfc2ba67 100644
--- a/drivers/media/platform/qcom/iris/iris_vidc.c
+++ b/drivers/media/platform/qcom/iris/iris_vidc.c
@@ -217,6 +217,16 @@ int iris_close(struct file *filp)
return 0;
}
+static int iris_enum_fmt(struct file *filp, void *fh, struct v4l2_fmtdesc *f)
+{
+ struct iris_inst *inst = iris_get_inst(filp, NULL);
+
+ if (f->index)
+ return -EINVAL;
+
+ return iris_vdec_enum_fmt(inst, f);
+}
+
static int iris_try_fmt_vid_mplane(struct file *filp, void *fh, struct v4l2_format *f)
{
struct iris_inst *inst = iris_get_inst(filp, NULL);
@@ -259,6 +269,32 @@ static int iris_g_fmt_vid_mplane(struct file *filp, void *fh, struct v4l2_format
return ret;
}
+static int iris_enum_framesizes(struct file *filp, void *fh,
+ struct v4l2_frmsizeenum *fsize)
+{
+ struct iris_inst *inst = iris_get_inst(filp, NULL);
+ struct platform_inst_caps *caps;
+
+ if (fsize->index)
+ return -EINVAL;
+
+ if (fsize->pixel_format != V4L2_PIX_FMT_H264 &&
+ fsize->pixel_format != V4L2_PIX_FMT_NV12)
+ return -EINVAL;
+
+ caps = inst->core->iris_platform_data->inst_caps;
+
+ fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
+ fsize->stepwise.min_width = caps->min_frame_width;
+ fsize->stepwise.max_width = caps->max_frame_width;
+ fsize->stepwise.step_width = STEP_WIDTH;
+ fsize->stepwise.min_height = caps->min_frame_height;
+ fsize->stepwise.max_height = caps->max_frame_height;
+ fsize->stepwise.step_height = STEP_HEIGHT;
+
+ return 0;
+}
+
static int iris_g_selection(struct file *filp, void *fh, struct v4l2_selection *s)
{
struct iris_inst *inst = iris_get_inst(filp, NULL);
@@ -300,12 +336,15 @@ static const struct vb2_ops iris_vb2_ops = {
};
static const struct v4l2_ioctl_ops iris_v4l2_ioctl_ops = {
+ .vidioc_enum_fmt_vid_cap = iris_enum_fmt,
+ .vidioc_enum_fmt_vid_out = iris_enum_fmt,
.vidioc_try_fmt_vid_cap_mplane = iris_try_fmt_vid_mplane,
.vidioc_try_fmt_vid_out_mplane = iris_try_fmt_vid_mplane,
.vidioc_s_fmt_vid_cap_mplane = iris_s_fmt_vid_mplane,
.vidioc_s_fmt_vid_out_mplane = iris_s_fmt_vid_mplane,
.vidioc_g_fmt_vid_cap_mplane = iris_g_fmt_vid_mplane,
.vidioc_g_fmt_vid_out_mplane = iris_g_fmt_vid_mplane,
+ .vidioc_enum_framesizes = iris_enum_framesizes,
.vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
.vidioc_g_selection = iris_g_selection,
};
--
2.34.1
next prev parent reply other threads:[~2024-11-20 14:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 14:45 [PATCH v6 00/28] Qualcomm iris video decoder driver Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 01/28] dt-bindings: media: Add video support for QCOM SM8550 SoC Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 02/28] media: iris: add platform driver for iris video device Dikshita Agarwal
2024-11-29 7:41 ` Hans Verkuil
2024-11-20 14:45 ` [PATCH v6 03/28] media: iris: implement iris v4l2 file ops Dikshita Agarwal
2024-11-29 8:46 ` Hans Verkuil
2024-11-20 14:45 ` [PATCH v6 04/28] media: iris: introduce iris core state management with shared queues Dikshita Agarwal
2024-11-20 15:54 ` Markus Elfring
2024-11-20 14:45 ` [PATCH v6 05/28] media: iris: implement video firmware load/unload Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 06/28] media: iris: implement boot sequence of the firmware Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 07/28] media: iris: introduce host firmware interface with necessary hooks Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 08/28] media: iris: implement power management Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 09/28] media: iris: implement reqbuf ioctl with vb2_queue_setup Dikshita Agarwal
2024-11-29 8:53 ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 10/28] media: iris: implement s_fmt, g_fmt and try_fmt ioctls Dikshita Agarwal
2024-11-29 9:01 ` Hans Verkuil
2024-12-09 9:32 ` Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 11/28] media: iris: implement g_selection ioctl Dikshita Agarwal
2024-12-06 9:54 ` Hans Verkuil
2024-11-20 14:46 ` Dikshita Agarwal [this message]
2024-11-29 9:02 ` [PATCH v6 12/28] media: iris: implement enum_fmt and enum_framesizes ioctls Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 13/28] media: iris: implement subscribe_event and unsubscribe_event ioctls Dikshita Agarwal
2024-12-06 9:54 ` Hans Verkuil
2024-12-09 9:37 ` Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 14/28] media: iris: implement iris v4l2_ctrl_ops Dikshita Agarwal
2024-11-29 9:03 ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 15/28] media: iris: implement query_cap ioctl Dikshita Agarwal
2024-12-06 9:49 ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 16/28] media: iris: implement vb2 streaming ops Dikshita Agarwal
2024-11-29 9:10 ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 17/28] media: iris: implement set properties to firmware during streamon Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 18/28] media: iris: subscribe parameters and properties to firmware for hfi_gen2 Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 19/28] media: iris: allocate, initialize and queue internal buffers Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 20/28] media: iris: implement vb2 ops for buf_queue and firmware response Dikshita Agarwal
2024-11-29 9:12 ` Hans Verkuil
2024-12-06 9:53 ` Hans Verkuil
2024-12-09 9:38 ` Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 21/28] media: iris: add support for dynamic resolution change Dikshita Agarwal
2024-11-29 9:13 ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 22/28] media: iris: handle streamoff/on from client in " Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 23/28] media: iris: add support for drain sequence Dikshita Agarwal
2024-11-29 9:22 ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 24/28] media: iris: add check whether the video session is supported or not Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 25/28] media: iris: implement power scaling for vpu2 and vpu3 Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 26/28] media: iris: add check to allow sub states transitions Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 27/28] media: iris: enable video driver probe of SM8250 SoC Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 28/28] media: MAINTAINERS: add Qualcomm iris video accelerator driver Dikshita Agarwal
2024-11-26 8:07 ` [PATCH v6 00/28] Qualcomm iris video decoder driver Sebastian Fricke
2024-11-29 9:24 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120-qcom-video-iris-v6-12-a8cf6704e992@quicinc.com \
--to=quic_dikshita@quicinc.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=quic_vnagar@quicinc.com \
--cc=robh@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®