mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Dikshita Agarwal <quic_dikshita@quicinc.com>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Sebastian Fricke" <sebastian.fricke@collabora.com>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Nicolas Dufresne" <nicolas@ndufresne.ca>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Jianhua Lu" <lujianhua000@gmail.com>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Vedang Nagar" <quic_vnagar@quicinc.com>
Subject: Re: [PATCH v6 15/28] media: iris: implement query_cap ioctl
Date: Fri, 6 Dec 2024 10:49:51 +0100	[thread overview]
Message-ID: <3d3bbf3c-d54b-4402-ac90-37f4c828c306@xs4all.nl> (raw)
In-Reply-To: <20241120-qcom-video-iris-v6-15-a8cf6704e992@quicinc.com>

On 20/11/2024 15:46, Dikshita Agarwal wrote:
> From: Vedang Nagar <quic_vnagar@quicinc.com>
> 
> Implement query_cap ioctl with necessary hooks.
> 
> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>

Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl>

Regards,

	Hans

> ---
>  drivers/media/platform/qcom/iris/iris_vidc.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c
> index 820d98da3190..26fdf03ab972 100644
> --- a/drivers/media/platform/qcom/iris/iris_vidc.c
> +++ b/drivers/media/platform/qcom/iris/iris_vidc.c
> @@ -303,6 +303,14 @@ static int iris_enum_framesizes(struct file *filp, void *fh,
>  	return 0;
>  }
>  
> +static int iris_querycap(struct file *filp, void *fh, struct v4l2_capability *cap)
> +{
> +	strscpy(cap->driver, IRIS_DRV_NAME, sizeof(cap->driver));
> +	strscpy(cap->card, "Iris Decoder", sizeof(cap->card));
> +
> +	return 0;
> +}
> +
>  static int iris_g_selection(struct file *filp, void *fh, struct v4l2_selection *s)
>  {
>  	struct iris_inst *inst = iris_get_inst(filp, NULL);
> @@ -361,6 +369,7 @@ static const struct v4l2_ioctl_ops iris_v4l2_ioctl_ops = {
>  	.vidioc_g_fmt_vid_out_mplane    = iris_g_fmt_vid_mplane,
>  	.vidioc_enum_framesizes         = iris_enum_framesizes,
>  	.vidioc_reqbufs                 = v4l2_m2m_ioctl_reqbufs,
> +	.vidioc_querycap                = iris_querycap,
>  	.vidioc_g_selection             = iris_g_selection,
>  	.vidioc_subscribe_event         = iris_subscribe_event,
>  	.vidioc_unsubscribe_event       = v4l2_event_unsubscribe,
> 


  reply	other threads:[~2024-12-06  9:49 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20 14:45 [PATCH v6 00/28] Qualcomm iris video decoder driver Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 01/28] dt-bindings: media: Add video support for QCOM SM8550 SoC Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 02/28] media: iris: add platform driver for iris video device Dikshita Agarwal
2024-11-29  7:41   ` Hans Verkuil
2024-11-20 14:45 ` [PATCH v6 03/28] media: iris: implement iris v4l2 file ops Dikshita Agarwal
2024-11-29  8:46   ` Hans Verkuil
2024-11-20 14:45 ` [PATCH v6 04/28] media: iris: introduce iris core state management with shared queues Dikshita Agarwal
2024-11-20 15:54   ` Markus Elfring
2024-11-20 14:45 ` [PATCH v6 05/28] media: iris: implement video firmware load/unload Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 06/28] media: iris: implement boot sequence of the firmware Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 07/28] media: iris: introduce host firmware interface with necessary hooks Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 08/28] media: iris: implement power management Dikshita Agarwal
2024-11-20 14:45 ` [PATCH v6 09/28] media: iris: implement reqbuf ioctl with vb2_queue_setup Dikshita Agarwal
2024-11-29  8:53   ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 10/28] media: iris: implement s_fmt, g_fmt and try_fmt ioctls Dikshita Agarwal
2024-11-29  9:01   ` Hans Verkuil
2024-12-09  9:32     ` Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 11/28] media: iris: implement g_selection ioctl Dikshita Agarwal
2024-12-06  9:54   ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 12/28] media: iris: implement enum_fmt and enum_framesizes ioctls Dikshita Agarwal
2024-11-29  9:02   ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 13/28] media: iris: implement subscribe_event and unsubscribe_event ioctls Dikshita Agarwal
2024-12-06  9:54   ` Hans Verkuil
2024-12-09  9:37     ` Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 14/28] media: iris: implement iris v4l2_ctrl_ops Dikshita Agarwal
2024-11-29  9:03   ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 15/28] media: iris: implement query_cap ioctl Dikshita Agarwal
2024-12-06  9:49   ` Hans Verkuil [this message]
2024-11-20 14:46 ` [PATCH v6 16/28] media: iris: implement vb2 streaming ops Dikshita Agarwal
2024-11-29  9:10   ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 17/28] media: iris: implement set properties to firmware during streamon Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 18/28] media: iris: subscribe parameters and properties to firmware for hfi_gen2 Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 19/28] media: iris: allocate, initialize and queue internal buffers Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 20/28] media: iris: implement vb2 ops for buf_queue and firmware response Dikshita Agarwal
2024-11-29  9:12   ` Hans Verkuil
2024-12-06  9:53   ` Hans Verkuil
2024-12-09  9:38     ` Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 21/28] media: iris: add support for dynamic resolution change Dikshita Agarwal
2024-11-29  9:13   ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 22/28] media: iris: handle streamoff/on from client in " Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 23/28] media: iris: add support for drain sequence Dikshita Agarwal
2024-11-29  9:22   ` Hans Verkuil
2024-11-20 14:46 ` [PATCH v6 24/28] media: iris: add check whether the video session is supported or not Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 25/28] media: iris: implement power scaling for vpu2 and vpu3 Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 26/28] media: iris: add check to allow sub states transitions Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 27/28] media: iris: enable video driver probe of SM8250 SoC Dikshita Agarwal
2024-11-20 14:46 ` [PATCH v6 28/28] media: MAINTAINERS: add Qualcomm iris video accelerator driver Dikshita Agarwal
2024-11-26  8:07 ` [PATCH v6 00/28] Qualcomm iris video decoder driver Sebastian Fricke
2024-11-29  9:24 ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d3bbf3c-d54b-4402-ac90-37f4c828c306@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lujianhua000@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nicolas@ndufresne.ca \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_dikshita@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=quic_vnagar@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sebastian.fricke@collabora.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®