* [PATCH 1/2] f2fs: fix to shrink read extent node in batches
@ 2024-11-21 1:57 Chao Yu
2024-11-21 1:57 ` [PATCH 2/2] f2fs: add a sysfs node to limit max read extent count per-inode Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: Chao Yu @ 2024-11-21 1:57 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu, Xiuhong Wang, Zhiguo Niu
We use rwlock to protect core structure data of extent tree during
its shrink, however, if there is a huge number of extent nodes in
extent tree, during shrink of extent tree, it may hold rwlock for
a very long time, which may trigger kernel hang issue.
This patch fixes to shrink read extent node in batches, so that,
critical region of the rwlock can be shrunk to avoid its extreme
long time hold.
Reported-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
Closes: https://lore.kernel.org/linux-f2fs-devel/20241112110627.1314632-1-xiuhong.wang@unisoc.com/
Signed-off-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/extent_cache.c | 69 +++++++++++++++++++++++++-----------------
1 file changed, 41 insertions(+), 28 deletions(-)
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 019c1f7b7fa5..b7a6817b44b0 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -379,21 +379,22 @@ static struct extent_tree *__grab_extent_tree(struct inode *inode,
}
static unsigned int __free_extent_tree(struct f2fs_sb_info *sbi,
- struct extent_tree *et)
+ struct extent_tree *et, unsigned int nr_shrink)
{
struct rb_node *node, *next;
struct extent_node *en;
- unsigned int count = atomic_read(&et->node_cnt);
+ unsigned int count;
node = rb_first_cached(&et->root);
- while (node) {
+
+ for (count = 0; node && count < nr_shrink; count++) {
next = rb_next(node);
en = rb_entry(node, struct extent_node, rb_node);
__release_extent_node(sbi, et, en);
node = next;
}
- return count - atomic_read(&et->node_cnt);
+ return count;
}
static void __drop_largest_extent(struct extent_tree *et,
@@ -622,6 +623,30 @@ static struct extent_node *__insert_extent_tree(struct f2fs_sb_info *sbi,
return en;
}
+static unsigned int __destroy_extent_node(struct inode *inode,
+ enum extent_type type)
+{
+ struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
+ struct extent_tree *et = F2FS_I(inode)->extent_tree[type];
+ unsigned int nr_shrink = type == EX_READ ?
+ READ_EXTENT_CACHE_SHRINK_NUMBER :
+ AGE_EXTENT_CACHE_SHRINK_NUMBER;
+ unsigned int node_cnt = 0;
+
+ if (!et || !atomic_read(&et->node_cnt))
+ return 0;
+
+ while (atomic_read(&et->node_cnt)) {
+ write_lock(&et->lock);
+ node_cnt += __free_extent_tree(sbi, et, nr_shrink);
+ write_unlock(&et->lock);
+ }
+
+ f2fs_bug_on(sbi, atomic_read(&et->node_cnt));
+
+ return node_cnt;
+}
+
static void __update_extent_tree_range(struct inode *inode,
struct extent_info *tei, enum extent_type type)
{
@@ -760,9 +785,6 @@ static void __update_extent_tree_range(struct inode *inode,
}
}
- if (is_inode_flag_set(inode, FI_NO_EXTENT))
- __free_extent_tree(sbi, et);
-
if (et->largest_updated) {
et->largest_updated = false;
updated = true;
@@ -780,6 +802,9 @@ static void __update_extent_tree_range(struct inode *inode,
out_read_extent_cache:
write_unlock(&et->lock);
+ if (is_inode_flag_set(inode, FI_NO_EXTENT))
+ __destroy_extent_node(inode, EX_READ);
+
if (updated)
f2fs_mark_inode_dirty_sync(inode, true);
}
@@ -942,10 +967,14 @@ static unsigned int __shrink_extent_tree(struct f2fs_sb_info *sbi, int nr_shrink
list_for_each_entry_safe(et, next, &eti->zombie_list, list) {
if (atomic_read(&et->node_cnt)) {
write_lock(&et->lock);
- node_cnt += __free_extent_tree(sbi, et);
+ node_cnt += __free_extent_tree(sbi, et,
+ nr_shrink - node_cnt - tree_cnt);
write_unlock(&et->lock);
}
- f2fs_bug_on(sbi, atomic_read(&et->node_cnt));
+
+ if (atomic_read(&et->node_cnt))
+ goto unlock_out;
+
list_del_init(&et->list);
radix_tree_delete(&eti->extent_tree_root, et->ino);
kmem_cache_free(extent_tree_slab, et);
@@ -1084,23 +1113,6 @@ unsigned int f2fs_shrink_age_extent_tree(struct f2fs_sb_info *sbi, int nr_shrink
return __shrink_extent_tree(sbi, nr_shrink, EX_BLOCK_AGE);
}
-static unsigned int __destroy_extent_node(struct inode *inode,
- enum extent_type type)
-{
- struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
- struct extent_tree *et = F2FS_I(inode)->extent_tree[type];
- unsigned int node_cnt = 0;
-
- if (!et || !atomic_read(&et->node_cnt))
- return 0;
-
- write_lock(&et->lock);
- node_cnt = __free_extent_tree(sbi, et);
- write_unlock(&et->lock);
-
- return node_cnt;
-}
-
void f2fs_destroy_extent_node(struct inode *inode)
{
__destroy_extent_node(inode, EX_READ);
@@ -1109,7 +1121,6 @@ void f2fs_destroy_extent_node(struct inode *inode)
static void __drop_extent_tree(struct inode *inode, enum extent_type type)
{
- struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
struct extent_tree *et = F2FS_I(inode)->extent_tree[type];
bool updated = false;
@@ -1117,7 +1128,6 @@ static void __drop_extent_tree(struct inode *inode, enum extent_type type)
return;
write_lock(&et->lock);
- __free_extent_tree(sbi, et);
if (type == EX_READ) {
set_inode_flag(inode, FI_NO_EXTENT);
if (et->largest.len) {
@@ -1126,6 +1136,9 @@ static void __drop_extent_tree(struct inode *inode, enum extent_type type)
}
}
write_unlock(&et->lock);
+
+ __destroy_extent_node(inode, type);
+
if (updated)
f2fs_mark_inode_dirty_sync(inode, true);
}
--
2.40.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] f2fs: add a sysfs node to limit max read extent count per-inode
2024-11-21 1:57 [PATCH 1/2] f2fs: fix to shrink read extent node in batches Chao Yu
@ 2024-11-21 1:57 ` Chao Yu
2024-11-22 5:23 ` [f2fs-dev] " Zhiguo Niu
0 siblings, 1 reply; 4+ messages in thread
From: Chao Yu @ 2024-11-21 1:57 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu, Xiuhong Wang, Zhiguo Niu
Quoted:
"at this time, there are still 1086911 extent nodes in this zombie
extent tree that need to be cleaned up.
crash_arm64_sprd_v8.0.3++> extent_tree.node_cnt ffffff80896cc500
node_cnt = {
counter = 1086911
},
"
As reported by Xiuhong, there will be a huge number of extent nodes
in extent tree, it may potentially cause:
- slab memory fragments
- extreme long time shrink on extent tree
- low mapping efficiency
Let's add a sysfs node to limit max read extent count for each inode,
by default, value of this threshold is 10240, it can be updated
according to user's requirement.
Reported-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
Closes: https://lore.kernel.org/linux-f2fs-devel/20241112110627.1314632-1-xiuhong.wang@unisoc.com/
Signed-off-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Signed-off-by: Chao Yu <chao@kernel.org>
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++++++
fs/f2fs/extent_cache.c | 5 ++++-
fs/f2fs/f2fs.h | 4 ++++
fs/f2fs/sysfs.c | 7 +++++++
4 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
index 513296bb6f29..3e1630c70d8a 100644
--- a/Documentation/ABI/testing/sysfs-fs-f2fs
+++ b/Documentation/ABI/testing/sysfs-fs-f2fs
@@ -822,3 +822,9 @@ Description: It controls the valid block ratio threshold not to trigger excessiv
for zoned deivces. The initial value of it is 95(%). F2FS will stop the
background GC thread from intiating GC for sections having valid blocks
exceeding the ratio.
+
+What: /sys/fs/f2fs/<disk>/max_read_extent_count
+Date: November 2024
+Contact: "Chao Yu" <chao@kernel.org>
+Description: It controls max read extent count for per-inode, the value of threshold
+ is 10240 by default.
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index b7a6817b44b0..347b3b647834 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -717,7 +717,9 @@ static void __update_extent_tree_range(struct inode *inode,
}
if (end < org_end && (type != EX_READ ||
- org_end - end >= F2FS_MIN_EXTENT_LEN)) {
+ (org_end - end >= F2FS_MIN_EXTENT_LEN &&
+ atomic_read(&et->node_cnt) <
+ sbi->max_read_extent_count))) {
if (parts) {
__set_extent_info(&ei,
end, org_end - end,
@@ -1212,6 +1214,7 @@ void f2fs_init_extent_cache_info(struct f2fs_sb_info *sbi)
sbi->hot_data_age_threshold = DEF_HOT_DATA_AGE_THRESHOLD;
sbi->warm_data_age_threshold = DEF_WARM_DATA_AGE_THRESHOLD;
sbi->last_age_weight = LAST_AGE_WEIGHT;
+ sbi->max_read_extent_count = DEF_MAX_READ_EXTENT_COUNT;
}
int __init f2fs_create_extent_cache(void)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index b65b023a588a..6f2cbf4c5740 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -635,6 +635,9 @@ enum {
#define DEF_HOT_DATA_AGE_THRESHOLD 262144
#define DEF_WARM_DATA_AGE_THRESHOLD 2621440
+/* default max read extent count per inode */
+#define DEF_MAX_READ_EXTENT_COUNT 10240
+
/* extent cache type */
enum extent_type {
EX_READ,
@@ -1619,6 +1622,7 @@ struct f2fs_sb_info {
/* for extent tree cache */
struct extent_tree_info extent_tree[NR_EXTENT_CACHES];
atomic64_t allocated_data_blocks; /* for block age extent_cache */
+ unsigned int max_read_extent_count; /* max read extent count per inode */
/* The threshold used for hot and warm data seperation*/
unsigned int hot_data_age_threshold;
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index bdbf24db667b..d1356c656cac 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -787,6 +787,13 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
return count;
}
+ if (!strcmp(a->attr.name, "max_read_extent_count")) {
+ if (t > UINT_MAX)
+ return -EINVAL;
+ *ui = (unsigned int)t;
+ return count;
+ }
+
if (!strcmp(a->attr.name, "ipu_policy")) {
if (t >= BIT(F2FS_IPU_MAX))
return -EINVAL;
--
2.40.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH 2/2] f2fs: add a sysfs node to limit max read extent count per-inode
2024-11-21 1:57 ` [PATCH 2/2] f2fs: add a sysfs node to limit max read extent count per-inode Chao Yu
@ 2024-11-22 5:23 ` Zhiguo Niu
2024-11-22 6:17 ` Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: Zhiguo Niu @ 2024-11-22 5:23 UTC (permalink / raw)
To: Chao Yu; +Cc: jaegeuk, Xiuhong Wang, Zhiguo Niu, linux-kernel, linux-f2fs-devel
Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
于2024年11月21日周四 10:01写道：
>
> Quoted:
> "at this time, there are still 1086911 extent nodes in this zombie
> extent tree that need to be cleaned up.
>
> crash_arm64_sprd_v8.0.3++> extent_tree.node_cnt ffffff80896cc500
> node_cnt = {
> counter = 1086911
> },
> "
>
> As reported by Xiuhong, there will be a huge number of extent nodes
> in extent tree, it may potentially cause:
> - slab memory fragments
> - extreme long time shrink on extent tree
> - low mapping efficiency
>
> Let's add a sysfs node to limit max read extent count for each inode,
> by default, value of this threshold is 10240, it can be updated
> according to user's requirement.
>
> Reported-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
> Closes: https://lore.kernel.org/linux-f2fs-devel/20241112110627.1314632-1-xiuhong.wang@unisoc.com/
> Signed-off-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++++++
> fs/f2fs/extent_cache.c | 5 ++++-
> fs/f2fs/f2fs.h | 4 ++++
> fs/f2fs/sysfs.c | 7 +++++++
> 4 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
> index 513296bb6f29..3e1630c70d8a 100644
> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
> @@ -822,3 +822,9 @@ Description: It controls the valid block ratio threshold not to trigger excessiv
> for zoned deivces. The initial value of it is 95(%). F2FS will stop the
> background GC thread from intiating GC for sections having valid blocks
> exceeding the ratio.
> +
> +What: /sys/fs/f2fs/<disk>/max_read_extent_count
> +Date: November 2024
> +Contact: "Chao Yu" <chao@kernel.org>
> +Description: It controls max read extent count for per-inode, the value of threshold
> + is 10240 by default.
> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> index b7a6817b44b0..347b3b647834 100644
> --- a/fs/f2fs/extent_cache.c
> +++ b/fs/f2fs/extent_cache.c
> @@ -717,7 +717,9 @@ static void __update_extent_tree_range(struct inode *inode,
> }
>
> if (end < org_end && (type != EX_READ ||
> - org_end - end >= F2FS_MIN_EXTENT_LEN)) {
> + (org_end - end >= F2FS_MIN_EXTENT_LEN &&
> + atomic_read(&et->node_cnt) <
> + sbi->max_read_extent_count))) {
> if (parts) {
> __set_extent_info(&ei,
> end, org_end - end,
> @@ -1212,6 +1214,7 @@ void f2fs_init_extent_cache_info(struct f2fs_sb_info *sbi)
> sbi->hot_data_age_threshold = DEF_HOT_DATA_AGE_THRESHOLD;
> sbi->warm_data_age_threshold = DEF_WARM_DATA_AGE_THRESHOLD;
> sbi->last_age_weight = LAST_AGE_WEIGHT;
> + sbi->max_read_extent_count = DEF_MAX_READ_EXTENT_COUNT;
> }
>
> int __init f2fs_create_extent_cache(void)
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index b65b023a588a..6f2cbf4c5740 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -635,6 +635,9 @@ enum {
> #define DEF_HOT_DATA_AGE_THRESHOLD 262144
> #define DEF_WARM_DATA_AGE_THRESHOLD 2621440
>
> +/* default max read extent count per inode */
> +#define DEF_MAX_READ_EXTENT_COUNT 10240
> +
> /* extent cache type */
> enum extent_type {
> EX_READ,
> @@ -1619,6 +1622,7 @@ struct f2fs_sb_info {
> /* for extent tree cache */
> struct extent_tree_info extent_tree[NR_EXTENT_CACHES];
> atomic64_t allocated_data_blocks; /* for block age extent_cache */
> + unsigned int max_read_extent_count; /* max read extent count per inode */
>
> /* The threshold used for hot and warm data seperation*/
> unsigned int hot_data_age_threshold;
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index bdbf24db667b..d1356c656cac 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -787,6 +787,13 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
> return count;
> }
>
> + if (!strcmp(a->attr.name, "max_read_extent_count")) {
> + if (t > UINT_MAX)
> + return -EINVAL;
> + *ui = (unsigned int)t;
> + return count;
> + }
> +
Hi Chao,
from Xiuhong remider, it seems miss codes of adding sysfs node
"max_read_extent_count"?
F2FS_SBI_GENERAL_RW_ATTR(max_read_extent_count);
ATTR_LIST(max_read_extent_count);
thanks！
> if (!strcmp(a->attr.name, "ipu_policy")) {
> if (t >= BIT(F2FS_IPU_MAX))
> return -EINVAL;
> --
> 2.40.1
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH 2/2] f2fs: add a sysfs node to limit max read extent count per-inode
2024-11-22 5:23 ` [f2fs-dev] " Zhiguo Niu
@ 2024-11-22 6:17 ` Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2024-11-22 6:17 UTC (permalink / raw)
To: Zhiguo Niu
Cc: Chao Yu, jaegeuk, Xiuhong Wang, Zhiguo Niu, linux-kernel,
linux-f2fs-devel
On 2024/11/22 13:23, Zhiguo Niu wrote:
> Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
> 于2024年11月21日周四 10:01写道：
>>
>> Quoted:
>> "at this time, there are still 1086911 extent nodes in this zombie
>> extent tree that need to be cleaned up.
>>
>> crash_arm64_sprd_v8.0.3++> extent_tree.node_cnt ffffff80896cc500
>> node_cnt = {
>> counter = 1086911
>> },
>> "
>>
>> As reported by Xiuhong, there will be a huge number of extent nodes
>> in extent tree, it may potentially cause:
>> - slab memory fragments
>> - extreme long time shrink on extent tree
>> - low mapping efficiency
>>
>> Let's add a sysfs node to limit max read extent count for each inode,
>> by default, value of this threshold is 10240, it can be updated
>> according to user's requirement.
>>
>> Reported-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
>> Closes: https://lore.kernel.org/linux-f2fs-devel/20241112110627.1314632-1-xiuhong.wang@unisoc.com/
>> Signed-off-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
>> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>> Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++++++
>> fs/f2fs/extent_cache.c | 5 ++++-
>> fs/f2fs/f2fs.h | 4 ++++
>> fs/f2fs/sysfs.c | 7 +++++++
>> 4 files changed, 21 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
>> index 513296bb6f29..3e1630c70d8a 100644
>> --- a/Documentation/ABI/testing/sysfs-fs-f2fs
>> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs
>> @@ -822,3 +822,9 @@ Description: It controls the valid block ratio threshold not to trigger excessiv
>> for zoned deivces. The initial value of it is 95(%). F2FS will stop the
>> background GC thread from intiating GC for sections having valid blocks
>> exceeding the ratio.
>> +
>> +What: /sys/fs/f2fs/<disk>/max_read_extent_count
>> +Date: November 2024
>> +Contact: "Chao Yu" <chao@kernel.org>
>> +Description: It controls max read extent count for per-inode, the value of threshold
>> + is 10240 by default.
>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
>> index b7a6817b44b0..347b3b647834 100644
>> --- a/fs/f2fs/extent_cache.c
>> +++ b/fs/f2fs/extent_cache.c
>> @@ -717,7 +717,9 @@ static void __update_extent_tree_range(struct inode *inode,
>> }
>>
>> if (end < org_end && (type != EX_READ ||
>> - org_end - end >= F2FS_MIN_EXTENT_LEN)) {
>> + (org_end - end >= F2FS_MIN_EXTENT_LEN &&
>> + atomic_read(&et->node_cnt) <
>> + sbi->max_read_extent_count))) {
>> if (parts) {
>> __set_extent_info(&ei,
>> end, org_end - end,
>> @@ -1212,6 +1214,7 @@ void f2fs_init_extent_cache_info(struct f2fs_sb_info *sbi)
>> sbi->hot_data_age_threshold = DEF_HOT_DATA_AGE_THRESHOLD;
>> sbi->warm_data_age_threshold = DEF_WARM_DATA_AGE_THRESHOLD;
>> sbi->last_age_weight = LAST_AGE_WEIGHT;
>> + sbi->max_read_extent_count = DEF_MAX_READ_EXTENT_COUNT;
>> }
>>
>> int __init f2fs_create_extent_cache(void)
>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
>> index b65b023a588a..6f2cbf4c5740 100644
>> --- a/fs/f2fs/f2fs.h
>> +++ b/fs/f2fs/f2fs.h
>> @@ -635,6 +635,9 @@ enum {
>> #define DEF_HOT_DATA_AGE_THRESHOLD 262144
>> #define DEF_WARM_DATA_AGE_THRESHOLD 2621440
>>
>> +/* default max read extent count per inode */
>> +#define DEF_MAX_READ_EXTENT_COUNT 10240
>> +
>> /* extent cache type */
>> enum extent_type {
>> EX_READ,
>> @@ -1619,6 +1622,7 @@ struct f2fs_sb_info {
>> /* for extent tree cache */
>> struct extent_tree_info extent_tree[NR_EXTENT_CACHES];
>> atomic64_t allocated_data_blocks; /* for block age extent_cache */
>> + unsigned int max_read_extent_count; /* max read extent count per inode */
>>
>> /* The threshold used for hot and warm data seperation*/
>> unsigned int hot_data_age_threshold;
>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
>> index bdbf24db667b..d1356c656cac 100644
>> --- a/fs/f2fs/sysfs.c
>> +++ b/fs/f2fs/sysfs.c
>> @@ -787,6 +787,13 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
>> return count;
>> }
>>
>> + if (!strcmp(a->attr.name, "max_read_extent_count")) {
>> + if (t > UINT_MAX)
>> + return -EINVAL;
>> + *ui = (unsigned int)t;
>> + return count;
>> + }
>> +
> Hi Chao,
> from Xiuhong remider, it seems miss codes of adding sysfs node
> "max_read_extent_count"?
> F2FS_SBI_GENERAL_RW_ATTR(max_read_extent_count);
> ATTR_LIST(max_read_extent_count);
Oops, let me fix this soon.
Thanks,
> thanks！
>> if (!strcmp(a->attr.name, "ipu_policy")) {
>> if (t >= BIT(F2FS_IPU_MAX))
>> return -EINVAL;
>> --
>> 2.40.1
>>
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-22 6:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-21 1:57 [PATCH 1/2] f2fs: fix to shrink read extent node in batches Chao Yu
2024-11-21 1:57 ` [PATCH 2/2] f2fs: add a sysfs node to limit max read extent count per-inode Chao Yu
2024-11-22 5:23 ` [f2fs-dev] " Zhiguo Niu
2024-11-22 6:17 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®