uprobe_events can't accept paths that contain spaces

uprobe_events can't accept paths that contain spaces

[Yuxuan Shui]

Hi,

I hit this problem accidentally when one of the shared libraries I was
looking at is located in a directory with spaces in its name. `perf
probe` reported "Failed to write event: Invalid argument".

If I understand the code correctly, strings written into uprobe_events
are strictly splitted at whitespaces (by `argv_split`). This seems
like an unfortunate restriction. If I submit a patch to introduce
support for either quotes (") or escapes (\), will that be considered?

(For context I am running something that expects its libraries to be
located at fixed paths, so moving them to a different path would be
awkward at best.)

Thanks.

-- 

Regards
Yuxuan Shui

Re: uprobe_events can't accept paths that contain spaces

[Masami Hiramatsu]

On Fri, 22 Nov 2024 00:42:51 +0000
Yuxuan Shui <yshuiv7@gmail.com> wrote:

> Hi,
> 
> I hit this problem accidentally when one of the shared libraries I was
> looking at is located in a directory with spaces in its name. `perf
> probe` reported "Failed to write event: Invalid argument".

Oops, yes, it is limited by implementation.

> 
> If I understand the code correctly, strings written into uprobe_events
> are strictly splitted at whitespaces (by `argv_split`).

Right!

> This seems
> like an unfortunate restriction. If I submit a patch to introduce
> support for either quotes (") or escapes (\), will that be considered?

Yeah, that enhancement is welcome! You can add such function in
trace_probe.c and use it instead of argv_split.

> 
> (For context I am running something that expects its libraries to be
> located at fixed paths, so moving them to a different path would be
> awkward at best.)

Thanks,

> 
> Thanks.
> 
> -- 
> 
> Regards
> Yuxuan Shui


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>