* [PATCH] mtd: rawnand: brcmnand: fix status read of brcmnand_waitfunc
@ 2024-11-26 2:39 david regan
2024-12-24 12:40 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: david regan @ 2024-11-26 2:39 UTC (permalink / raw)
To: Brian Norris, Kamal Dasu, Boris Brezillon, Miquel Raynal,
Richard Weinberger, David Woodhouse, Marek Vasut, linux-mtd,
bcm-kernel-feedback-list, linux-kernel, Ruan Jinjie,
William Zhang, dregan, dregan
This change fixes an issue where an error return value may be mistakenly
used as NAND status.
Fixes: f504551b7f15 ("mtd: rawnand: Propagate error and simplify ternary operators for brcmstb_nand_wait_for_completion()")
Signed-off-by: david regan <dregan@broadcom.com>
Reviewed-by: William Zhang <william.zhang@broadcom.com>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 482c6f093f99..701aa19328ad 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -1893,6 +1893,11 @@ static int brcmnand_write(struct mtd_info *mtd, struct nand_chip *chip,
brcmnand_send_cmd(host, CMD_PROGRAM_PAGE);
status = brcmnand_waitfunc(chip);
+ if (status < 0) {
+ ret = status;
+ goto out;
+ }
+
if (status & NAND_STATUS_FAIL) {
dev_info(ctrl->dev, "program failed at %llx\n",
(unsigned long long)addr);
--
2.37.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: brcmnand: fix status read of brcmnand_waitfunc
2024-11-26 2:39 [PATCH] mtd: rawnand: brcmnand: fix status read of brcmnand_waitfunc david regan
@ 2024-12-24 12:40 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2024-12-24 12:40 UTC (permalink / raw)
To: Brian Norris, Kamal Dasu, Boris Brezillon, Richard Weinberger,
David Woodhouse, Marek Vasut, linux-mtd,
bcm-kernel-feedback-list, linux-kernel, Ruan Jinjie,
William Zhang, dregan, david regan
Cc: Miquel Raynal
On Mon, 25 Nov 2024 18:39:16 -0800, david regan wrote:
> This change fixes an issue where an error return value may be mistakenly
> used as NAND status.
>
>
Applied to nand/next, thanks!
[1/1] mtd: rawnand: brcmnand: fix status read of brcmnand_waitfunc
commit: 03271ea36ea7a58d30a4bde182eb2a0d46220467
Patche(s) will be available within hours on:
mtd/linux.git
Kind regards,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-24 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-26 2:39 [PATCH] mtd: rawnand: brcmnand: fix status read of brcmnand_waitfunc david regan
2024-12-24 12:40 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®