* [PATCH] HID: Fix the bit shift number for LED_KANA.
@ 2024-11-28 2:35 junan
2025-02-03 21:51 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: junan @ 2024-11-28 2:35 UTC (permalink / raw)
To: jikos, bentiss; +Cc: linux-usb, linux-input, linux-kernel, junan
Since "LED_KANA" was defined as "0x04", the shift number should be "4".
Signed-off-by: junan <junan76@163.com>
---
drivers/hid/usbhid/usbkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index c439ed2f16db..af6bc76dbf64 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -160,7 +160,7 @@ static int usb_kbd_event(struct input_dev *dev, unsigned int type,
return -1;
spin_lock_irqsave(&kbd->leds_lock, flags);
- kbd->newleds = (!!test_bit(LED_KANA, dev->led) << 3) | (!!test_bit(LED_COMPOSE, dev->led) << 3) |
+ kbd->newleds = (!!test_bit(LED_KANA, dev->led) << 4) | (!!test_bit(LED_COMPOSE, dev->led) << 3) |
(!!test_bit(LED_SCROLLL, dev->led) << 2) | (!!test_bit(LED_CAPSL, dev->led) << 1) |
(!!test_bit(LED_NUML, dev->led));
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: Fix the bit shift number for LED_KANA.
2024-11-28 2:35 [PATCH] HID: Fix the bit shift number for LED_KANA junan
@ 2025-02-03 21:51 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2025-02-03 21:51 UTC (permalink / raw)
To: junan; +Cc: bentiss, linux-usb, linux-input, linux-kernel
On Thu, 28 Nov 2024, junan wrote:
> Since "LED_KANA" was defined as "0x04", the shift number should be "4".
Heh, this bug has been there for _*AGES*_, and it's a pretty obscure
driver anyway. Let's fix it though, thanks. Applied.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-03 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-28 2:35 [PATCH] HID: Fix the bit shift number for LED_KANA junan
2025-02-03 21:51 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®