mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] bcache: Add missing parameter description to bch2_bucket_alloc_trans()
@ 2024-11-29  6:38 Yang Li
  2024-11-29 21:13 ` Kent Overstreet
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2024-11-29  6:38 UTC (permalink / raw)
  To: kent.overstreet; +Cc: linux-bcachefs, linux-kernel, Yang Li, Abaci Robot

The function bch2_bucket_alloc_trans() lacked a description for the
nowait parameter in its documentation comment block. This patch adds the
missing description to ensure all parameters are properly documented.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=12179
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/bcachefs/alloc_foreground.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
index 4d1ff7f1f302..2f1ea718cc33 100644
--- a/fs/bcachefs/alloc_foreground.c
+++ b/fs/bcachefs/alloc_foreground.c
@@ -505,6 +505,7 @@ static noinline void trace_bucket_alloc2(struct bch_fs *c, struct bch_dev *ca,
  * @watermark:	how important is this allocation?
  * @data_type:	BCH_DATA_journal, btree, user...
  * @cl:		if not NULL, closure to be used to wait if buckets not available
+ * @nowait:	if true, do not wait for buckets to become available
  * @usage:	for secondarily also returning the current device usage
  *
  * Returns:	an open_bucket on success, or an ERR_PTR() on failure.
-- 
2.32.0.3.g01195cf9f


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] bcache: Add missing parameter description to bch2_bucket_alloc_trans()
  2024-11-29  6:38 [PATCH -next] bcache: Add missing parameter description to bch2_bucket_alloc_trans() Yang Li
@ 2024-11-29 21:13 ` Kent Overstreet
  0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2024-11-29 21:13 UTC (permalink / raw)
  To: Yang Li; +Cc: linux-bcachefs, linux-kernel, Abaci Robot

On Fri, Nov 29, 2024 at 02:38:27PM +0800, Yang Li wrote:
> The function bch2_bucket_alloc_trans() lacked a description for the
> nowait parameter in its documentation comment block. This patch adds the
> missing description to ensure all parameters are properly documented.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=12179
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-29 21:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-29  6:38 [PATCH -next] bcache: Add missing parameter description to bch2_bucket_alloc_trans() Yang Li
2024-11-29 21:13 ` Kent Overstreet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®