mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [for-next][PATCH] vsnprintf: Remove unused 'bprintf'
@ 2024-12-01 13:11 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2024-12-01 13:11 UTC (permalink / raw)
  To: LKML; +Cc: Petr Mladek, Andy Shevchenko, Dr. David Alan Gilbert


vsnprintf: Removal of bprintf()

- Remove unused bprintf() function

  bprintf() was added with the rest of the "bin-printf" functions.
  These are functions that are used by trace_printk() that allows to
  quickly save the format and arguments into the ring buffer without
  the expensive processing of converting numbers to ASCII. Then on
  output, at a much later time, the ring buffer is read and the string
  processing occurs then. The bprintf() was added for consistency but
  was never used. It can be safely removed.

  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/for-next

Head SHA1: f69e63756f7822fcdad8a34f9967e8b243e883ee


Dr. David Alan Gilbert (1):
      printf: Remove unused 'bprintf'

----
 include/linux/string.h |  1 -
 lib/vsprintf.c         | 23 -----------------------
 2 files changed, 24 deletions(-)
---------------------------
commit f69e63756f7822fcdad8a34f9967e8b243e883ee
Author: Dr. David Alan Gilbert <linux@treblig.org>
Date:   Wed Oct 2 18:31:47 2024 +0100

    printf: Remove unused 'bprintf'
    
    bprintf() is unused. Remove it. It was added in the commit 4370aa4aa753
    ("vsprintf: add binary printf") but as far as I can see was never used,
    unlike the other two functions in that patch.
    
    Link: https://lore.kernel.org/20241002173147.210107-1-linux@treblig.org
    Reviewed-by: Andy Shevchenko <andy@kernel.org>
    Acked-by: Petr Mladek <pmladek@suse.com>
    Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
    Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

diff --git a/include/linux/string.h b/include/linux/string.h
index 0dd27afcfaf7..493ac4862c77 100644
--- a/include/linux/string.h
+++ b/include/linux/string.h
@@ -335,7 +335,6 @@ int __sysfs_match_string(const char * const *array, size_t n, const char *s);
 #ifdef CONFIG_BINARY_PRINTF
 int vbin_printf(u32 *bin_buf, size_t size, const char *fmt, va_list args);
 int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf);
-int bprintf(u32 *bin_buf, size_t size, const char *fmt, ...) __printf(3, 4);
 #endif
 
 extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 6ac02bbb7df1..9d3dac38a3f4 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -3428,29 +3428,6 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
 }
 EXPORT_SYMBOL_GPL(bstr_printf);
 
-/**
- * bprintf - Parse a format string and place args' binary value in a buffer
- * @bin_buf: The buffer to place args' binary value
- * @size: The size of the buffer(by words(32bits), not characters)
- * @fmt: The format string to use
- * @...: Arguments for the format string
- *
- * The function returns the number of words(u32) written
- * into @bin_buf.
- */
-int bprintf(u32 *bin_buf, size_t size, const char *fmt, ...)
-{
-	va_list args;
-	int ret;
-
-	va_start(args, fmt);
-	ret = vbin_printf(bin_buf, size, fmt, args);
-	va_end(args);
-
-	return ret;
-}
-EXPORT_SYMBOL_GPL(bprintf);
-
 #endif /* CONFIG_BINARY_PRINTF */
 
 /**

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-12-01 13:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-01 13:11 [for-next][PATCH] vsnprintf: Remove unused 'bprintf' Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®