* [PATCH 0/2] sunxi: Add A100 syscon nodes
@ 2024-12-02 4:43 Cody Eksal
2024-12-02 4:43 ` [PATCH 1/2] dt-bindings: sram: sunxi-sram: Add A100 compatible Cody Eksal
2024-12-02 4:43 ` [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes Cody Eksal
0 siblings, 2 replies; 6+ messages in thread
From: Cody Eksal @ 2024-12-02 4:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Maxime Ripard
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
Parthiban Nallathambi, Andre Przywara, Cody Eksal
Hello again! Happy December!
Here are some very small patches to add syscon nodes to the A100's
device tree. These had not been added yet, as they hadn't been needed up
to this point. However, Parthiban and I have been working on patch
series in parallel that require either the syscon or the SRAM nodes it
is responsible for; specifically my patches add support for the A100's
ethernet controller, while Parthiban has been working hard on bringing
up the Display Engine.
Thanks as always!
- Cody
Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest>
---
Cody Eksal (2):
dt-bindings: sram: sunxi-sram: Add A100 compatible
arm64: dts: allwinner: a100: Add syscon nodes
.../sram/allwinner,sun4i-a10-system-control.yaml | 4 ++-
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 31 ++++++++++++++++++++++
2 files changed, 34 insertions(+), 1 deletion(-)
---
base-commit: e70140ba0d2b1a30467d4af6bcfe761327b9ec95
change-id: 20241126-a100-syscon-7316bea62e42
Best regards,
--
Cody Eksal <masterr3c0rd@epochal.quest>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: sram: sunxi-sram: Add A100 compatible
2024-12-02 4:43 [PATCH 0/2] sunxi: Add A100 syscon nodes Cody Eksal
@ 2024-12-02 4:43 ` Cody Eksal
2024-12-02 8:43 ` Krzysztof Kozlowski
2024-12-02 4:43 ` [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes Cody Eksal
1 sibling, 1 reply; 6+ messages in thread
From: Cody Eksal @ 2024-12-02 4:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Maxime Ripard
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
Parthiban Nallathambi, Andre Przywara, Cody Eksal
The Allwinner A100 has a system configuration block similar to that of
the A64 and H6. Add a compatible for it.
Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest>
---
.../devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
index d9322704f3588e036280d08deaf59972f1dfeb7f..a7236f7db4ec34d44c4e2268f76281ef8ed83189 100644
--- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
+++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
@@ -47,7 +47,9 @@ properties:
- const: allwinner,sun8i-v3s-system-control
- const: allwinner,sun8i-h3-system-control
- items:
- - const: allwinner,sun50i-h6-system-control
+ - enum:
+ - allwinner,sun50i-a100-system-control
+ - allwinner,sun50i-h6-system-control
- const: allwinner,sun50i-a64-system-control
reg:
--
2.47.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes
2024-12-02 4:43 [PATCH 0/2] sunxi: Add A100 syscon nodes Cody Eksal
2024-12-02 4:43 ` [PATCH 1/2] dt-bindings: sram: sunxi-sram: Add A100 compatible Cody Eksal
@ 2024-12-02 4:43 ` Cody Eksal
2024-12-02 4:51 ` Parthiban
2024-12-03 15:34 ` Chen-Yu Tsai
1 sibling, 2 replies; 6+ messages in thread
From: Cody Eksal @ 2024-12-02 4:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Maxime Ripard
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
Parthiban Nallathambi, Andre Przywara, Cody Eksal
The Allwinner A100 has a system configuration block, denoted as SYS_CFG
in the user manual's memory map. It is undocumented in the manual, but
a glance at the vendor tree shows this block is similar to its
predecessors in the A64 and H6. The A100 also has 3 SRAM blocks: A1, A2,
and C. Add all of these to the SoC's device tree.
Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest>
---
arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 31 ++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
index 29ac7716c7a5284ccf8af675db9c7d016785f0ff..31540a7ca1f01c6c2e69e329054aca16ffd112c4 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
@@ -101,6 +101,37 @@ soc {
#size-cells = <1>;
ranges = <0 0 0 0x3fffffff>;
+ syscon: syscon@3000000 {
+ compatible = "allwinner,sun50i-a100-system-control",
+ "allwinner,sun50i-a64-system-control";
+ reg = <0x03000000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ sram_a1: sram@20000 {
+ compatible = "mmio-sram";
+ reg = <0x00020000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x00020000 0x4000>;
+ };
+ sram_c: sram@24000 {
+ compatible = "mmio-sram";
+ reg = <0x024000 0x21000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x024000 0x21000>;
+ };
+ sram_a2: sram@100000 {
+ compatible = "mmio-sram";
+ reg = <0x0100000 0x14000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x0100000 0x14000>;
+ };
+ };
+
ccu: clock@3001000 {
compatible = "allwinner,sun50i-a100-ccu";
reg = <0x03001000 0x1000>;
--
2.47.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes
2024-12-02 4:43 ` [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes Cody Eksal
@ 2024-12-02 4:51 ` Parthiban
2024-12-03 15:34 ` Chen-Yu Tsai
1 sibling, 0 replies; 6+ messages in thread
From: Parthiban @ 2024-12-02 4:51 UTC (permalink / raw)
To: Cody Eksal, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Maxime Ripard
Cc: parthiban, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, Andre Przywara
On 12/2/24 10:13 AM, Cody Eksal wrote:
> The Allwinner A100 has a system configuration block, denoted as SYS_CFG
> in the user manual's memory map. It is undocumented in the manual, but
> a glance at the vendor tree shows this block is similar to its
> predecessors in the A64 and H6. The A100 also has 3 SRAM blocks: A1, A2,
> and C. Add all of these to the SoC's device tree.
>
> Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest>
Reviewed-by: Parthiban Nallathambi <parthiban@linumiz.com>
Thanks,
Parthiban
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 31 ++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> index 29ac7716c7a5284ccf8af675db9c7d016785f0ff..31540a7ca1f01c6c2e69e329054aca16ffd112c4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> @@ -101,6 +101,37 @@ soc {
> #size-cells = <1>;
> ranges = <0 0 0 0x3fffffff>;
>
> + syscon: syscon@3000000 {
> + compatible = "allwinner,sun50i-a100-system-control",
> + "allwinner,sun50i-a64-system-control";
> + reg = <0x03000000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + sram_a1: sram@20000 {
> + compatible = "mmio-sram";
> + reg = <0x00020000 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x00020000 0x4000>;
> + };
> + sram_c: sram@24000 {
> + compatible = "mmio-sram";
> + reg = <0x024000 0x21000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x024000 0x21000>;
> + };
> + sram_a2: sram@100000 {
> + compatible = "mmio-sram";
> + reg = <0x0100000 0x14000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x0100000 0x14000>;
> + };
> + };
> +
> ccu: clock@3001000 {
> compatible = "allwinner,sun50i-a100-ccu";
> reg = <0x03001000 0x1000>;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: sram: sunxi-sram: Add A100 compatible
2024-12-02 4:43 ` [PATCH 1/2] dt-bindings: sram: sunxi-sram: Add A100 compatible Cody Eksal
@ 2024-12-02 8:43 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-02 8:43 UTC (permalink / raw)
To: Cody Eksal
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Maxime Ripard, devicetree,
linux-arm-kernel, linux-sunxi, linux-kernel,
Parthiban Nallathambi, Andre Przywara
On Mon, Dec 02, 2024 at 12:43:26AM -0400, Cody Eksal wrote:
> The Allwinner A100 has a system configuration block similar to that of
> the A64 and H6. Add a compatible for it.
>
> Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes
2024-12-02 4:43 ` [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes Cody Eksal
2024-12-02 4:51 ` Parthiban
@ 2024-12-03 15:34 ` Chen-Yu Tsai
1 sibling, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2024-12-03 15:34 UTC (permalink / raw)
To: Cody Eksal
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jernej Skrabec,
Samuel Holland, Maxime Ripard, devicetree, linux-arm-kernel,
linux-sunxi, linux-kernel, Parthiban Nallathambi, Andre Przywara
On Mon, Dec 2, 2024 at 12:43 PM Cody Eksal <masterr3c0rd@epochal.quest> wrote:
>
> The Allwinner A100 has a system configuration block, denoted as SYS_CFG
> in the user manual's memory map. It is undocumented in the manual, but
> a glance at the vendor tree shows this block is similar to its
> predecessors in the A64 and H6. The A100 also has 3 SRAM blocks: A1, A2,
> and C. Add all of these to the SoC's device tree.
>
> Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 31 ++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> index 29ac7716c7a5284ccf8af675db9c7d016785f0ff..31540a7ca1f01c6c2e69e329054aca16ffd112c4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> @@ -101,6 +101,37 @@ soc {
> #size-cells = <1>;
> ranges = <0 0 0 0x3fffffff>;
>
> + syscon: syscon@3000000 {
> + compatible = "allwinner,sun50i-a100-system-control",
> + "allwinner,sun50i-a64-system-control";
> + reg = <0x03000000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + sram_a1: sram@20000 {
> + compatible = "mmio-sram";
> + reg = <0x00020000 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x00020000 0x4000>;
> + };
Each child node should have an empty line preceding it, as mentioned
in the dts coding style doc:
Documentation/devicetree/bindings/dts-coding-style.rst
ChenYu
> + sram_c: sram@24000 {
> + compatible = "mmio-sram";
> + reg = <0x024000 0x21000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x024000 0x21000>;
> + };
> + sram_a2: sram@100000 {
> + compatible = "mmio-sram";
> + reg = <0x0100000 0x14000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x0100000 0x14000>;
> + };
> + };
> +
> ccu: clock@3001000 {
> compatible = "allwinner,sun50i-a100-ccu";
> reg = <0x03001000 0x1000>;
>
> --
> 2.47.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-03 15:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-02 4:43 [PATCH 0/2] sunxi: Add A100 syscon nodes Cody Eksal
2024-12-02 4:43 ` [PATCH 1/2] dt-bindings: sram: sunxi-sram: Add A100 compatible Cody Eksal
2024-12-02 8:43 ` Krzysztof Kozlowski
2024-12-02 4:43 ` [PATCH 2/2] arm64: dts: allwinner: a100: Add syscon nodes Cody Eksal
2024-12-02 4:51 ` Parthiban
2024-12-03 15:34 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®