mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] irqchip/gic-v3: Fix irq_complete_ack() comment
@ 2024-12-02 11:25 Lorenzo Pieralisi
  2024-12-03 11:20 ` [tip: irq/urgent] " tip-bot2 for Lorenzo Pieralisi
  0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Pieralisi @ 2024-12-02 11:25 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: linux-kernel, Mark Rutland, Marc Zyngier

When the GIC is in EOImode == 1 in irq_complete_ack() we
execute a priority drop not a deactivation.

Fix the function comment to clarify the behaviour.

Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Marc Zyngier <maz@kernel.org>
---
 drivers/irqchip/irq-gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 8b6159f4cdaf..34db379d066a 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -817,7 +817,7 @@ static void gic_deactivate_unhandled(u32 irqnr)
  *     register state is not stale, as these may have been indirectly written
  *     *after* exception entry.
  *
- * (2) Deactivate the interrupt when EOI mode 1 is in use.
+ * (2) Execute an interrupt priority drop when EOI mode 1 is in use.
  */
 static inline void gic_complete_ack(u32 irqnr)
 {
-- 
2.47.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip: irq/urgent] irqchip/gic-v3: Fix irq_complete_ack() comment
  2024-12-02 11:25 [PATCH] irqchip/gic-v3: Fix irq_complete_ack() comment Lorenzo Pieralisi
@ 2024-12-03 11:20 ` tip-bot2 for Lorenzo Pieralisi
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Lorenzo Pieralisi @ 2024-12-03 11:20 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Lorenzo Pieralisi, Thomas Gleixner, x86, linux-kernel, maz

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     f58326c70df0dc413bb58848b188523b3662cf0f
Gitweb:        https://git.kernel.org/tip/f58326c70df0dc413bb58848b188523b3662cf0f
Author:        Lorenzo Pieralisi <lpieralisi@kernel.org>
AuthorDate:    Mon, 02 Dec 2024 12:25:18 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 03 Dec 2024 12:15:42 +01:00

irqchip/gic-v3: Fix irq_complete_ack() comment

When the GIC is in EOImode == 1 in irq_complete_ack() it executes a
priority drop not a deactivation.

Fix the function comment to clarify the behaviour.

Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241202112518.51178-1-lpieralisi@kernel.org
---
 drivers/irqchip/irq-gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 8b6159f..34db379 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -817,7 +817,7 @@ static void gic_deactivate_unhandled(u32 irqnr)
  *     register state is not stale, as these may have been indirectly written
  *     *after* exception entry.
  *
- * (2) Deactivate the interrupt when EOI mode 1 is in use.
+ * (2) Execute an interrupt priority drop when EOI mode 1 is in use.
  */
 static inline void gic_complete_ack(u32 irqnr)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-12-03 11:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-02 11:25 [PATCH] irqchip/gic-v3: Fix irq_complete_ack() comment Lorenzo Pieralisi
2024-12-03 11:20 ` [tip: irq/urgent] " tip-bot2 for Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®