* [PATCH 4.19 080/138] m68k: coldfire/device.c: only build FEC when HW macros are defined
2024-12-03 14:30 [PATCH 4.19 000/138] 4.19.325-rc1 review Greg Kroah-Hartman
@ 2024-12-03 14:31 ` Greg Kroah-Hartman
2024-12-03 18:13 ` [PATCH 4.19 000/138] 4.19.325-rc1 review Pavel Machek
` (4 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-03 14:31 UTC (permalink / raw)
To: stable, Greg Ungerer, Geert Uytterhoeven
Cc: Greg Kroah-Hartman, patches, linux-m68k, linux-kernel,
Antonio Quartulli, Greg Ungerer, Sasha Levin
4.19-stable review patch. If anyone has any objections, please let me know.
------------------
From: Antonio Quartulli <antonio@mandelbit.com>
[ Upstream commit 63a24cf8cc330e5a68ebd2e20ae200096974c475 ]
When CONFIG_FEC is set (due to COMPILE_TEST) along with
CONFIG_M54xx, coldfire/device.c has compile errors due to
missing MCFEC_* and MCF_IRQ_FEC_* symbols.
Make the whole FEC blocks dependent on having the HW macros
defined, rather than on CONFIG_FEC itself.
This fix is very similar to commit e6e1e7b19fa1 ("m68k: coldfire/device.c: only build for MCF_EDMA when h/w macros are defined")
Fixes: b7ce7f0d0efc ("m68knommu: merge common ColdFire FEC platform setup code")
To: Greg Ungerer <gerg@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
Signed-off-by: Greg Ungerer <gerg@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/m68k/coldfire/device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/m68k/coldfire/device.c b/arch/m68k/coldfire/device.c
index 908d58347790d..b900931669adc 100644
--- a/arch/m68k/coldfire/device.c
+++ b/arch/m68k/coldfire/device.c
@@ -89,7 +89,7 @@ static struct platform_device mcf_uart = {
.dev.platform_data = mcf_uart_platform_data,
};
-#if IS_ENABLED(CONFIG_FEC)
+#ifdef MCFFEC_BASE0
#ifdef CONFIG_M5441x
#define FEC_NAME "enet-fec"
@@ -141,6 +141,7 @@ static struct platform_device mcf_fec0 = {
.platform_data = FEC_PDATA,
}
};
+#endif /* MCFFEC_BASE0 */
#ifdef MCFFEC_BASE1
static struct resource mcf_fec1_resources[] = {
@@ -178,7 +179,6 @@ static struct platform_device mcf_fec1 = {
}
};
#endif /* MCFFEC_BASE1 */
-#endif /* CONFIG_FEC */
#if IS_ENABLED(CONFIG_SPI_COLDFIRE_QSPI)
/*
@@ -478,12 +478,12 @@ static struct platform_device mcf_i2c5 = {
static struct platform_device *mcf_devices[] __initdata = {
&mcf_uart,
-#if IS_ENABLED(CONFIG_FEC)
+#ifdef MCFFEC_BASE0
&mcf_fec0,
+#endif
#ifdef MCFFEC_BASE1
&mcf_fec1,
#endif
-#endif
#if IS_ENABLED(CONFIG_SPI_COLDFIRE_QSPI)
&mcf_qspi,
#endif
--
2.43.0
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-03 14:30 [PATCH 4.19 000/138] 4.19.325-rc1 review Greg Kroah-Hartman
2024-12-03 14:31 ` [PATCH 4.19 080/138] m68k: coldfire/device.c: only build FEC when HW macros are defined Greg Kroah-Hartman
@ 2024-12-03 18:13 ` Pavel Machek
2024-12-04 9:48 ` Greg Kroah-Hartman
2024-12-04 13:54 ` Naresh Kamboju
` (3 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Pavel Machek @ 2024-12-03 18:13 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]
Hi!
> ------------------
> Note, this is the LAST 4.19.y kernel to be released. After this one, it
> is end-of-life. It's been 6 years, everyone should have moved off of it
> by now.
> ------------------
Releasing 130 patches as end-of-life kernel is not good idea. There
may be regression hiding between them...
> This is the start of the stable review cycle for the 4.19.325 release.
> There are 138 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
Build fails:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/8532423815
CC drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.o
3895
CC drivers/pci/of.o
3896
drivers/rtc/rtc-st-lpc.c: In function 'st_rtc_probe':
3897
drivers/rtc/rtc-st-lpc.c:233:11: error: 'IRQF_NO_AUTOEN' undeclared (first use in this function); did you mean 'IRQ_NOAUTOEN'?
3898
IRQF_NO_AUTOEN, pdev->name, rtc);
3899
^~~~~~~~~~~~~~
3900
IRQ_NOAUTOEN
3901
drivers/rtc/rtc-st-lpc.c:233:11: note: each undeclared identifier is reported only once for each function it appears in
3902
CC drivers/pci/quirks.o
3903
make[2]: *** [scripts/Makefile.build:303: drivers/rtc/rtc-st-lpc.o] Error 1
3904
make[1]: *** [scripts/Makefile.build:544: drivers/rtc] Error 2
3905
make[1]: *** Waiting for unfinished jobs....
3906
CC drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.o
3907
CC drivers/soc/renesas/r8a7743-sysc.o
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-03 18:13 ` [PATCH 4.19 000/138] 4.19.325-rc1 review Pavel Machek
@ 2024-12-04 9:48 ` Greg Kroah-Hartman
2024-12-04 11:34 ` Pavel Machek
0 siblings, 1 reply; 15+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-04 9:48 UTC (permalink / raw)
To: Pavel Machek
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, jonathanh, f.fainelli, sudipm.mukherjee,
srw, rwarsow, conor, hargar, broonie
On Tue, Dec 03, 2024 at 07:13:50PM +0100, Pavel Machek wrote:
> Hi!
>
> > ------------------
> > Note, this is the LAST 4.19.y kernel to be released. After this one, it
> > is end-of-life. It's been 6 years, everyone should have moved off of it
> > by now.
> > ------------------
>
> Releasing 130 patches as end-of-life kernel is not good idea. There
> may be regression hiding between them...
It is better to have a regression for a fix then ignoring known fixes
every time. You seriously would want the final 4.19.y release to be
missing 100+ known fixes? That's just not ok for anyone who is waiting
until the last week of this kernel to change (and I know many are, which
is odd...)
> > This is the start of the stable review cycle for the 4.19.325 release.
> > There are 138 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
>
> Build fails:
>
> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/8532423815
>
> CC drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.o
> 3895
> CC drivers/pci/of.o
> 3896
> drivers/rtc/rtc-st-lpc.c: In function 'st_rtc_probe':
> 3897
> drivers/rtc/rtc-st-lpc.c:233:11: error: 'IRQF_NO_AUTOEN' undeclared (first use in this function); did you mean 'IRQ_NOAUTOEN'?
> 3898
> IRQF_NO_AUTOEN, pdev->name, rtc);
> 3899
> ^~~~~~~~~~~~~~
> 3900
> IRQ_NOAUTOEN
> 3901
> drivers/rtc/rtc-st-lpc.c:233:11: note: each undeclared identifier is reported only once for each function it appears in
> 3902
> CC drivers/pci/quirks.o
> 3903
> make[2]: *** [scripts/Makefile.build:303: drivers/rtc/rtc-st-lpc.o] Error 1
> 3904
> make[1]: *** [scripts/Makefile.build:544: drivers/rtc] Error 2
> 3905
> make[1]: *** Waiting for unfinished jobs....
> 3906
> CC drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.o
> 3907
> CC drivers/soc/renesas/r8a7743-sysc.o
What arch is this? And can you not wrap error logs like this please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-04 9:48 ` Greg Kroah-Hartman
@ 2024-12-04 11:34 ` Pavel Machek
2024-12-05 9:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 15+ messages in thread
From: Pavel Machek @ 2024-12-04 11:34 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Pavel Machek, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]
Hi!
> > > This is the start of the stable review cycle for the 4.19.325 release.
> > > There are 138 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> >
> > Build fails:
> >
> > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/8532423815
> >
> > CC drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.o
> > 3895
> > CC drivers/pci/of.o
> > 3896
> > drivers/rtc/rtc-st-lpc.c: In function 'st_rtc_probe':
> > 3897
> > drivers/rtc/rtc-st-lpc.c:233:11: error: 'IRQF_NO_AUTOEN' undeclared (first use in this function); did you mean 'IRQ_NOAUTOEN'?
> > 3898
> > IRQF_NO_AUTOEN, pdev->name, rtc);
> > 3899
> > ^~~~~~~~~~~~~~
> > 3900
> > IRQ_NOAUTOEN
> > 3901
> > drivers/rtc/rtc-st-lpc.c:233:11: note: each undeclared identifier is reported only once for each function it appears in
> > 3902
> > CC drivers/pci/quirks.o
> > 3903
> > make[2]: *** [scripts/Makefile.build:303: drivers/rtc/rtc-st-lpc.o] Error 1
> > 3904
> > make[1]: *** [scripts/Makefile.build:544: drivers/rtc] Error 2
> > 3905
> > make[1]: *** Waiting for unfinished jobs....
> > 3906
> > CC drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.o
> > 3907
> > CC drivers/soc/renesas/r8a7743-sysc.o
>
> What arch is this? And can you not wrap error logs like this please?
Not easily. But you can easily get nicely formatted logs +
architecture details by clicking the hyperlink above.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-04 11:34 ` Pavel Machek
@ 2024-12-05 9:36 ` Greg Kroah-Hartman
0 siblings, 0 replies; 15+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-05 9:36 UTC (permalink / raw)
To: Pavel Machek
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, jonathanh, f.fainelli, sudipm.mukherjee,
srw, rwarsow, conor, hargar, broonie
On Wed, Dec 04, 2024 at 12:34:02PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > This is the start of the stable review cycle for the 4.19.325 release.
> > > > There are 138 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > >
> > > Build fails:
> > >
> > > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/8532423815
> > >
> > > CC drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.o
> > > 3895
> > > CC drivers/pci/of.o
> > > 3896
> > > drivers/rtc/rtc-st-lpc.c: In function 'st_rtc_probe':
> > > 3897
> > > drivers/rtc/rtc-st-lpc.c:233:11: error: 'IRQF_NO_AUTOEN' undeclared (first use in this function); did you mean 'IRQ_NOAUTOEN'?
> > > 3898
> > > IRQF_NO_AUTOEN, pdev->name, rtc);
> > > 3899
> > > ^~~~~~~~~~~~~~
> > > 3900
> > > IRQ_NOAUTOEN
> > > 3901
> > > drivers/rtc/rtc-st-lpc.c:233:11: note: each undeclared identifier is reported only once for each function it appears in
> > > 3902
> > > CC drivers/pci/quirks.o
> > > 3903
> > > make[2]: *** [scripts/Makefile.build:303: drivers/rtc/rtc-st-lpc.o] Error 1
> > > 3904
> > > make[1]: *** [scripts/Makefile.build:544: drivers/rtc] Error 2
> > > 3905
> > > make[1]: *** Waiting for unfinished jobs....
> > > 3906
> > > CC drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.o
> > > 3907
> > > CC drivers/soc/renesas/r8a7743-sysc.o
> >
> > What arch is this? And can you not wrap error logs like this please?
>
> Not easily. But you can easily get nicely formatted logs +
> architecture details by clicking the hyperlink above.
Sometimes we don't have web access, only email access. Putting all of
the relevant information in the report is best please, if you wish for
anyone to pay attention to it (i.e. don't make me do extra work for your
test systems...)
I found the offending commit, I think. Funnily it used IRQ_NOAUTOEN
which is also in other files in 4.19.y yet never defined, so our test
coverage isn't all that good these days. All the more reason this
kernel needs to be marked end-of-life and never used again.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-03 14:30 [PATCH 4.19 000/138] 4.19.325-rc1 review Greg Kroah-Hartman
2024-12-03 14:31 ` [PATCH 4.19 080/138] m68k: coldfire/device.c: only build FEC when HW macros are defined Greg Kroah-Hartman
2024-12-03 18:13 ` [PATCH 4.19 000/138] 4.19.325-rc1 review Pavel Machek
@ 2024-12-04 13:54 ` Naresh Kamboju
2024-12-04 15:32 ` Naresh Kamboju
2024-12-04 14:28 ` Harshit Mogalapalli
` (2 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Naresh Kamboju @ 2024-12-04 13:54 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
Dan Carpenter, Anders Roxell, Arnd Bergmann, Matthias Schiffer,
Thomas Zimmermann, Daniel Vetter, noralf, Sam Ravnborg, simona,
dri-devel
On Tue, 3 Dec 2024 at 20:04, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> ------------------
> Note, this is the LAST 4.19.y kernel to be released. After this one, it
> is end-of-life. It's been 6 years, everyone should have moved off of it
> by now.
> ------------------
>
> This is the start of the stable review cycle for the 4.19.325 release.
> There are 138 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro’s test farm.
Regressions on arm.
The arm builds failed with gcc-12 and clang-19 due to following
build warnings / errors.
Build log:
---------
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:177:9: error:
'DRM_GEM_CMA_DRIVER_OPS' undeclared here (not in a function)
177 | DRM_GEM_CMA_DRIVER_OPS,
| ^~~~~~~~~~~~~~~~~~~~~~
make[5]: *** [scripts/Makefile.build:303:
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.o] Error 1
Build link:
---------
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2piB6D5prhWVm3slYYXWoIGa8Rl/
- https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19.324-139-g1efbea5bef00/testrun/26176978/suite/build/test/gcc-12-defconfig/log
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
## Build
* kernel: 4.19.325-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 1efbea5bef007cc0efd372763792996843054d7c
* git describe: v4.19.324-139-g1efbea5bef00
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19.324-139-g1efbea5bef00
## Test Regressions (compared to v4.19.323-53-g3b4d1c2cc314)
* arm, build
- clang-19-defconfig
- clang-19-imx_v6_v7_defconfig
- clang-19-omap2plus_defconfig
- gcc-12-defconfig
- gcc-12-imx_v6_v7_defconfig
- gcc-12-lkftconfig
- gcc-12-lkftconfig-debug
- gcc-12-lkftconfig-kasan
- gcc-12-lkftconfig-kunit
- gcc-12-lkftconfig-libgpiod
- gcc-12-lkftconfig-rcutorture
- gcc-12-omap2plus_defconfig
- gcc-8-defconfig
- gcc-8-imx_v6_v7_defconfig
- gcc-8-omap2plus_defconfig
## Metric Regressions (compared to v4.19.323-53-g3b4d1c2cc314)
## Test Fixes (compared to v4.19.323-53-g3b4d1c2cc314)
## Metric Fixes (compared to v4.19.323-53-g3b4d1c2cc314)
## Test result summary
total: 27904, pass: 22045, fail: 211, skip: 5623, xfail: 25
## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 101 total, 80 passed, 21 failed
* arm64: 26 total, 21 passed, 5 failed
* i386: 14 total, 11 passed, 3 failed
* mips: 20 total, 20 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 21 total, 21 passed, 0 failed
* s390: 6 total, 6 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 22 total, 16 passed, 6 failed
## Test suites summary
* boot
* kunit
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-04 13:54 ` Naresh Kamboju
@ 2024-12-04 15:32 ` Naresh Kamboju
2024-12-05 9:33 ` Greg Kroah-Hartman
0 siblings, 1 reply; 15+ messages in thread
From: Naresh Kamboju @ 2024-12-04 15:32 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
Dan Carpenter, Anders Roxell, Arnd Bergmann, Matthias Schiffer,
Thomas Zimmermann, Daniel Vetter, noralf, Sam Ravnborg, simona,
dri-devel
On Wed, 4 Dec 2024 at 19:24, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Tue, 3 Dec 2024 at 20:04, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > ------------------
> > Note, this is the LAST 4.19.y kernel to be released. After this one, it
> > is end-of-life. It's been 6 years, everyone should have moved off of it
> > by now.
> > ------------------
> >
> > This is the start of the stable review cycle for the 4.19.325 release.
> > There are 138 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Results from Linaro’s test farm.
> Regressions on arm.
>
> The arm builds failed with gcc-12 and clang-19 due to following
> build warnings / errors.
>
> Build log:
> ---------
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:177:9: error:
> 'DRM_GEM_CMA_DRIVER_OPS' undeclared here (not in a function)
> 177 | DRM_GEM_CMA_DRIVER_OPS,
> | ^~~~~~~~~~~~~~~~~~~~~~
> make[5]: *** [scripts/Makefile.build:303:
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.o] Error 1
>
Anders bisected this down to,
# first bad commit:
[5a8529fd9205b37df58a4fd756498407d956b385]
drm/fsl-dcu: Use GEM CMA object functions
- Naresh
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-04 15:32 ` Naresh Kamboju
@ 2024-12-05 9:33 ` Greg Kroah-Hartman
0 siblings, 0 replies; 15+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-05 9:33 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
Dan Carpenter, Anders Roxell, Arnd Bergmann, Matthias Schiffer,
Thomas Zimmermann, Daniel Vetter, noralf, Sam Ravnborg, simona,
dri-devel
On Wed, Dec 04, 2024 at 09:02:47PM +0530, Naresh Kamboju wrote:
> On Wed, 4 Dec 2024 at 19:24, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > On Tue, 3 Dec 2024 at 20:04, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > ------------------
> > > Note, this is the LAST 4.19.y kernel to be released. After this one, it
> > > is end-of-life. It's been 6 years, everyone should have moved off of it
> > > by now.
> > > ------------------
> > >
> > > This is the start of the stable review cycle for the 4.19.325 release.
> > > There are 138 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Results from Linaro’s test farm.
> > Regressions on arm.
> >
> > The arm builds failed with gcc-12 and clang-19 due to following
> > build warnings / errors.
> >
> > Build log:
> > ---------
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:177:9: error:
> > 'DRM_GEM_CMA_DRIVER_OPS' undeclared here (not in a function)
> > 177 | DRM_GEM_CMA_DRIVER_OPS,
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > make[5]: *** [scripts/Makefile.build:303:
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.o] Error 1
> >
>
> Anders bisected this down to,
>
> # first bad commit:
> [5a8529fd9205b37df58a4fd756498407d956b385]
> drm/fsl-dcu: Use GEM CMA object functions
Thanks, now dropped.
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-03 14:30 [PATCH 4.19 000/138] 4.19.325-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2024-12-04 13:54 ` Naresh Kamboju
@ 2024-12-04 14:28 ` Harshit Mogalapalli
2024-12-04 16:56 ` Shuah Khan
2024-12-05 14:38 ` Jon Hunter
5 siblings, 0 replies; 15+ messages in thread
From: Harshit Mogalapalli @ 2024-12-04 14:28 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie, Vegard Nossum, Darren Kenny
Hi Greg,
On 03/12/24 20:00, Greg Kroah-Hartman wrote:
> ------------------
> Note, this is the LAST 4.19.y kernel to be released. After this one, it
> is end-of-life. It's been 6 years, everyone should have moved off of it
> by now.
> ------------------
>
> This is the start of the stable review cycle for the 4.19.325 release.
> There are 138 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
No problems seen on x86_64 with our testing.
Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thanks,
Harshit
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-03 14:30 [PATCH 4.19 000/138] 4.19.325-rc1 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2024-12-04 14:28 ` Harshit Mogalapalli
@ 2024-12-04 16:56 ` Shuah Khan
2024-12-05 14:38 ` Jon Hunter
5 siblings, 0 replies; 15+ messages in thread
From: Shuah Khan @ 2024-12-04 16:56 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie, Shuah Khan
On 12/3/24 07:30, Greg Kroah-Hartman wrote:
> ------------------
> Note, this is the LAST 4.19.y kernel to be released. After this one, it
> is end-of-life. It's been 6 years, everyone should have moved off of it
> by now.
> ------------------
>
> This is the start of the stable review cycle for the 4.19.325 release.
> There are 138 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-03 14:30 [PATCH 4.19 000/138] 4.19.325-rc1 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2024-12-04 16:56 ` Shuah Khan
@ 2024-12-05 14:38 ` Jon Hunter
2024-12-05 14:40 ` Jon Hunter
5 siblings, 1 reply; 15+ messages in thread
From: Jon Hunter @ 2024-12-05 14:38 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
linux-tegra, stable
On Tue, 03 Dec 2024 15:30:29 +0100, Greg Kroah-Hartman wrote:
> ------------------
> Note, this is the LAST 4.19.y kernel to be released. After this one, it
> is end-of-life. It's been 6 years, everyone should have moved off of it
> by now.
> ------------------
>
> This is the start of the stable review cycle for the 4.19.325 release.
> There are 138 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Failures detected for Tegra ...
Test results for stable-v4.19:
10 builds: 6 pass, 4 fail
12 boots: 12 pass, 0 fail
21 tests: 21 pass, 0 fail
Linux version: 4.19.325-rc1-g1efbea5bef00
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04
Builds failed: aarch64+defconfig+jetson, arm+multi_v7
Jon
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-05 14:38 ` Jon Hunter
@ 2024-12-05 14:40 ` Jon Hunter
2024-12-06 6:07 ` Greg Kroah-Hartman
0 siblings, 1 reply; 15+ messages in thread
From: Jon Hunter @ 2024-12-05 14:40 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, f.fainelli, sudipm.mukherjee, srw, rwarsow,
conor, hargar, broonie, linux-tegra, stable
On 05/12/2024 14:38, Jon Hunter wrote:
> On Tue, 03 Dec 2024 15:30:29 +0100, Greg Kroah-Hartman wrote:
>> ------------------
>> Note, this is the LAST 4.19.y kernel to be released. After this one, it
>> is end-of-life. It's been 6 years, everyone should have moved off of it
>> by now.
>> ------------------
>>
>> This is the start of the stable review cycle for the 4.19.325 release.
>> There are 138 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> Failures detected for Tegra ...
>
> Test results for stable-v4.19:
> 10 builds: 6 pass, 4 fail
> 12 boots: 12 pass, 0 fail
> 21 tests: 21 pass, 0 fail
>
> Linux version: 4.19.325-rc1-g1efbea5bef00
> Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
> tegra194-p2972-0000, tegra20-ventana,
> tegra210-p2371-2180, tegra30-cardhu-a04
>
> Builds failed: aarch64+defconfig+jetson, arm+multi_v7
This is the same build failure as reported here:
https://lore.kernel.org/stable/Z09KXnGlTJZBpA90@duo.ucw.cz/
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-05 14:40 ` Jon Hunter
@ 2024-12-06 6:07 ` Greg Kroah-Hartman
2024-12-06 10:39 ` Jon Hunter
0 siblings, 1 reply; 15+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-06 6:07 UTC (permalink / raw)
To: Jon Hunter
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, f.fainelli, sudipm.mukherjee, srw, rwarsow,
conor, hargar, broonie, linux-tegra, stable
On Thu, Dec 05, 2024 at 02:40:28PM +0000, Jon Hunter wrote:
>
> On 05/12/2024 14:38, Jon Hunter wrote:
> > On Tue, 03 Dec 2024 15:30:29 +0100, Greg Kroah-Hartman wrote:
> > > ------------------
> > > Note, this is the LAST 4.19.y kernel to be released. After this one, it
> > > is end-of-life. It's been 6 years, everyone should have moved off of it
> > > by now.
> > > ------------------
> > >
> > > This is the start of the stable review cycle for the 4.19.325 release.
> > > There are 138 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Failures detected for Tegra ...
> >
> > Test results for stable-v4.19:
> > 10 builds: 6 pass, 4 fail
> > 12 boots: 12 pass, 0 fail
> > 21 tests: 21 pass, 0 fail
> >
> > Linux version: 4.19.325-rc1-g1efbea5bef00
> > Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
> > tegra194-p2972-0000, tegra20-ventana,
> > tegra210-p2371-2180, tegra30-cardhu-a04
> >
> > Builds failed: aarch64+defconfig+jetson, arm+multi_v7
>
>
> This is the same build failure as reported here:
>
> https://lore.kernel.org/stable/Z09KXnGlTJZBpA90@duo.ucw.cz/
Great, hopefully I fixed that up in the real release :)
thanks for testing this kernel all these years!
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4.19 000/138] 4.19.325-rc1 review
2024-12-06 6:07 ` Greg Kroah-Hartman
@ 2024-12-06 10:39 ` Jon Hunter
0 siblings, 0 replies; 15+ messages in thread
From: Jon Hunter @ 2024-12-06 10:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, f.fainelli, sudipm.mukherjee, srw, rwarsow,
conor, hargar, broonie, linux-tegra, stable
On 06/12/2024 06:07, Greg Kroah-Hartman wrote:
> On Thu, Dec 05, 2024 at 02:40:28PM +0000, Jon Hunter wrote:
>>
>> On 05/12/2024 14:38, Jon Hunter wrote:
>>> On Tue, 03 Dec 2024 15:30:29 +0100, Greg Kroah-Hartman wrote:
>>>> ------------------
>>>> Note, this is the LAST 4.19.y kernel to be released. After this one, it
>>>> is end-of-life. It's been 6 years, everyone should have moved off of it
>>>> by now.
>>>> ------------------
>>>>
>>>> This is the start of the stable review cycle for the 4.19.325 release.
>>>> There are 138 patches in this series, all will be posted as a response
>>>> to this one. If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Thu, 05 Dec 2024 14:18:57 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>> The whole patch series can be found in one patch at:
>>>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.325-rc1.gz
>>>> or in the git tree and branch at:
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>>> and the diffstat can be found below.
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>
>>> Failures detected for Tegra ...
>>>
>>> Test results for stable-v4.19:
>>> 10 builds: 6 pass, 4 fail
>>> 12 boots: 12 pass, 0 fail
>>> 21 tests: 21 pass, 0 fail
>>>
>>> Linux version: 4.19.325-rc1-g1efbea5bef00
>>> Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
>>> tegra194-p2972-0000, tegra20-ventana,
>>> tegra210-p2371-2180, tegra30-cardhu-a04
>>>
>>> Builds failed: aarch64+defconfig+jetson, arm+multi_v7
>>
>>
>> This is the same build failure as reported here:
>>
>> https://lore.kernel.org/stable/Z09KXnGlTJZBpA90@duo.ucw.cz/
>
> Great, hopefully I fixed that up in the real release :)
>
> thanks for testing this kernel all these years!
Yes all looking good now! Thanks for maintaining it, I am sure we are
both happy to have one less kernel!
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 15+ messages in thread