From: Zijun Hu <zijun_hu@icloud.com>
To: Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Stephen Boyd <stephen.boyd@linaro.org>,
Maxime Ripard <mripard@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Grant Likely <grant.likely@secretlab.ca>
Cc: Zijun Hu <zijun_hu@icloud.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>,
stable@vger.kernel.org
Subject: [PATCH 01/10] of: Fix alias name length calculating error in API of_find_node_opts_by_path()
Date: Fri, 06 Dec 2024 08:52:27 +0800 [thread overview]
Message-ID: <20241206-of_core_fix-v1-1-dc28ed56bec3@quicinc.com> (raw)
In-Reply-To: <20241206-of_core_fix-v1-0-dc28ed56bec3@quicinc.com>
From: Zijun Hu <quic_zijuhu@quicinc.com>
Alias name length calculated by of_find_node_opts_by_path() is wrong as
explained below:
Take "alias/serial@llc500:115200n8" as its @patch argument for an example
^ ^ ^
0 5 19
The right length of alias 'alias' is 5, but the API results in 19 which is
obvious wrong.
The wrong length will cause finding device node failure for such paths.
Fix by using index of either '/' or ':' as the length who comes earlier.
Fixes: 106937e8ccdc ("of: fix handling of '/' in options for of_find_node_by_path()")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/of/base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 7dc394255a0a14cd1aed02ec79c2f787a222b44c..9a9313183d1f1b61918fe7e6fa80c2726b099a1c 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -893,10 +893,10 @@ struct device_node *of_find_node_opts_by_path(const char *path, const char **opt
/* The path could begin with an alias */
if (*path != '/') {
int len;
- const char *p = separator;
+ const char *p = strchrnul(path, '/');
- if (!p)
- p = strchrnul(path, '/');
+ if (separator && separator < p)
+ p = separator;
len = p - path;
/* of_aliases must not be NULL */
--
2.34.1
next prev parent reply other threads:[~2024-12-06 0:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 0:52 [PATCH 00/10] of: fix bugs and improve codes Zijun Hu
2024-12-06 0:52 ` Zijun Hu [this message]
2024-12-09 13:24 ` [PATCH 01/10] of: Fix alias name length calculating error in API of_find_node_opts_by_path() Rob Herring
2024-12-09 13:31 ` Zijun Hu
2024-12-06 0:52 ` [PATCH 02/10] of: Correct return value for API of_parse_phandle_with_args_map() Zijun Hu
2024-12-09 13:26 ` Rob Herring
2024-12-06 0:52 ` [PATCH 03/10] of: Correct child specifier used as input of the 2nd nexus node Zijun Hu
2024-12-06 0:52 ` [PATCH 04/10] of: Fix refcount leakage for OF node returned by __of_get_dma_parent() Zijun Hu
2024-12-09 20:32 ` Rob Herring
2024-12-06 0:52 ` [PATCH 05/10] of: Fix available buffer size calculating error in API of_device_uevent_modalias() Zijun Hu
2024-12-09 20:34 ` Rob Herring
2024-12-10 12:39 ` Zijun Hu
2024-12-10 14:10 ` Rob Herring
2024-12-11 11:44 ` Zijun Hu
2024-12-06 0:52 ` [PATCH 06/10] of/fdt: Dump __be32 array in CPU type order in of_dump_addr() Zijun Hu
2024-12-09 20:37 ` Rob Herring
2024-12-06 0:52 ` [PATCH 07/10] of: Correct comments for of_alias_scan() Zijun Hu
2024-12-09 13:20 ` Rob Herring
2024-12-09 13:41 ` Zijun Hu
2024-12-06 0:52 ` [PATCH 08/10] of: Swap implementation between of_property_present() and of_property_read_bool() Zijun Hu
2024-12-06 0:52 ` [PATCH 09/10] of: property: Implement of_fwnode_property_present() by of_property_present() Zijun Hu
2024-12-09 16:48 ` Rob Herring
2024-12-10 12:44 ` Zijun Hu
2024-12-10 13:37 ` Robin Murphy
2024-12-06 0:52 ` [PATCH 10/10] of: Simplify API of_find_node_with_property() implementation Zijun Hu
2024-12-09 20:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206-of_core_fix-v1-1-dc28ed56bec3@quicinc.com \
--to=zijun_hu@icloud.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=leif.lindholm@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=stable@vger.kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®