From: Ravi Bangoria <ravi.bangoria@amd.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <namhyung@kernel.org>
Cc: <ravi.bangoria@amd.com>, <acme@kernel.org>, <eranian@google.com>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <irogers@google.com>,
<adrian.hunter@intel.com>, <kan.liang@linux.intel.com>,
<tglx@linutronix.de>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <santosh.shukla@amd.com>,
<ananth.narayan@amd.com>, <sandipan.das@amd.com>
Subject: [PATCH v2 00/10] perf/amd/ibs: Fix sample period computations
Date: Fri, 6 Dec 2024 05:17:03 +0000 [thread overview]
Message-ID: <20241206051713.991-1-ravi.bangoria@amd.com> (raw)
IBS Fetch and IBS Op pmus have constraints on supported sample period
values. The IBS hw behavior could be undefined if they are not followed.
Currently, IBS driver does not honor them correctly and thus a malicious
event could cause issues to the system. Fortunately, the IBS hw is very
resilient so far and IBS pmus are restricted to root only, so the attack
vector is minimal. In any case, these are genuine bugs and must be fixed.
Patches are rebased to peterz/queue/perf/core (f7372965c41d).
v1: https://lore.kernel.org/r/20241007034810.754-1-ravi.bangoria@amd.com
v1->v2:
- Patch #1 to #8: No code changes. Include Acked-by from Namhyung.
- Patch #9 and #10: Add perf test to test IBS pmus with various valid
and invalid sample periods.
Ravi Bangoria (10):
perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros
perf/amd/ibs: Remove pointless sample period check
perf/amd/ibs: Fix ->config to sample period calculation for OP pmu
perf/amd/ibs: Fix perf_ibs_op.cnt_mask for CurCnt
perf/amd/ibs: Don't allow freq mode event creation through ->config
interface
perf/amd/ibs: Add pmu specific minimum period
perf/amd/ibs: Add ->check_period() callback
perf/core: Introduce pmu->adjust_period() callback
perf test: Introduce DEFINE_SUITE_EXCLUSIVE()
perf test amd ibs: Add sample period unit test
arch/x86/events/amd/ibs.c | 97 ++-
arch/x86/include/asm/perf_event.h | 1 +
include/linux/perf_event.h | 5 +
kernel/events/core.c | 12 +-
tools/perf/arch/x86/include/arch-tests.h | 1 +
tools/perf/arch/x86/tests/Build | 1 +
tools/perf/arch/x86/tests/amd-ibs-period.c | 953 +++++++++++++++++++++
tools/perf/arch/x86/tests/arch-tests.c | 2 +
tools/perf/tests/tests.h | 10 +
9 files changed, 1055 insertions(+), 27 deletions(-)
create mode 100644 tools/perf/arch/x86/tests/amd-ibs-period.c
--
2.47.0
next reply other threads:[~2024-12-06 5:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 5:17 Ravi Bangoria [this message]
2024-12-06 5:17 ` [PATCH v2 01/10] perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 02/10] perf/amd/ibs: Remove pointless sample period check Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 03/10] perf/amd/ibs: Fix ->config to sample period calculation for OP pmu Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 04/10] perf/amd/ibs: Fix perf_ibs_op.cnt_mask for CurCnt Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 05/10] perf/amd/ibs: Don't allow freq mode event creation through ->config interface Ravi Bangoria
2024-12-06 8:47 ` Ingo Molnar
2024-12-06 9:07 ` Ravi Bangoria
2024-12-06 9:22 ` Ingo Molnar
2024-12-06 9:38 ` Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 06/10] perf/amd/ibs: Add pmu specific minimum period Ravi Bangoria
2024-12-06 8:42 ` Ingo Molnar
2024-12-06 8:47 ` Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 07/10] perf/amd/ibs: Add ->check_period() callback Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 08/10] perf/core: Introduce pmu->adjust_period() callback Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 09/10] perf test: Introduce DEFINE_SUITE_EXCLUSIVE() Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 10/10] perf test amd ibs: Add sample period unit test Ravi Bangoria
2024-12-06 5:24 ` Ravi Bangoria
2024-12-06 8:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206051713.991-1-ravi.bangoria@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®