From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
acme@kernel.org, eranian@google.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
santosh.shukla@amd.com, ananth.narayan@amd.com,
sandipan.das@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v2 06/10] perf/amd/ibs: Add pmu specific minimum period
Date: Fri, 6 Dec 2024 14:17:57 +0530 [thread overview]
Message-ID: <89d37e39-a513-44d0-9e7e-d705853e6d39@amd.com> (raw)
In-Reply-To: <Z1K5D7zbwjXhZE2P@gmail.com>
On 06-Dec-24 2:12 PM, Ingo Molnar wrote:
>
> * Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>
>> 0x10 is the minimum sample period for IBS Fetch and 0x90 for IBS Op.
>> Current IBS pmu driver uses 0x10 for both the pmus, which is incorrect.
>> Fix it by adding pmu specific minimum period values in struct perf_ibs.
>>
>> Also, bail out opening a 'sample period mode' event if the user requested
>> sample period is less than pmu supported minimum value. For a 'freq mode'
>> event, start calibrating sample period from pmu specific minimum period.
>
> Could you please capitalize PMU consistently, like the rest of the code
> does, both in code comments and in changelogs?
>
> It's "PMU" and "PMUs", not "pmu" and "pmus". The only lower case use is
> when we mention 'struct pmu' - and that should be quoted.
Sure. Will fix that in next revision.
Thanks,
Ravi
next prev parent reply other threads:[~2024-12-06 8:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 5:17 [PATCH v2 00/10] perf/amd/ibs: Fix sample period computations Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 01/10] perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 02/10] perf/amd/ibs: Remove pointless sample period check Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 03/10] perf/amd/ibs: Fix ->config to sample period calculation for OP pmu Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 04/10] perf/amd/ibs: Fix perf_ibs_op.cnt_mask for CurCnt Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 05/10] perf/amd/ibs: Don't allow freq mode event creation through ->config interface Ravi Bangoria
2024-12-06 8:47 ` Ingo Molnar
2024-12-06 9:07 ` Ravi Bangoria
2024-12-06 9:22 ` Ingo Molnar
2024-12-06 9:38 ` Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 06/10] perf/amd/ibs: Add pmu specific minimum period Ravi Bangoria
2024-12-06 8:42 ` Ingo Molnar
2024-12-06 8:47 ` Ravi Bangoria [this message]
2024-12-06 5:17 ` [PATCH v2 07/10] perf/amd/ibs: Add ->check_period() callback Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 08/10] perf/core: Introduce pmu->adjust_period() callback Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 09/10] perf test: Introduce DEFINE_SUITE_EXCLUSIVE() Ravi Bangoria
2024-12-06 5:17 ` [PATCH v2 10/10] perf test amd ibs: Add sample period unit test Ravi Bangoria
2024-12-06 5:24 ` Ravi Bangoria
2024-12-06 8:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89d37e39-a513-44d0-9e7e-d705853e6d39@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®