From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: linux-ext4@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Subject: [PATCH 1/5] ext4: inline: remove extra size check when writing data
Date: Fri, 6 Dec 2024 14:28:24 -0300 [thread overview]
Message-ID: <20241206172828.3219989-2-cascardo@igalia.com> (raw)
In-Reply-To: <20241206172828.3219989-1-cascardo@igalia.com>
ext4_prepare_inline_data which is called right after the removed check has
the same check. This avoids extra calls to ext4_get_inode_loc and having to
traverse all xattrs in the inode twice for that check.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
fs/ext4/inline.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 401a224f0956..0611a050668b 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -668,9 +668,6 @@ int ext4_try_to_write_inline_data(struct address_space *mapping,
struct folio *folio;
struct ext4_iloc iloc;
- if (pos + len > ext4_get_max_inline_size(inode))
- goto convert;
-
ret = ext4_get_inode_loc(inode, &iloc);
if (ret)
return ret;
--
2.34.1
next prev parent reply other threads:[~2024-12-06 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 17:28 [PATCH 0/5] ext4: inline data cleanup Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` Thadeu Lima de Souza Cascardo [this message]
2024-12-06 17:28 ` [PATCH 2/5] ext4: inline: use cached i_inline_size instead of e_value_size Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` [PATCH 3/5] ext4: introduce wrapper to read data from inode Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` [PATCH 4/5] ext4: add a wrapper to update i_inline_off and i_inline_size Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` [PATCH 5/5] ext4: make i_inline_off point to data Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206172828.3219989-2-cascardo@igalia.com \
--to=cascardo@igalia.com \
--cc=adilger.kernel@dilger.ca \
--cc=kernel-dev@igalia.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®