mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: linux-ext4@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
	Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Subject: [PATCH 2/5] ext4: inline: use cached i_inline_size instead of e_value_size
Date: Fri,  6 Dec 2024 14:28:25 -0300	[thread overview]
Message-ID: <20241206172828.3219989-3-cascardo@igalia.com> (raw)
In-Reply-To: <20241206172828.3219989-1-cascardo@igalia.com>

i_inline_size caches the total size of the inline data, it is always
EXT4_MIN_INLINE_DATA_SIZE plus the size of the system.data xattr value.

This avoids looking up for the entry again, which allows i_inline_off to be
used to point directly to the inline data.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
 fs/ext4/inline.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 0611a050668b..b49cfcadbd36 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -80,10 +80,8 @@ static int get_max_inline_xattr_value_size(struct inode *inode,
 		((void *)entry - (void *)IFIRST(header)) - sizeof(__u32);
 
 	if (EXT4_I(inode)->i_inline_off) {
-		entry = (struct ext4_xattr_entry *)
-			((void *)raw_inode + EXT4_I(inode)->i_inline_off);
-
-		free += EXT4_XATTR_SIZE(le32_to_cpu(entry->e_value_size));
+		free += EXT4_I(inode)->i_inline_size -
+				EXT4_MIN_INLINE_DATA_SIZE;
 		goto out;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2024-12-06 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 17:28 [PATCH 0/5] ext4: inline data cleanup Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` [PATCH 1/5] ext4: inline: remove extra size check when writing data Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` Thadeu Lima de Souza Cascardo [this message]
2024-12-06 17:28 ` [PATCH 3/5] ext4: introduce wrapper to read data from inode Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` [PATCH 4/5] ext4: add a wrapper to update i_inline_off and i_inline_size Thadeu Lima de Souza Cascardo
2024-12-06 17:28 ` [PATCH 5/5] ext4: make i_inline_off point to data Thadeu Lima de Souza Cascardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241206172828.3219989-3-cascardo@igalia.com \
    --to=cascardo@igalia.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=kernel-dev@igalia.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®