From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Prashanth K <quic_prashk@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Aswath Govindraju <a-govindraju@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3-am62: Disable autosuspend during remove
Date: Wed, 11 Dec 2024 02:20:16 +0000 [thread overview]
Message-ID: <20241211021959.xoexyncdyiv7vpew@synopsys.com> (raw)
In-Reply-To: <20241209105728.3216872-1-quic_prashk@quicinc.com>
On Mon, Dec 09, 2024, Prashanth K wrote:
> Runtime PM documentation (Section 5) mentions, during remove()
> callbacks, drivers should undo the runtime PM changes done in
> probe(). Usually this means calling pm_runtime_disable(),
> pm_runtime_dont_use_autosuspend() etc. Hence add missing
> function to disable autosuspend on dwc3-am62 driver unbind.
>
> Fixes: e8784c0aec03 ("drivers: usb: dwc3: Add AM62 USB wrapper driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
> ---
> drivers/usb/dwc3/dwc3-am62.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
> index 5e3d1741701f..7d43da5f2897 100644
> --- a/drivers/usb/dwc3/dwc3-am62.c
> +++ b/drivers/usb/dwc3/dwc3-am62.c
> @@ -309,6 +309,7 @@ static void dwc3_ti_remove(struct platform_device *pdev)
>
> pm_runtime_put_sync(dev);
> pm_runtime_disable(dev);
> + pm_runtime_dont_use_autosuspend(dev);
> pm_runtime_set_suspended(dev);
> }
>
> --
> 2.25.1
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Thanks,
Thinh
prev parent reply other threads:[~2024-12-11 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 10:57 Prashanth K
2024-12-11 2:20 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211021959.xoexyncdyiv7vpew@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=a-govindraju@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_prashk@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®