* [PATCH] usb: dwc3-am62: Disable autosuspend during remove
@ 2024-12-09 10:57 Prashanth K
2024-12-11 2:20 ` Thinh Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Prashanth K @ 2024-12-09 10:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Thinh Nguyen
Cc: Aswath Govindraju, linux-kernel, linux-usb, Prashanth K, stable
Runtime PM documentation (Section 5) mentions, during remove()
callbacks, drivers should undo the runtime PM changes done in
probe(). Usually this means calling pm_runtime_disable(),
pm_runtime_dont_use_autosuspend() etc. Hence add missing
function to disable autosuspend on dwc3-am62 driver unbind.
Fixes: e8784c0aec03 ("drivers: usb: dwc3: Add AM62 USB wrapper driver")
Cc: stable@vger.kernel.org
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
---
drivers/usb/dwc3/dwc3-am62.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
index 5e3d1741701f..7d43da5f2897 100644
--- a/drivers/usb/dwc3/dwc3-am62.c
+++ b/drivers/usb/dwc3/dwc3-am62.c
@@ -309,6 +309,7 @@ static void dwc3_ti_remove(struct platform_device *pdev)
pm_runtime_put_sync(dev);
pm_runtime_disable(dev);
+ pm_runtime_dont_use_autosuspend(dev);
pm_runtime_set_suspended(dev);
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usb: dwc3-am62: Disable autosuspend during remove
2024-12-09 10:57 [PATCH] usb: dwc3-am62: Disable autosuspend during remove Prashanth K
@ 2024-12-11 2:20 ` Thinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Thinh Nguyen @ 2024-12-11 2:20 UTC (permalink / raw)
To: Prashanth K
Cc: Greg Kroah-Hartman, Thinh Nguyen, Aswath Govindraju,
linux-kernel, linux-usb, stable
On Mon, Dec 09, 2024, Prashanth K wrote:
> Runtime PM documentation (Section 5) mentions, during remove()
> callbacks, drivers should undo the runtime PM changes done in
> probe(). Usually this means calling pm_runtime_disable(),
> pm_runtime_dont_use_autosuspend() etc. Hence add missing
> function to disable autosuspend on dwc3-am62 driver unbind.
>
> Fixes: e8784c0aec03 ("drivers: usb: dwc3: Add AM62 USB wrapper driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
> ---
> drivers/usb/dwc3/dwc3-am62.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
> index 5e3d1741701f..7d43da5f2897 100644
> --- a/drivers/usb/dwc3/dwc3-am62.c
> +++ b/drivers/usb/dwc3/dwc3-am62.c
> @@ -309,6 +309,7 @@ static void dwc3_ti_remove(struct platform_device *pdev)
>
> pm_runtime_put_sync(dev);
> pm_runtime_disable(dev);
> + pm_runtime_dont_use_autosuspend(dev);
> pm_runtime_set_suspended(dev);
> }
>
> --
> 2.25.1
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Thanks,
Thinh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-11 2:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-09 10:57 [PATCH] usb: dwc3-am62: Disable autosuspend during remove Prashanth K
2024-12-11 2:20 ` Thinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®