* [PATCH] efi/esrt: remove esre_attribute::store()
@ 2024-12-11 7:05 Jiri Slaby (SUSE)
2024-12-13 7:45 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-12-11 7:05 UTC (permalink / raw)
To: ardb; +Cc: linux-efi, linux-kernel, Jiri Slaby (SUSE)
esre_attribute::store() is not needed since commit af97a77bc01c (efi:
Move some sysfs files to be read-only by root). Drop it.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org
---
drivers/firmware/efi/esrt.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index 7a81c0ce4780..4bb7b0584bc9 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -75,8 +75,6 @@ static LIST_HEAD(entry_list);
struct esre_attribute {
struct attribute attr;
ssize_t (*show)(struct esre_entry *entry, char *buf);
- ssize_t (*store)(struct esre_entry *entry,
- const char *buf, size_t count);
};
static struct esre_entry *to_entry(struct kobject *kobj)
--
2.47.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] efi/esrt: remove esre_attribute::store()
2024-12-11 7:05 [PATCH] efi/esrt: remove esre_attribute::store() Jiri Slaby (SUSE)
@ 2024-12-13 7:45 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2024-12-13 7:45 UTC (permalink / raw)
To: Jiri Slaby (SUSE); +Cc: linux-efi, linux-kernel
On Wed, 11 Dec 2024 at 08:05, Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
>
> esre_attribute::store() is not needed since commit af97a77bc01c (efi:
> Move some sysfs files to be read-only by root). Drop it.
>
> Found by https://github.com/jirislaby/clang-struct.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: linux-efi@vger.kernel.org
Queued up, thanks.
> ---
> drivers/firmware/efi/esrt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index 7a81c0ce4780..4bb7b0584bc9 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -75,8 +75,6 @@ static LIST_HEAD(entry_list);
> struct esre_attribute {
> struct attribute attr;
> ssize_t (*show)(struct esre_entry *entry, char *buf);
> - ssize_t (*store)(struct esre_entry *entry,
> - const char *buf, size_t count);
> };
>
> static struct esre_entry *to_entry(struct kobject *kobj)
> --
> 2.47.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-13 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-11 7:05 [PATCH] efi/esrt: remove esre_attribute::store() Jiri Slaby (SUSE)
2024-12-13 7:45 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®