* [PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines
@ 2024-12-11 18:16 eisantosh95
2024-12-11 18:28 ` Miguel Ojeda
0 siblings, 1 reply; 2+ messages in thread
From: eisantosh95 @ 2024-12-11 18:16 UTC (permalink / raw)
Cc: eisantosh95, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, rust-for-linux, linux-kernel
From: Santosh Mahto <eisantosh95@gmail.com>
Warning found by checkpatch.pl script.
Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
---
rust/exports.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/exports.c b/rust/exports.c
index 587f0e776aba..4b34734d77c8 100644
--- a/rust/exports.c
+++ b/rust/exports.c
@@ -13,7 +13,7 @@
#include <linux/export.h>
-#define EXPORT_SYMBOL_RUST_GPL(sym) extern int sym; EXPORT_SYMBOL_GPL(sym)
+#define EXPORT_SYMBOL_RUST_GPL(sym) EXPORT_SYMBOL_GPL(sym)
#include "exports_core_generated.h"
#include "exports_helpers_generated.h"
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines
2024-12-11 18:16 [PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines eisantosh95
@ 2024-12-11 18:28 ` Miguel Ojeda
0 siblings, 0 replies; 2+ messages in thread
From: Miguel Ojeda @ 2024-12-11 18:28 UTC (permalink / raw)
To: eisantosh95
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, rust-for-linux, linux-kernel
On Wed, Dec 11, 2024 at 7:16 PM <eisantosh95@gmail.com> wrote:
>
> From: Santosh Mahto <eisantosh95@gmail.com>
>
> Warning found by checkpatch.pl script.
Thanks for the patch!
Which warning? I guess you mean:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
But this is not a normal use of `EXPORT_SYMBOL*()`, and anyway the
patch would break the build since the name is not declared otherwise.
Did you try to build the kernel after the patch with Rust enabled?
Cheers,
Miguel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-11 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-11 18:16 [PATCH] rust: Fix EXPORT_SYMBOL_RUST_GPL macro to follow guidelines eisantosh95
2024-12-11 18:28 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®