From: Borislav Petkov <bp@alien8.de>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Michael Roth <michael.roth@amd.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Nikunj A Dadhania <nikunj@amd.com>,
Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
Subject: Re: [PATCH v6 7/8] x86/sev: Add full support for a segmented RMP table
Date: Thu, 12 Dec 2024 16:41:43 +0100 [thread overview]
Message-ID: <20241212154143.GDZ1sEN_ANTQrd1GAW@fat_crate.local> (raw)
In-Reply-To: <b1ba3ffe-4336-4901-fe35-03971ae1f82b@amd.com>
On Thu, Dec 12, 2024 at 08:46:21AM -0600, Tom Lendacky wrote:
> I find it more readable :)
I know. :)
> But, ok, I'll switch to the if statement, especially since you want the
> probed_size check moved here and that only applies to the contiguous RMP
> table.
Bah, I misread.
contiguous_rmptable_setup has:
if (!probed_rmp_size)
return false;
and the segmented:
segmented_rmptable_setup:
if (!probed_rmp_base)
return false;
Forget what I said - keep those checks in the respective functions. Sorry.
> Just matching the way it's done in the contiguous table probe, but I can
> redo.
Please.
The pattern is:
do thing
check above thing's retval
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2024-12-12 15:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 20:50 [PATCH v6 0/8] Provide support for RMPREAD and a segmented RMP Tom Lendacky
2024-12-02 20:50 ` [PATCH v6 1/8] x86/sev: Prepare for using the RMPREAD instruction to access the RMP Tom Lendacky
2024-12-03 16:01 ` Borislav Petkov
2024-12-03 16:08 ` Tom Lendacky
2024-12-03 20:56 ` Borislav Petkov
2024-12-02 20:50 ` [PATCH v6 2/8] x86/sev: Add support for the RMPREAD instruction Tom Lendacky
2024-12-02 20:50 ` [PATCH v6 3/8] x86/sev: Require the RMPREAD instruction after Zen4 Tom Lendacky
2024-12-02 20:50 ` [PATCH v6 4/8] x86/sev: Move the SNP probe routine out of the way Tom Lendacky
2024-12-02 20:50 ` [PATCH v6 5/8] x86/sev: Map only the RMP table entries instead of the full RMP range Tom Lendacky
2024-12-02 20:50 ` [PATCH v6 6/8] x86/sev: Treat the contiguous RMP table as a single RMP segment Tom Lendacky
2024-12-09 19:43 ` Borislav Petkov
2024-12-10 10:28 ` Borislav Petkov
2024-12-10 10:48 ` Borislav Petkov
2024-12-10 14:36 ` Tom Lendacky
2024-12-02 20:50 ` [PATCH v6 7/8] x86/sev: Add full support for a segmented RMP table Tom Lendacky
2024-12-12 9:11 ` Borislav Petkov
2024-12-12 14:46 ` Tom Lendacky
2024-12-12 15:41 ` Borislav Petkov [this message]
2024-12-13 14:55 ` [PATCH v6.1 " Tom Lendacky
2024-12-02 20:50 ` [PATCH v6 8/8] x86/sev/docs: Document the SNP Reverse Map Table (RMP) Tom Lendacky
2024-12-16 14:21 ` [PATCH v6 0/8] Provide support for RMPREAD and a segmented RMP Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212154143.GDZ1sEN_ANTQrd1GAW@fat_crate.local \
--to=bp@alien8.de \
--cc=Neeraj.Upadhyay@amd.com \
--cc=ashish.kalra@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®