* [PATCH] doc: power: Add missing parameter description for memory_bm_create
@ 2024-12-12 16:16 Prabhav Kumar Vaish
2024-12-18 13:57 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Prabhav Kumar Vaish @ 2024-12-12 16:16 UTC (permalink / raw)
To: rafael, pavel, len.brown; +Cc: Prabhav Kumar Vaish, linux-pm, linux-kernel
Added the parameter description for bm, gfp_mask and safe_needed
for the function memory_bm_create
Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
---
kernel/power/snapshot.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 30894d8f0a78..690dd1f467b9 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -680,6 +680,9 @@ static int create_mem_extents(struct list_head *list, gfp_t gfp_mask)
/**
* memory_bm_create - Allocate memory for a memory bitmap.
+ * @bm: Memory bitmap.
+ * @gfp_mask: GFP mask for the allocation.
+ * @safe_needed: Get pages not used before hibernation (restore only)
*/
static int memory_bm_create(struct memory_bitmap *bm, gfp_t gfp_mask,
int safe_needed)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: power: Add missing parameter description for memory_bm_create
2024-12-12 16:16 [PATCH] doc: power: Add missing parameter description for memory_bm_create Prabhav Kumar Vaish
@ 2024-12-18 13:57 ` Rafael J. Wysocki
2024-12-21 17:06 ` prabhav kumar
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2024-12-18 13:57 UTC (permalink / raw)
To: Prabhav Kumar Vaish; +Cc: rafael, pavel, len.brown, linux-pm, linux-kernel
On Thu, Dec 12, 2024 at 5:16 PM Prabhav Kumar Vaish
<pvkumar5749404@gmail.com> wrote:
>
> Added the parameter description for bm, gfp_mask and safe_needed
> for the function memory_bm_create
>
> Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
> ---
> kernel/power/snapshot.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 30894d8f0a78..690dd1f467b9 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -680,6 +680,9 @@ static int create_mem_extents(struct list_head *list, gfp_t gfp_mask)
>
> /**
> * memory_bm_create - Allocate memory for a memory bitmap.
> + * @bm: Memory bitmap.
> + * @gfp_mask: GFP mask for the allocation.
> + * @safe_needed: Get pages not used before hibernation (restore only)
This isn't exactly accurate and I'd rather drop the comment entirely.
> */
> static int memory_bm_create(struct memory_bitmap *bm, gfp_t gfp_mask,
> int safe_needed)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: power: Add missing parameter description for memory_bm_create
2024-12-18 13:57 ` Rafael J. Wysocki
@ 2024-12-21 17:06 ` prabhav kumar
0 siblings, 0 replies; 3+ messages in thread
From: prabhav kumar @ 2024-12-21 17:06 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: pavel, len.brown, linux-pm, linux-kernel
On Wed, Dec 18, 2024 at 7:28 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Thu, Dec 12, 2024 at 5:16 PM Prabhav Kumar Vaish
> <pvkumar5749404@gmail.com> wrote:
> >
> > Added the parameter description for bm, gfp_mask and safe_needed
> > for the function memory_bm_create
> >
> > Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
> > ---
> > kernel/power/snapshot.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> > index 30894d8f0a78..690dd1f467b9 100644
> > --- a/kernel/power/snapshot.c
> > +++ b/kernel/power/snapshot.c
> > @@ -680,6 +680,9 @@ static int create_mem_extents(struct list_head *list, gfp_t gfp_mask)
> >
> > /**
> > * memory_bm_create - Allocate memory for a memory bitmap.
> > + * @bm: Memory bitmap.
> > + * @gfp_mask: GFP mask for the allocation.
> > + * @safe_needed: Get pages not used before hibernation (restore only)
>
> This isn't exactly accurate and I'd rather drop the comment entirely.
>
Is it like the comment is inaccurate or the comment is not needed at
the place entirely ?
> > */
> > static int memory_bm_create(struct memory_bitmap *bm, gfp_t gfp_mask,
> > int safe_needed)
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-21 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-12 16:16 [PATCH] doc: power: Add missing parameter description for memory_bm_create Prabhav Kumar Vaish
2024-12-18 13:57 ` Rafael J. Wysocki
2024-12-21 17:06 ` prabhav kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®