mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Romanov <avromanov@salutedevices.com>
To: <neil.armstrong@linaro.org>, <clabbe@baylibre.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<khilman@baylibre.com>, <jbrunet@baylibre.com>,
	<martin.blumenstingl@googlemail.com>, <vadim.fedorenko@linux.dev>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kernel@salutedevices.com>,
	"Alexey Romanov" <avromanov@salutedevices.com>
Subject: [PATCH v11 03/22] crypto: amlogic - Remove clock input
Date: Fri, 13 Dec 2024 17:07:36 +0300	[thread overview]
Message-ID: <20241213140755.1298323-4-avromanov@salutedevices.com> (raw)
In-Reply-To: <20241213140755.1298323-1-avromanov@salutedevices.com>

Amlogic crypto IP, which uses DMA crypto engine,
doesn't take a clock input.

Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/crypto/amlogic/amlogic-gxl-core.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index d7e455f73c04..90b539401b71 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -9,7 +9,6 @@
 
 #include <crypto/engine.h>
 #include <crypto/internal/skcipher.h>
-#include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/err.h>
 #include <linux/interrupt.h>
@@ -267,19 +266,6 @@ static int meson_crypto_probe(struct platform_device *pdev)
 	if (IS_ERR(mc->base))
 		return PTR_ERR(mc->base);
 
-	mc->busclk = devm_clk_get(&pdev->dev, "blkmv");
-	if (IS_ERR(mc->busclk)) {
-		err = PTR_ERR(mc->busclk);
-		dev_err(&pdev->dev, "Cannot get core clock err=%d\n", err);
-		return err;
-	}
-
-	err = clk_prepare_enable(mc->busclk);
-	if (err != 0) {
-		dev_err(&pdev->dev, "Cannot prepare_enable busclk\n");
-		return err;
-	}
-
 	err = meson_allocate_chanlist(mc);
 	if (err)
 		goto error_flow;
@@ -304,7 +290,6 @@ static int meson_crypto_probe(struct platform_device *pdev)
 	meson_unregister_algs(mc);
 error_flow:
 	meson_free_chanlist(mc, mc->flow_cnt - 1);
-	clk_disable_unprepare(mc->busclk);
 	return err;
 }
 
@@ -319,8 +304,6 @@ static void meson_crypto_remove(struct platform_device *pdev)
 	meson_unregister_algs(mc);
 
 	meson_free_chanlist(mc, mc->flow_cnt - 1);
-
-	clk_disable_unprepare(mc->busclk);
 }
 
 static const struct meson_pdata meson_gxl_pdata = {
-- 
2.34.1


  parent reply	other threads:[~2024-12-13 14:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 14:07 [PATCH v11 00/22] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 01/22] crypto: amlogic - Don't hardcode IRQ count Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 02/22] crypto: amlogic - Add platform data Alexey Romanov
2024-12-13 14:07 ` Alexey Romanov [this message]
2024-12-13 14:07 ` [PATCH v11 04/22] crypto: amlogic - Add MMIO helpers Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 05/22] crypto: amlogic - Move get_engine_number() Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 06/22] crypto: amlogic - Drop status field from meson_flow Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 07/22] crypto: amlogic - Move algs definition and cipher API to cipher.c Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 08/22] crypto: amlogic - Cleanup defines Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 09/22] crypto: amlogic - Process more than MAXDESCS descriptors Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 10/22] crypto: amlogic - Avoid kzalloc in engine thread Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 11/22] crypto: amlogic - Introduce hasher Alexey Romanov
2024-12-21 11:37   ` Herbert Xu
2025-02-10  9:13     ` [PATCH v11 00/22] Support more Amlogic SoC families in crypto driver Alexey Romanov
2025-02-12  3:51     ` [PATCH v11 11/22] crypto: amlogic - Introduce hasher Herbert Xu
2025-01-22 12:41   ` Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 12/22] crypto: amlogic - Use fallback for 192-bit keys Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 13/22] crypto: amlogic - Add support for G12-series Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 14/22] crypto: amlogic - Add support for AXG-series Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 15/22] crypto: amlogic - Add support for A1-series Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 16/22] dt-bindings: crypto: amlogic,gxl-crypto: correct clk and interrupt lines Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 17/22] dt-bindings: crypto: amlogic,gxl-crypto: support new SoC's Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 18/22] arm64: dts: amlogic: gxl: correct crypto node definition Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 19/22] arm64: dts: amlogic: a1: add crypto node Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 20/22] arm64: dts: amlogic: s4: " Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 21/22] arm64: dts: amlogic: g12: " Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 22/22] arm64: dts: amlogic: axg: " Alexey Romanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241213140755.1298323-4-avromanov@salutedevices.com \
    --to=avromanov@salutedevices.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®