mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Alexey Romanov <avromanov@salutedevices.com>
Cc: clabbe@baylibre.com, conor+dt@kernel.org, davem@davemloft.net,
	devicetree@vger.kernel.org, jbrunet@baylibre.com,
	kernel@salutedevices.com, khilman@baylibre.com,
	krzk+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	martin.blumenstingl@googlemail.com, neil.armstrong@linaro.org,
	robh+dt@kernel.org, vadim.fedorenko@linux.dev
Subject: Re: [PATCH v11 11/22] crypto: amlogic - Introduce hasher
Date: Wed, 12 Feb 2025 11:51:13 +0800	[thread overview]
Message-ID: <Z6wasftL23_K8vA2@gondor.apana.org.au> (raw)
In-Reply-To: <Z2aokzSrAHpJE_PG@gondor.apana.org.au>

On Wed, Jan 22, 2025 at 03:41:29PM +0300, Alexey Romanov wrote:
> 
> Why? I couldn't find this explanation anywhere.

Because the digest function can be called from atomic contexts,
such as networking.

> In addition, I found an example of one of the digest functions that is sleeping [1].
> 
> Links:
> 
>   - [1] https://elixir.bootlin.com/linux/v6.12.6/source/drivers/crypto/mxs-dcp.c#L804

That driver is just broken.  If you look through the git history,
you'll find that a similar problem was fixed by replacing the
mutex with a spinlock in the cipher path.  Unfortunately the same
fix hasn't been extended to hashing in mxs-dcp.

Cheeers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  parent reply	other threads:[~2025-02-12  3:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 14:07 [PATCH v11 00/22] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 01/22] crypto: amlogic - Don't hardcode IRQ count Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 02/22] crypto: amlogic - Add platform data Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 03/22] crypto: amlogic - Remove clock input Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 04/22] crypto: amlogic - Add MMIO helpers Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 05/22] crypto: amlogic - Move get_engine_number() Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 06/22] crypto: amlogic - Drop status field from meson_flow Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 07/22] crypto: amlogic - Move algs definition and cipher API to cipher.c Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 08/22] crypto: amlogic - Cleanup defines Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 09/22] crypto: amlogic - Process more than MAXDESCS descriptors Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 10/22] crypto: amlogic - Avoid kzalloc in engine thread Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 11/22] crypto: amlogic - Introduce hasher Alexey Romanov
2024-12-21 11:37   ` Herbert Xu
2025-02-10  9:13     ` [PATCH v11 00/22] Support more Amlogic SoC families in crypto driver Alexey Romanov
2025-02-12  3:51     ` Herbert Xu [this message]
2025-01-22 12:41   ` [PATCH v11 11/22] crypto: amlogic - Introduce hasher Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 12/22] crypto: amlogic - Use fallback for 192-bit keys Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 13/22] crypto: amlogic - Add support for G12-series Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 14/22] crypto: amlogic - Add support for AXG-series Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 15/22] crypto: amlogic - Add support for A1-series Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 16/22] dt-bindings: crypto: amlogic,gxl-crypto: correct clk and interrupt lines Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 17/22] dt-bindings: crypto: amlogic,gxl-crypto: support new SoC's Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 18/22] arm64: dts: amlogic: gxl: correct crypto node definition Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 19/22] arm64: dts: amlogic: a1: add crypto node Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 20/22] arm64: dts: amlogic: s4: " Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 21/22] arm64: dts: amlogic: g12: " Alexey Romanov
2024-12-13 14:07 ` [PATCH v11 22/22] arm64: dts: amlogic: axg: " Alexey Romanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6wasftL23_K8vA2@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=avromanov@salutedevices.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®