From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,tglx@linutronix.de,bp@alien8.de,rafael@kernel.org,lenb@kernel.org,dave.jiang@intel.com,irenic.rajneesh@gmail.com,david.e.box@intel.com,Dave
Hansen <dave.hansen@linux.intel.com>,zhao1.liu@intel.com
Subject: [PATCH 08/10] x86/fpu: Move CPUID leaf definitions to common code
Date: Fri, 13 Dec 2024 12:50:37 -0800 [thread overview]
Message-ID: <20241213205037.43C57CDE@davehans-spike.ostc.intel.com> (raw)
In-Reply-To: <20241213205026.25B1D283@davehans-spike.ostc.intel.com>
From: Dave Hansen <dave.hansen@linux.intel.com>
Move the XSAVE-related CPUID leaf definitions to common code. Then,
use the new definition to remove the last magic number from the CPUID
level dependency table.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
---
b/arch/x86/include/asm/cpuid.h | 2 ++
b/arch/x86/include/asm/fpu/xstate.h | 4 ----
b/arch/x86/kernel/cpu/common.c | 2 +-
b/arch/x86/kernel/fpu/xstate.c | 1 +
4 files changed, 4 insertions(+), 5 deletions(-)
diff -puN arch/x86/include/asm/cpuid.h~xsave-leaf-checks-1 arch/x86/include/asm/cpuid.h
--- a/arch/x86/include/asm/cpuid.h~xsave-leaf-checks-1 2024-12-13 12:45:36.351203168 -0800
+++ b/arch/x86/include/asm/cpuid.h 2024-12-13 12:45:36.359203508 -0800
@@ -23,8 +23,10 @@ enum cpuid_regs_idx {
#define CPUID_MWAIT_LEAF 0x5
#define CPUID_DCA_LEAF 0x9
+#define XSTATE_CPUID 0x0d
#define CPUID_TSC_LEAF 0x15
#define CPUID_FREQ_LEAF 0x16
+#define TILE_CPUID 0x1d
#ifdef CONFIG_X86_32
bool have_cpuid_p(void);
diff -puN arch/x86/include/asm/fpu/xstate.h~xsave-leaf-checks-1 arch/x86/include/asm/fpu/xstate.h
--- a/arch/x86/include/asm/fpu/xstate.h~xsave-leaf-checks-1 2024-12-13 12:45:36.355203337 -0800
+++ b/arch/x86/include/asm/fpu/xstate.h 2024-12-13 12:45:36.359203508 -0800
@@ -12,10 +12,6 @@
/* Bit 63 of XCR0 is reserved for future expansion */
#define XFEATURE_MASK_EXTEND (~(XFEATURE_MASK_FPSSE | (1ULL << 63)))
-#define XSTATE_CPUID 0x0000000d
-
-#define TILE_CPUID 0x0000001d
-
#define FXSAVE_SIZE 512
#define XSAVE_HDR_SIZE 64
diff -puN arch/x86/kernel/cpu/common.c~xsave-leaf-checks-1 arch/x86/kernel/cpu/common.c
--- a/arch/x86/kernel/cpu/common.c~xsave-leaf-checks-1 2024-12-13 12:45:36.355203337 -0800
+++ b/arch/x86/kernel/cpu/common.c 2024-12-13 12:45:36.359203508 -0800
@@ -639,7 +639,7 @@ static const struct cpuid_dependent_feat
cpuid_dependent_features[] = {
{ X86_FEATURE_MWAIT, CPUID_MWAIT_LEAF },
{ X86_FEATURE_DCA, CPUID_DCA_LEAF },
- { X86_FEATURE_XSAVE, 0x0000000d },
+ { X86_FEATURE_XSAVE, XSTATE_CPUID },
{ 0, 0 }
};
diff -puN arch/x86/kernel/fpu/xstate.c~xsave-leaf-checks-1 arch/x86/kernel/fpu/xstate.c
--- a/arch/x86/kernel/fpu/xstate.c~xsave-leaf-checks-1 2024-12-13 12:45:36.359203508 -0800
+++ b/arch/x86/kernel/fpu/xstate.c 2024-12-13 12:45:36.359203508 -0800
@@ -20,6 +20,7 @@
#include <asm/fpu/signal.h>
#include <asm/fpu/xcr.h>
+#include <asm/cpuid.h>
#include <asm/tlbflush.h>
#include <asm/prctl.h>
#include <asm/elf.h>
_
next prev parent reply other threads:[~2024-12-13 20:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 20:50 [PATCH 00/10] [v2] x86/cpu: Centralize and standardize CPUID leaf naming Dave Hansen
2024-12-13 20:50 ` [PATCH 01/10] x86/cpu: Move MWAIT leaf definition to common header Dave Hansen
2024-12-13 20:50 ` [PATCH 02/10] x86/cpu: Use MWAIT leaf definition Dave Hansen
2024-12-13 20:50 ` [PATCH 03/10] x86/cpu: Remove unnecessary MwAIT leaf checks Dave Hansen
2024-12-13 20:50 ` [PATCH 04/10] x86/cpu: Refresh DCA leaf reading code Dave Hansen
2024-12-13 20:50 ` [PATCH 05/10] x86/cpu: Move TSC CPUID leaf definition Dave Hansen
2024-12-13 20:50 ` [PATCH 06/10] x86/tsc: Move away from TSC leaf magic numbers Dave Hansen
2024-12-13 20:50 ` [PATCH 07/10] x86/tsc: Remove CPUID "frequency" " Dave Hansen
2024-12-13 20:50 ` Dave Hansen [this message]
2024-12-13 20:50 ` [PATCH 09/10] x86/fpu: Remove unnecessary CPUID level check Dave Hansen
2024-12-16 19:05 ` Chang S. Bae
2024-12-16 21:23 ` Dave Hansen
2024-12-13 20:50 ` [PATCH 10/10] x86/cpu: Make all all CPUID leaf names consistent Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213205037.43C57CDE@davehans-spike.ostc.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.jiang@intel.com \
--cc=david.e.box@intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®