From: Dave Hansen <dave.hansen@intel.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: x86@kernel.org, tglx@linutronix.de, bp@alien8.de,
rafael@kernel.org, lenb@kernel.org, dave.jiang@intel.com,
irenic.rajneesh@gmail.com, david.e.box@intel.com
Subject: Re: [PATCH 09/10] x86/fpu: Remove unnecessary CPUID level check
Date: Mon, 16 Dec 2024 13:23:18 -0800 [thread overview]
Message-ID: <d1a133d4-ec9e-4857-ad24-cfdc7724d46f@intel.com> (raw)
In-Reply-To: <f3d50e5c-5779-4cf4-b279-31eeef2462c6@intel.com>
On 12/16/24 11:05, Chang S. Bae wrote:
...> Then, the sanity check introduced in this code path appears redundant:
>
> xsave_init()
> -> xstate_enable_boot_cpu()
> -> setup_xstate_init()
> -> setup_xstate_features()
>
> Reviewed-by: Chang S. Bae <chang.seok.bae@intel.com>
Yeah, good point. Thanks for the review!
BTW, I do still want to make this into a _generic_ warning so that all
cpuid*() users get warned if they go reading leafs that are too high.
But I'll do that in another series.
next prev parent reply other threads:[~2024-12-16 21:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 20:50 [PATCH 00/10] [v2] x86/cpu: Centralize and standardize CPUID leaf naming Dave Hansen
2024-12-13 20:50 ` [PATCH 01/10] x86/cpu: Move MWAIT leaf definition to common header Dave Hansen
2024-12-13 20:50 ` [PATCH 02/10] x86/cpu: Use MWAIT leaf definition Dave Hansen
2024-12-13 20:50 ` [PATCH 03/10] x86/cpu: Remove unnecessary MwAIT leaf checks Dave Hansen
2024-12-13 20:50 ` [PATCH 04/10] x86/cpu: Refresh DCA leaf reading code Dave Hansen
2024-12-13 20:50 ` [PATCH 05/10] x86/cpu: Move TSC CPUID leaf definition Dave Hansen
2024-12-13 20:50 ` [PATCH 06/10] x86/tsc: Move away from TSC leaf magic numbers Dave Hansen
2024-12-13 20:50 ` [PATCH 07/10] x86/tsc: Remove CPUID "frequency" " Dave Hansen
2024-12-13 20:50 ` [PATCH 08/10] x86/fpu: Move CPUID leaf definitions to common code Dave Hansen
2024-12-13 20:50 ` [PATCH 09/10] x86/fpu: Remove unnecessary CPUID level check Dave Hansen
2024-12-16 19:05 ` Chang S. Bae
2024-12-16 21:23 ` Dave Hansen [this message]
2024-12-13 20:50 ` [PATCH 10/10] x86/cpu: Make all all CPUID leaf names consistent Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1a133d4-ec9e-4857-ad24-cfdc7724d46f@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david.e.box@intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®