* [PATCH] arm64: dts: mt8186: Add mt8186-skitty @ 2024-12-16 7:35 Geoffrey Chien 2024-12-16 17:30 ` kernel test robot 2024-12-17 7:36 ` Krzysztof Kozlowski 0 siblings, 2 replies; 5+ messages in thread From: Geoffrey Chien @ 2024-12-16 7:35 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Sean Wang Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, herbert1_wu, Thomas_Hsieh, Geoffrey Chien Add Skitty initial device tree. Support second source Synaptics trackpad Support US2 keyboard. Enhance touch screen timing for ELAN Based on experiment, set drive-strength to 6mA (default = 8mA) Modify sbs battery reg to 0x0f Signed-off-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com> --- .../devicetree/bindings/arm/mediatek.yaml | 8 +++ arch/arm64/boot/dts/mediatek/Makefile | 4 ++ .../dts/mediatek/mt8186-corsola-skitty-sku1.dts | 23 +++++++ .../dts/mediatek/mt8186-corsola-skitty-sku2.dts | 13 ++++ .../dts/mediatek/mt8186-corsola-skitty-sku3.dts | 40 ++++++++++++ .../dts/mediatek/mt8186-corsola-skitty-sku4.dts | 30 +++++++++ .../boot/dts/mediatek/mt8186-corsola-skitty.dtsi | 76 ++++++++++++++++++++++ 7 files changed, 194 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 1d4bb50fcd8d9aadb7b77e144a474b79da005056..29e7555569a772ba042e29af01ea98fdd3be1525 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -224,6 +224,14 @@ properties: - google,pico-sku2 - const: google,pico - const: mediatek,mt8183 + - description: Google Skitty (HP Chromebook G1m 11 inch) + items: + - const: google,skitty-sku1 + - const: google,skitty-sku2 + - const: google,skitty-sku3 + - const: google,skitty-sku4 + - const: google,skitty + - const: mediatek,mt8186 - description: Google Willow (Acer Chromebook 311 C722/C722T) items: - enum: diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 8fd7b2bb7a1590341e7bb4ea1ecf039ae3e8eb0d..328e1ee444bd81b5a2aa3d21acb7a5c5a3318a87 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -59,6 +59,10 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-rusty-sku196608.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku1.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku2.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku3.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku4.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131072.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131073.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacool-sku327681.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts new file mode 100644 index 0000000000000000000000000000000000000000..a0e7b10445333d6f83fc4c461ce8f8d75ffaa697 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-skitty.dtsi" + +/ { + model = "Google Skitty sku1 board"; + compatible = "google,skitty-sku1", + "google,skitty", "google,corsola", "mediatek,mt8186"; +}; + +&i2c1 { + /delete-node/ touchscreen@10; + touchscreen: touchscreen@10 { + compatible = "elan,ekth3500"; + reg = <0x10>; + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>; + status = "okay"; + }; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku2.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku2.dts new file mode 100644 index 0000000000000000000000000000000000000000..c071c1b8952b50eacfc2d48dbb9450e9b358ef0e --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku2.dts @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-skitty.dtsi" + +/ { + model = "Google Skitty sku2 board"; + compatible = "google,skitty-sku2", + "google,skitty", "google,corsola", "mediatek,mt8186"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku3.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku3.dts new file mode 100644 index 0000000000000000000000000000000000000000..09b4b26aba93c0e65b5fbef6eb81edbe414daa0b --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku3.dts @@ -0,0 +1,40 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-skitty.dtsi" + +/ { + model = "Google Skitty sku3 board"; + compatible = "google,skitty-sku3", + "google,skitty", "google,corsola", "mediatek,mt8186"; +}; + +&i2c1 { + /delete-node/ touchscreen@10; + touchscreen: touchscreen@10 { + compatible = "elan,ekth3500"; + reg = <0x10>; + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>; + status = "okay"; + }; +}; + +&keyboard_controller { + linux,keymap = < + MATRIX_KEY(0x00, 0x02, KEY_BACK) + MATRIX_KEY(0x03, 0x02, KEY_REFRESH) + MATRIX_KEY(0x02, 0x02, KEY_ZOOM) + MATRIX_KEY(0x01, 0x02, KEY_SCALE) + MATRIX_KEY(0x03, 0x04, KEY_SYSRQ) + MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN) + MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP) + MATRIX_KEY(0x02, 0x09, KEY_MUTE) + MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN) + MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP) + CROS_STD_MAIN_KEYMAP + MATRIX_KEY(0x04, 0x00, KEY_102ND) + >; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku4.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku4.dts new file mode 100644 index 0000000000000000000000000000000000000000..c3e2dbd0120f32062dba6a2f6f9e8ee31db02588 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku4.dts @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-skitty.dtsi" + +/ { + model = "Google Skitty sku4 board"; + compatible = "google,skitty-sku4", + "google,skitty", "google,corsola", "mediatek,mt8186"; +}; + +&keyboard_controller { + linux,keymap = < + MATRIX_KEY(0x00, 0x02, KEY_BACK) + MATRIX_KEY(0x03, 0x02, KEY_REFRESH) + MATRIX_KEY(0x02, 0x02, KEY_ZOOM) + MATRIX_KEY(0x01, 0x02, KEY_SCALE) + MATRIX_KEY(0x03, 0x04, KEY_SYSRQ) + MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN) + MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP) + MATRIX_KEY(0x02, 0x09, KEY_MUTE) + MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN) + MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP) + CROS_STD_MAIN_KEYMAP + MATRIX_KEY(0x04, 0x00, KEY_102ND) + >; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtsi new file mode 100644 index 0000000000000000000000000000000000000000..51a05f96191b4e40ad1f77e6a8ea23c99af3b279 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtsi @@ -0,0 +1,76 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-krabby.dtsi" + +&keyboard_controller { + function-row-physmap = < + MATRIX_KEY(0x00, 0x02, 0) /* T1 */ + MATRIX_KEY(0x03, 0x02, 0) /* T2 */ + MATRIX_KEY(0x02, 0x02, 0) /* T3 */ + MATRIX_KEY(0x01, 0x02, 0) /* T4 */ + MATRIX_KEY(0x03, 0x04, 0) /* T5 */ + MATRIX_KEY(0x02, 0x04, 0) /* T6 */ + MATRIX_KEY(0x01, 0x04, 0) /* T7 */ + MATRIX_KEY(0x02, 0x09, 0) /* T8 */ + MATRIX_KEY(0x01, 0x09, 0) /* T9 */ + MATRIX_KEY(0x00, 0x04, 0) /* T10 */ + >; + + linux,keymap = < + MATRIX_KEY(0x00, 0x02, KEY_BACK) + MATRIX_KEY(0x03, 0x02, KEY_REFRESH) + MATRIX_KEY(0x02, 0x02, KEY_ZOOM) + MATRIX_KEY(0x01, 0x02, KEY_SCALE) + MATRIX_KEY(0x03, 0x04, KEY_SYSRQ) + MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN) + MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP) + MATRIX_KEY(0x02, 0x09, KEY_MUTE) + MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN) + MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP) + CROS_STD_MAIN_KEYMAP + >; +}; + +&usb_c1 { + status = "disabled"; +}; + +&target { + temperature = <76000>; +}; + +&i2c2 { + touchpad@2c { + compatible = "hid-over-i2c"; + reg = <0x2c>; + hid-descr-addr = <0x20>; + interrupts-extended = <&pio 11 IRQ_TYPE_LEVEL_LOW>; + vcc-supply = <&pp3300_s3>; + wakeup-source; + }; +}; + +&mmc1_pins_uhs { + pins-clk { + drive-strength = <MTK_DRIVE_6mA>; + }; + + pins-cmd-dat { + drive-strength = <MTK_DRIVE_6mA>; + }; +}; + +&i2c_tunnel { + /delete-node/ sbs-battery@b; + + battery: sbs-battery@f { + compatible = "sbs,sbs-battery"; + reg = <0xf>; + sbs,i2c-retry-count = <2>; + sbs,poll-retry-count = <1>; + }; +}; --- base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8 change-id: 20241216-skitty_kernel-6e330a493d51 Best regards, -- Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: mt8186: Add mt8186-skitty 2024-12-16 7:35 [PATCH] arm64: dts: mt8186: Add mt8186-skitty Geoffrey Chien @ 2024-12-16 17:30 ` kernel test robot 2024-12-17 7:36 ` Krzysztof Kozlowski 1 sibling, 0 replies; 5+ messages in thread From: kernel test robot @ 2024-12-16 17:30 UTC (permalink / raw) To: Geoffrey Chien, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Sean Wang Cc: oe-kbuild-all, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, herbert1_wu, Thomas_Hsieh, Geoffrey Chien Hi Geoffrey, kernel test robot noticed the following build errors: [auto build test ERROR on 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8] url: https://github.com/intel-lab-lkp/linux/commits/Geoffrey-Chien/arm64-dts-mt8186-Add-mt8186-skitty/20241216-153651 base: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8 patch link: https://lore.kernel.org/r/20241216-skitty_kernel-v1-1-bc75dcdfeb57%40pegatron.corp-partner.google.com patch subject: [PATCH] arm64: dts: mt8186: Add mt8186-skitty config: arm64-randconfig-003-20241216 (https://download.01.org/0day-ci/archive/20241217/202412170154.QsBtjHdl-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241217/202412170154.QsBtjHdl-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202412170154.QsBtjHdl-lkp@intel.com/ All errors (new ones prefixed by >>): >> Error: arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtsi:42.1-8 Label or path target not found FATAL ERROR: Syntax error parsing input tree -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: mt8186: Add mt8186-skitty 2024-12-16 7:35 [PATCH] arm64: dts: mt8186: Add mt8186-skitty Geoffrey Chien 2024-12-16 17:30 ` kernel test robot @ 2024-12-17 7:36 ` Krzysztof Kozlowski 1 sibling, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2024-12-17 7:36 UTC (permalink / raw) To: Geoffrey Chien Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, Sean Wang, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, herbert1_wu, Thomas_Hsieh On Mon, Dec 16, 2024 at 03:35:12PM +0800, Geoffrey Chien wrote: > Add Skitty initial device tree. > Support second source Synaptics trackpad > Support US2 keyboard. > Enhance touch screen timing for ELAN > Based on experiment, set drive-strength to 6mA (default = 8mA) > Modify sbs battery reg to 0x0f > > Signed-off-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com> > --- > .../devicetree/bindings/arm/mediatek.yaml | 8 +++ > arch/arm64/boot/dts/mediatek/Makefile | 4 ++ > .../dts/mediatek/mt8186-corsola-skitty-sku1.dts | 23 +++++++ > .../dts/mediatek/mt8186-corsola-skitty-sku2.dts | 13 ++++ > .../dts/mediatek/mt8186-corsola-skitty-sku3.dts | 40 ++++++++++++ > .../dts/mediatek/mt8186-corsola-skitty-sku4.dts | 30 +++++++++ > .../boot/dts/mediatek/mt8186-corsola-skitty.dtsi | 76 ++++++++++++++++++++++ This wasn't ever tested (as robots point out), but also: It does not look like you tested the DTS against bindings. Please run 'make dtbs_check W=1' (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema. Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > 7 files changed, 194 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 1d4bb50fcd8d9aadb7b77e144a474b79da005056..29e7555569a772ba042e29af01ea98fdd3be1525 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -224,6 +224,14 @@ properties: > - google,pico-sku2 > - const: google,pico > - const: mediatek,mt8183 > + - description: Google Skitty (HP Chromebook G1m 11 inch) > + items: > + - const: google,skitty-sku1 > + - const: google,skitty-sku2 > + - const: google,skitty-sku3 > + - const: google,skitty-sku4 > + - const: google,skitty > + - const: mediatek,mt8186 > - description: Google Willow (Acer Chromebook 311 C722/C722T) > items: > - enum: > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 8fd7b2bb7a1590341e7bb4ea1ecf039ae3e8eb0d..328e1ee444bd81b5a2aa3d21acb7a5c5a3318a87 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -59,6 +59,10 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-rusty-sku196608.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku1.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku2.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku3.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty-sku4.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131072.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131073.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacool-sku327681.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts > new file mode 100644 > index 0000000000000000000000000000000000000000..a0e7b10445333d6f83fc4c461ce8f8d75ffaa697 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty-sku1.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2024 Google LLC > + */ > + > +/dts-v1/; > +#include "mt8186-corsola-skitty.dtsi" > + > +/ { > + model = "Google Skitty sku1 board"; > + compatible = "google,skitty-sku1", > + "google,skitty", "google,corsola", "mediatek,mt8186"; Fix alignment. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: mt8186: Add mt8186-skitty @ 2024-11-21 3:26 Herbert Wu 2024-11-21 17:10 ` Rob Herring (Arm) 0 siblings, 1 reply; 5+ messages in thread From: Herbert Wu @ 2024-11-21 3:26 UTC (permalink / raw) To: linux-kernel; +Cc: geoffrey_chien, hsinyi, shawnku, Herbert Wu Add Skitty initial device tree. Signed-off-by: Herbert Wu <herbert1_wu@pegatron.corp-partner.google.com> Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org> Reviewed-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com> Reviewed-by: Shawn Ku <shawnku@chromium.org> Commit-Queue: Shawn Ku <shawnku@chromium.org> Tested-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com> --- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../boot/dts/mediatek/mt8186-corsola-skitty.dts | 12 ++++++++++++ 2 files changed, 13 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dts diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 8fd7b2bb7a15..39372a275911 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -59,6 +59,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-rusty-sku196608.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-skitty.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131072.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-steelix-sku131073.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-tentacool-sku327681.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dts new file mode 100644 index 000000000000..44cff44c12f4 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dts @@ -0,0 +1,12 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-krabby.dtsi" + +/ { + model = "Google Skitty board"; + compatible = "google,skitty", "google,corsola", "mediatek,mt8186"; +}; -- 2.34.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: mt8186: Add mt8186-skitty 2024-11-21 3:26 Herbert Wu @ 2024-11-21 17:10 ` Rob Herring (Arm) 0 siblings, 0 replies; 5+ messages in thread From: Rob Herring (Arm) @ 2024-11-21 17:10 UTC (permalink / raw) To: Herbert Wu; +Cc: linux-kernel, shawnku, geoffrey_chien, hsinyi On Thu, 21 Nov 2024 11:26:19 +0800, Herbert Wu wrote: > Add Skitty initial device tree. > > Signed-off-by: Herbert Wu <herbert1_wu@pegatron.corp-partner.google.com> > Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org> > Reviewed-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com> > Reviewed-by: Shawn Ku <shawnku@chromium.org> > Commit-Queue: Shawn Ku <shawnku@chromium.org> > Tested-by: Geoffrey Chien <geoffrey_chien@pegatron.corp-partner.google.com> > --- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../boot/dts/mediatek/mt8186-corsola-skitty.dts | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dts > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-skitty.dtb' for 20241121032619.16525-1-herbert1_wu@pegatron.corp-partner.google.com: arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed: ['google,skitty', 'google,corsola', 'mediatek,mt8186'] is too long ['google,skitty', 'google,corsola', 'mediatek,mt8186'] is too short 'google,skitty' is not one of ['mediatek,mt2701-evb'] 'google,skitty' is not one of ['mediatek,mt2712-evb'] 'google,skitty' is not one of ['mediatek,mt6580-evbp1'] 'google,skitty' is not one of ['prestigio,pmt5008-3g'] 'google,skitty' is not one of ['fairphone,fp1', 'mundoreader,bq-aquaris5'] 'google,skitty' is not one of ['mediatek,mt6592-evb'] 'google,skitty' is not one of ['mediatek,mt6755-evb'] 'google,skitty' is not one of ['mediatek,mt6765-evb'] 'google,skitty' is not one of ['mediatek,mt6779-evb'] 'google,skitty' is not one of ['mediatek,mt6795-evb', 'sony,xperia-m5'] 'google,skitty' is not one of ['archermind,mt6797-x20-dev', 'mediatek,mt6797-evb'] 'google,skitty' is not one of ['bananapi,bpi-r64', 'mediatek,mt7622-rfb1'] 'google,skitty' is not one of ['mediatek,mt7623a-rfb-emmc', 'mediatek,mt7623a-rfb-nand', 'mediatek,mt7623n-rfb-emmc', 'bananapi,bpi-r2'] 'google,skitty' is not one of ['mediatek,mt7629-rfb'] 'google,skitty' is not one of ['cudy,wr3000-v1', 'openwrt,one', 'xiaomi,ax3000t'] 'google,skitty' is not one of ['acelink,ew-7886cax', 'bananapi,bpi-r3', 'bananapi,bpi-r3mini', 'mediatek,mt7986a-rfb'] 'google,skitty' is not one of ['mediatek,mt7986b-rfb'] 'google,skitty' is not one of ['bananapi,bpi-r4'] 'google,skitty' is not one of ['mediatek,mt8127-moose'] 'google,skitty' is not one of ['mediatek,mt8135-evbp1'] 'google,skitty' is not one of ['mediatek,mt8167-pumpkin'] 'google,elm-rev8' was expected 'google,hana-rev6' was expected 'google,hana-rev7' was expected 'google,skitty' is not one of ['mediatek,mt8173-evb'] 'google,burnet' was expected 'google,cozmo' was expected 'google,damu' was expected 'google,skitty' is not one of ['google,fennel-sku0', 'google,fennel-sku1', 'google,fennel-sku2', 'google,fennel-sku6', 'google,fennel-sku7'] 'google,skitty' is not one of ['google,juniper-sku16', 'google,juniper-sku17'] 'google,kakadu-rev3' was expected 'google,kakadu-rev3-sku22' was expected 'google,kappa' was expected 'google,skitty' is not one of ['google,katsu-sku32', 'google,katsu-sku38'] 'google,skitty' is not one of ['google,kodama-sku16', 'google,kodama-sku272', 'google,kodama-sku288', 'google,kodama-sku32'] 'google,skitty' is not one of ['google,krane-sku0', 'google,krane-sku176'] 'google,skitty' is not one of ['google,makomo-sku0', 'google,makomo-sku1'] 'google,skitty' is not one of ['google,pico-sku1', 'google,pico-sku2'] 'google,skitty' is not one of ['google,willow-sku0', 'google,willow-sku1'] 'google,skitty' is not one of ['mediatek,mt8183-evb'] 'google,skitty' is not one of ['mediatek,mt8183-pumpkin'] 'google,steelix-sku393219' was expected 'google,steelix-sku393220' was expected 'google,steelix-sku393221' was expected 'google,steelix-sku196609' was expected 'google,skitty' is not one of ['google,steelix-sku131072', 'google,steelix-sku131073'] 'google,tentacruel-sku262147' was expected 'google,tentacruel-sku262151' was expected 'google,tentacruel-sku327681' was expected 'google,tentacruel-sku327683' was expected 'google,skitty' is not one of ['google,voltorb-sku589824', 'google,voltorb-sku589825'] 'google,skitty' is not one of ['mediatek,mt8186-evb'] 'google,skitty' is not one of ['mediatek,mt8188-evb'] 'google,hayato-rev1' was expected 'google,hayato-rev5-sku2' was expected 'google,spherion-rev3' was expected 'google,spherion-rev4' was expected 'google,skitty' is not one of ['mediatek,mt8192-evb'] 'google,skitty' is not one of ['google,tomato-rev2', 'google,tomato-rev1'] 'google,tomato-rev4' was expected 'google,dojo-sku7' was expected 'google,skitty' is not one of ['mediatek,mt8195-demo', 'mediatek,mt8195-evb'] 'google,skitty' is not one of ['mediatek,mt8365-evk'] 'google,skitty' is not one of ['mediatek,mt8390-evk'] 'google,skitty' is not one of ['kontron,3-5-sbc-i1200', 'mediatek,mt8395-evk', 'radxa,nio-12l'] 'google,skitty' is not one of ['mediatek,mt8516-pumpkin'] 'mediatek,mt2701' was expected 'mediatek,mt2712' was expected 'mediatek,mt6580' was expected 'mediatek,mt6582' was expected 'mediatek,mt6589' was expected 'mediatek,mt6592' was expected 'mediatek,mt6755' was expected 'mediatek,mt6765' was expected 'mediatek,mt6779' was expected 'mediatek,mt6795' was expected 'mediatek,mt6797' was expected 'mediatek,mt7622' was expected 'mediatek,mt7623' was expected 'mediatek,mt7629' was expected 'mediatek,mt7981b' was expected 'mediatek,mt7986a' was expected 'mediatek,mt7986b' was expected 'mediatek,mt7988a' was expected 'mediatek,mt8127' was expected 'mediatek,mt8135' was expected 'mediatek,mt8167' was expected 'google,elm-rev7' was expected 'google,hana-rev5' was expected 'mediatek,mt8173' was expected 'mediatek,mt8183' was expected 'google,fennel' was expected 'google,juniper' was expected 'google,kakadu-rev2' was expected 'google,kakadu-rev2-sku22' was expected 'google,katsu' was expected 'google,kodama' was expected 'google,krane' was expected 'google,makomo' was expected 'google,pico' was expected 'google,willow' was expected 'google,steelix-sku393216' was expected 'google,steelix-sku393217' was expected 'google,steelix-sku393218' was expected 'google,steelix-sku196608' was expected 'google,steelix' was expected 'google,tentacruel-sku262146' was expected 'google,tentacruel-sku262150' was expected 'google,tentacruel' was expected 'google,voltorb' was expected 'mediatek,mt8186' was expected 'mediatek,mt8188' was expected 'google,hayato' was expected 'google,hayato-sku2' was expected 'google,spherion-rev2' was expected 'google,spherion' was expected 'mediatek,mt8192' was expected 'google,tomato' was expected 'google,tomato-rev3' was expected 'google,dojo-sku5' was expected 'mediatek,mt8195' was expected 'mediatek,mt8365' was expected 'mediatek,mt8390' was expected 'mediatek,mt8395' was expected 'mediatek,mt8516' was expected 'google,elm-rev6' was expected 'google,hana-rev4' was expected 'google,kakadu' was expected 'google,tentacruel-sku262145' was expected 'google,tentacruel-sku262149' was expected 'google,spherion-rev1' was expected 'google,dojo-sku3' was expected from schema $id: http://devicetree.org/schemas/arm/mediatek.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtb: /: failed to match any schema with compatible: ['google,skitty', 'google,corsola', 'mediatek,mt8186'] arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtb: /: failed to match any schema with compatible: ['google,skitty', 'google,corsola', 'mediatek,mt8186'] arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtb: pmic: 'codec' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtb: dp-bridge@5c: 'extcon' is a required property from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml# arch/arm64/boot/dts/mediatek/mt8186-corsola-skitty.dtb: sound: 'model' is a required property from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-17 7:36 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-12-16 7:35 [PATCH] arm64: dts: mt8186: Add mt8186-skitty Geoffrey Chien 2024-12-16 17:30 ` kernel test robot 2024-12-17 7:36 ` Krzysztof Kozlowski -- strict thread matches above, loose matches on Subject: below -- 2024-11-21 3:26 Herbert Wu 2024-11-21 17:10 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®