* [PATCH linux-pm] thermal: intel: Fix compile issue when CONFIG_NET is not defined
@ 2024-12-18 21:44 Srinivas Pandruvada
2024-12-19 11:43 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Pandruvada @ 2024-12-18 21:44 UTC (permalink / raw)
To: rafael, rui.zhang, daniel.lezcano, lukasz.luba
Cc: linux-pm, linux-kernel, Srinivas Pandruvada, kernel test robot
If CONFIG_NET is not defined then THERMAL_NETLINK can't be selected.
Hence add dependency on CONFIG_NET. Othewise it will generate compile
errors while compiling thermal_netlink.c.
Fixes: 4596cbea0ed2 ("thermal: intel: Remove explicit user_space governor selection")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
This commit ID 4596cbea0ed2 is from linux-pm bleeding edge branch of
linux-pm git.
drivers/thermal/intel/Kconfig | 1 +
drivers/thermal/intel/int340x_thermal/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
index 9c0f66f9defc..e1973c0efe0c 100644
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -22,6 +22,7 @@ config INTEL_TCC
config X86_PKG_TEMP_THERMAL
tristate "X86 package temperature thermal driver"
depends on X86_THERMAL_VECTOR
+ depends on NET
select THERMAL_NETLINK
select INTEL_TCC
default m
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index d9a74424c29d..6a0203eaa7f2 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -6,6 +6,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
depends on X86_64 && ACPI && PCI
+ depends on NET
select THERMAL_NETLINK
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.47.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH linux-pm] thermal: intel: Fix compile issue when CONFIG_NET is not defined
2024-12-18 21:44 [PATCH linux-pm] thermal: intel: Fix compile issue when CONFIG_NET is not defined Srinivas Pandruvada
@ 2024-12-19 11:43 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2024-12-19 11:43 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: rafael, rui.zhang, daniel.lezcano, lukasz.luba, linux-pm,
linux-kernel, kernel test robot
On Wed, Dec 18, 2024 at 10:45 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> If CONFIG_NET is not defined then THERMAL_NETLINK can't be selected.
> Hence add dependency on CONFIG_NET. Othewise it will generate compile
> errors while compiling thermal_netlink.c.
>
> Fixes: 4596cbea0ed2 ("thermal: intel: Remove explicit user_space governor selection")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> This commit ID 4596cbea0ed2 is from linux-pm bleeding edge branch of
> linux-pm git.
>
> drivers/thermal/intel/Kconfig | 1 +
> drivers/thermal/intel/int340x_thermal/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> index 9c0f66f9defc..e1973c0efe0c 100644
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -22,6 +22,7 @@ config INTEL_TCC
> config X86_PKG_TEMP_THERMAL
> tristate "X86 package temperature thermal driver"
> depends on X86_THERMAL_VECTOR
> + depends on NET
> select THERMAL_NETLINK
> select INTEL_TCC
> default m
> diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
> index d9a74424c29d..6a0203eaa7f2 100644
> --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> @@ -6,6 +6,7 @@
> config INT340X_THERMAL
> tristate "ACPI INT340X thermal drivers"
> depends on X86_64 && ACPI && PCI
> + depends on NET
> select THERMAL_NETLINK
> select ACPI_THERMAL_REL
> select ACPI_FAN
> --
Applied, but I've just added the missing NET dependency to the
existing "depends on" lines. Please check my bleeding-edge branch.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-19 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-18 21:44 [PATCH linux-pm] thermal: intel: Fix compile issue when CONFIG_NET is not defined Srinivas Pandruvada
2024-12-19 11:43 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®