* [PATCH] hwmon: pmbus: dps920ab: Add ability to instantiate through i2c
@ 2024-12-19 9:47 Denis Kirjanov
2024-12-19 14:15 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Denis Kirjanov @ 2024-12-19 9:47 UTC (permalink / raw)
To: robert.marko, jdelvare, linux; +Cc: linux-hwmon, linux-kernel, Denis Kirjanov
Now we can bind the driver with a command like:
echo "dps920ab" 0x58 > /sys/bus/i2c/devices/i2c-0/new_device
...
[616189.076211] i2c i2c-0: new_device: Instantiated device dps920ab at 0x58
Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
---
drivers/hwmon/pmbus/dps920ab.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/pmbus/dps920ab.c b/drivers/hwmon/pmbus/dps920ab.c
index cc5aac9dfdb3..c002ed41f517 100644
--- a/drivers/hwmon/pmbus/dps920ab.c
+++ b/drivers/hwmon/pmbus/dps920ab.c
@@ -190,12 +190,19 @@ static const struct of_device_id __maybe_unused dps920ab_of_match[] = {
MODULE_DEVICE_TABLE(of, dps920ab_of_match);
+static struct i2c_device_id dps920ab_i2c_match[] = {
+ { "dps920ab" },
+ {}
+};
+MODULE_DEVICE_TABLE(i2c, dps920ab_i2c_match);
+
static struct i2c_driver dps920ab_driver = {
.driver = {
.name = "dps920ab",
.of_match_table = of_match_ptr(dps920ab_of_match),
},
.probe = dps920ab_probe,
+ .id_table = dps920ab_device_id,
};
module_i2c_driver(dps920ab_driver);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: pmbus: dps920ab: Add ability to instantiate through i2c
2024-12-19 9:47 [PATCH] hwmon: pmbus: dps920ab: Add ability to instantiate through i2c Denis Kirjanov
@ 2024-12-19 14:15 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2024-12-19 14:15 UTC (permalink / raw)
To: Denis Kirjanov, robert.marko, jdelvare; +Cc: linux-hwmon, linux-kernel
On 12/19/24 01:47, Denis Kirjanov wrote:
> Now we can bind the driver with a command like:
>
> echo "dps920ab" 0x58 > /sys/bus/i2c/devices/i2c-0/new_device
> ...
> [616189.076211] i2c i2c-0: new_device: Instantiated device dps920ab at 0x58
>
This is not an appropriate patch description.
Please refer to Documentation/process/submitting-patches.rst.
Thanks,
Guenter
> Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
> ---
> drivers/hwmon/pmbus/dps920ab.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hwmon/pmbus/dps920ab.c b/drivers/hwmon/pmbus/dps920ab.c
> index cc5aac9dfdb3..c002ed41f517 100644
> --- a/drivers/hwmon/pmbus/dps920ab.c
> +++ b/drivers/hwmon/pmbus/dps920ab.c
> @@ -190,12 +190,19 @@ static const struct of_device_id __maybe_unused dps920ab_of_match[] = {
>
> MODULE_DEVICE_TABLE(of, dps920ab_of_match);
>
> +static struct i2c_device_id dps920ab_i2c_match[] = {
> + { "dps920ab" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, dps920ab_i2c_match);
> +
> static struct i2c_driver dps920ab_driver = {
> .driver = {
> .name = "dps920ab",
> .of_match_table = of_match_ptr(dps920ab_of_match),
> },
> .probe = dps920ab_probe,
> + .id_table = dps920ab_device_id,
> };
>
> module_i2c_driver(dps920ab_driver);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-19 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-19 9:47 [PATCH] hwmon: pmbus: dps920ab: Add ability to instantiate through i2c Denis Kirjanov
2024-12-19 14:15 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®