mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Sun <sunjunchao2870@gmail.com>
To: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
	boyu.mt@taobao.com, tm@tao.ma,
	Julian Sun <sunjunchao2870@gmail.com>
Subject: [PATCH 1/7] ext4: Modify ei->i_flags before calling ext4_mark_iloc_dirty()
Date: Fri, 20 Dec 2024 23:16:19 +0800	[thread overview]
Message-ID: <20241220151625.19769-2-sunjunchao2870@gmail.com> (raw)
In-Reply-To: <20241220151625.19769-1-sunjunchao2870@gmail.com>

Modify ei->i_flags before calling ext4_mark_iloc_dirty() so that
the modifications to ei->i_flags can be reflected in the raw_inode
during the call to ext4_mark_iloc_dirty()->ext4_do_update_inode()

Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
---
 fs/ext4/inline.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 3536ca7e4fcc..d479495d03aa 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -465,11 +465,10 @@ static int ext4_destroy_inline_data_nolock(handle_t *handle,
 	ext4_clear_inode_flag(inode, EXT4_INODE_INLINE_DATA);
 
 	get_bh(is.iloc.bh);
-	error = ext4_mark_iloc_dirty(handle, inode, &is.iloc);
-
 	EXT4_I(inode)->i_inline_off = 0;
 	EXT4_I(inode)->i_inline_size = 0;
 	ext4_clear_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA);
+	error = ext4_mark_iloc_dirty(handle, inode, &is.iloc);
 out:
 	brelse(is.iloc.bh);
 	if (error == -ENODATA)
-- 
2.39.5


  reply	other threads:[~2024-12-20 15:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 15:16 [PATCH 0/7] ext4: Convert truncated extent data to inline data Julian Sun
2024-12-20 15:16 ` Julian Sun [this message]
2025-01-06 15:25   ` [PATCH 1/7] ext4: Modify ei->i_flags before calling ext4_mark_iloc_dirty() Jan Kara
2025-01-07  2:53     ` Julian Sun
2024-12-20 15:16 ` [PATCH 2/7] ext4: Remove a redundant return statement Julian Sun
2025-01-06 15:23   ` Jan Kara
2024-12-20 15:16 ` [PATCH 3/7] ext4: Don't set EXT4_STATE_MAY_INLINE_DATA for ea inodes Julian Sun
2025-01-06 15:23   ` Jan Kara
2024-12-20 15:16 ` [PATCH 4/7] ext4: Introduce a new helper function ext4_generic_write_inline_data() Julian Sun
2025-01-06 15:35   ` Jan Kara
2025-01-07  2:57     ` Julian Sun
2024-12-20 15:16 ` [PATCH 5/7] ext4: Refactor out ext4_da_write_inline_data_begin() Julian Sun
2025-01-06 15:39   ` Jan Kara
2025-01-07  2:58     ` Julian Sun
2024-12-20 15:16 ` [PATCH 6/7] ext4: Refactor out ext4_try_to_write_inline_data() Julian Sun
2025-01-06 15:40   ` Jan Kara
2024-12-20 15:16 ` [PATCH 7/7] ext4: Store truncated large files as inline data Julian Sun
2025-01-06 15:51 ` [PATCH 0/7] ext4: Convert truncated extent data to " Jan Kara
2025-01-07  6:03   ` Julian Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241220151625.19769-2-sunjunchao2870@gmail.com \
    --to=sunjunchao2870@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=boyu.mt@taobao.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tm@tao.ma \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®