From: Julian Sun <sunjunchao2870@gmail.com>
To: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
boyu.mt@taobao.com, tm@tao.ma,
Julian Sun <sunjunchao2870@gmail.com>
Subject: [PATCH 4/7] ext4: Introduce a new helper function ext4_generic_write_inline_data()
Date: Fri, 20 Dec 2024 23:16:22 +0800 [thread overview]
Message-ID: <20241220151625.19769-5-sunjunchao2870@gmail.com> (raw)
In-Reply-To: <20241220151625.19769-1-sunjunchao2870@gmail.com>
A new function, ext4_generic_write_inline_data(), is introduced
to provide a generic implementation of the common logic found in
ext4_da_write_inline_data_begin() and ext4_try_to_write_inline_data().
This function will be utilized in the subsequent two patches.
Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
---
fs/ext4/inline.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 85 insertions(+)
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index d479495d03aa..7eaa578e1021 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -20,6 +20,11 @@
#define EXT4_INLINE_DOTDOT_OFFSET 2
#define EXT4_INLINE_DOTDOT_SIZE 4
+
+static int ext4_da_convert_inline_data_to_extent(struct address_space *mapping,
+ struct inode *inode,
+ void **fsdata);
+
static int ext4_get_inline_size(struct inode *inode)
{
if (EXT4_I(inode)->i_inline_off)
@@ -651,6 +656,86 @@ static int ext4_convert_inline_data_to_extent(struct address_space *mapping,
return ret;
}
+static int ext4_generic_write_inline_data(struct address_space *mapping,
+ struct inode *inode,
+ loff_t pos, unsigned len,
+ struct folio **foliop,
+ void **fsdata, bool da)
+{
+ int ret;
+ handle_t *handle;
+ struct folio *folio;
+ struct ext4_iloc iloc;
+ int retries = 0;
+
+ ret = ext4_get_inode_loc(inode, &iloc);
+ if (ret)
+ return ret;
+
+retry_journal:
+ handle = ext4_journal_start(inode, EXT4_HT_INODE, 1);
+ if (IS_ERR(handle)) {
+ ret = PTR_ERR(handle);
+ goto out_release_bh;
+ }
+
+ ret = ext4_prepare_inline_data(handle, inode, pos + len);
+ if (ret && ret != -ENOSPC)
+ goto out_stop_journal;
+
+ if (ret == -ENOSPC) {
+ ext4_journal_stop(handle);
+ if (!da) {
+ brelse(iloc.bh);
+ /* Retry inside */
+ return ext4_convert_inline_data_to_extent(mapping, inode);
+ }
+
+ ret = ext4_da_convert_inline_data_to_extent(mapping, inode, fsdata);
+ if (ret == -ENOSPC &&
+ ext4_should_retry_alloc(inode->i_sb, &retries))
+ goto retry_journal;
+ goto out_release_bh;
+ }
+
+ folio = __filemap_get_folio(mapping, 0, FGP_WRITEBEGIN | FGP_NOFS,
+ mapping_gfp_mask(mapping));
+ if (IS_ERR(folio)) {
+ ret = PTR_ERR(folio);
+ goto out_stop_journal;
+ }
+
+ down_read(&EXT4_I(inode)->xattr_sem);
+ /* Someone else had converted it to extent */
+ if (!ext4_has_inline_data(inode)) {
+ ret = 0;
+ goto out_release_folio;
+ }
+
+ if (!folio_test_uptodate(folio)) {
+ ret = ext4_read_inline_folio(inode, folio);
+ if (ret < 0)
+ goto out_release_folio;
+ }
+
+ ret = ext4_journal_get_write_access(handle, inode->i_sb, iloc.bh, EXT4_JTR_NONE);
+ if (ret)
+ goto out_release_folio;
+ *foliop = folio;
+ up_read(&EXT4_I(inode)->xattr_sem);
+ brelse(iloc.bh);
+ return 1;
+out_release_folio:
+ up_read(&EXT4_I(inode)->xattr_sem);
+ folio_unlock(folio);
+ folio_put(folio);
+out_stop_journal:
+ ext4_journal_stop(handle);
+out_release_bh:
+ brelse(iloc.bh);
+ return ret;
+}
+
/*
* Try to write data in the inode.
* If the inode has inline data, check whether the new write can be
--
2.39.5
next prev parent reply other threads:[~2024-12-20 15:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 15:16 [PATCH 0/7] ext4: Convert truncated extent data to inline data Julian Sun
2024-12-20 15:16 ` [PATCH 1/7] ext4: Modify ei->i_flags before calling ext4_mark_iloc_dirty() Julian Sun
2025-01-06 15:25 ` Jan Kara
2025-01-07 2:53 ` Julian Sun
2024-12-20 15:16 ` [PATCH 2/7] ext4: Remove a redundant return statement Julian Sun
2025-01-06 15:23 ` Jan Kara
2024-12-20 15:16 ` [PATCH 3/7] ext4: Don't set EXT4_STATE_MAY_INLINE_DATA for ea inodes Julian Sun
2025-01-06 15:23 ` Jan Kara
2024-12-20 15:16 ` Julian Sun [this message]
2025-01-06 15:35 ` [PATCH 4/7] ext4: Introduce a new helper function ext4_generic_write_inline_data() Jan Kara
2025-01-07 2:57 ` Julian Sun
2024-12-20 15:16 ` [PATCH 5/7] ext4: Refactor out ext4_da_write_inline_data_begin() Julian Sun
2025-01-06 15:39 ` Jan Kara
2025-01-07 2:58 ` Julian Sun
2024-12-20 15:16 ` [PATCH 6/7] ext4: Refactor out ext4_try_to_write_inline_data() Julian Sun
2025-01-06 15:40 ` Jan Kara
2024-12-20 15:16 ` [PATCH 7/7] ext4: Store truncated large files as inline data Julian Sun
2025-01-06 15:51 ` [PATCH 0/7] ext4: Convert truncated extent data to " Jan Kara
2025-01-07 6:03 ` Julian Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220151625.19769-5-sunjunchao2870@gmail.com \
--to=sunjunchao2870@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=boyu.mt@taobao.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tm@tao.ma \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®