[PATCH] media: coda: Add system resume interface

[PATCH] media: coda: Add system resume interface

[Xiaolei Wang]

When the system goes into sleep mode, the dependent
power will be turned off, so when the system resumes,
coda_hw_init() needs to be called, otherwise it will
get 'CODA PIC_RUN timeout' after resuming.

Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 drivers/media/platform/chips-media/coda/coda-common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-common.c
index 289a076c3bcc..e6e3f5ec24f6 100644
--- a/drivers/media/platform/chips-media/coda/coda-common.c
+++ b/drivers/media/platform/chips-media/coda/coda-common.c
@@ -3340,6 +3340,7 @@ static int coda_runtime_resume(struct device *dev)
 
 static const struct dev_pm_ops coda_pm_ops = {
 	SET_RUNTIME_PM_OPS(NULL, coda_runtime_resume, NULL)
+	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
 };
 
 static struct platform_driver coda_driver = {
-- 
2.25.1

Re: [PATCH] media: coda: Add system resume interface

[Philipp Zabel]

On Sa, 2024-12-21 at 11:14 +0800, Xiaolei Wang wrote:
> When the system goes into sleep mode, the dependent
> power will be turned off, so when the system resumes,
> coda_hw_init() needs to be called, otherwise it will
> get 'CODA PIC_RUN timeout' after resuming.
> 
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> ---
>  drivers/media/platform/chips-media/coda/coda-common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-common.c
> index 289a076c3bcc..e6e3f5ec24f6 100644
> --- a/drivers/media/platform/chips-media/coda/coda-common.c
> +++ b/drivers/media/platform/chips-media/coda/coda-common.c
> @@ -3340,6 +3340,7 @@ static int coda_runtime_resume(struct device *dev)
>  
>  static const struct dev_pm_ops coda_pm_ops = {
>  	SET_RUNTIME_PM_OPS(NULL, coda_runtime_resume, NULL)
> +	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
>  };
>  
>  static struct platform_driver coda_driver = {

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

Re: [PATCH] media: coda: Add system resume interface

[xiaolei wang]

On 1/6/25 16:15, Philipp Zabel wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Sa, 2024-12-21 at 11:14 +0800, Xiaolei Wang wrote:
>> When the system goes into sleep mode, the dependent
>> power will be turned off, so when the system resumes,
>> coda_hw_init() needs to be called, otherwise it will
>> get 'CODA PIC_RUN timeout' after resuming.
>>
>> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
>> ---
>>   drivers/media/platform/chips-media/coda/coda-common.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-common.c
>> index 289a076c3bcc..e6e3f5ec24f6 100644
>> --- a/drivers/media/platform/chips-media/coda/coda-common.c
>> +++ b/drivers/media/platform/chips-media/coda/coda-common.c
>> @@ -3340,6 +3340,7 @@ static int coda_runtime_resume(struct device *dev)
>>
>>   static const struct dev_pm_ops coda_pm_ops = {
>>        SET_RUNTIME_PM_OPS(NULL, coda_runtime_resume, NULL)
>> +     SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
>>   };
>>
>>   static struct platform_driver coda_driver = {
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

Humble Ping...

thanks

xiaolei

>
> regards
> Philipp