mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, sgarzare@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH v5 5/6] vhost: Add new UAPI to support change to task mode
Date: Mon, 30 Dec 2024 20:43:52 +0800	[thread overview]
Message-ID: <20241230124445.1850997-6-lulu@redhat.com> (raw)
In-Reply-To: <20241230124445.1850997-1-lulu@redhat.com>

Add a new UAPI to enable setting the vhost device to task mode.
The userspace application can use VHOST_SET_INHERIT_FROM_OWNER
to configure the mode if necessary.
This setting must be applied before VHOST_SET_OWNER, as the worker
will be created in the VHOST_SET_OWNER function

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/vhost.c      | 22 +++++++++++++++++++++-
 include/uapi/linux/vhost.h | 19 +++++++++++++++++++
 2 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index ff17c42e2d1a..47c1329360ac 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -2250,15 +2250,35 @@ long vhost_dev_ioctl(struct vhost_dev *d, unsigned int ioctl, void __user *argp)
 {
 	struct eventfd_ctx *ctx;
 	u64 p;
-	long r;
+	long r = 0;
 	int i, fd;
+	u8 inherit_owner;
 
 	/* If you are not the owner, you can become one */
 	if (ioctl == VHOST_SET_OWNER) {
 		r = vhost_dev_set_owner(d);
 		goto done;
 	}
+	if (ioctl == VHOST_SET_INHERIT_FROM_OWNER) {
+		/*inherit_owner can only be modified before owner is set*/
+		if (vhost_dev_has_owner(d)) {
+			r = -EBUSY;
+			goto done;
+		}
+		if (copy_from_user(&inherit_owner, argp, sizeof(u8))) {
+			r = -EFAULT;
+			goto done;
+		}
+		/* Validate the inherit_owner value, ensuring it is either 0 or 1 */
+		if (inherit_owner > 1) {
+			r = -EINVAL;
+			goto done;
+		}
+
+		d->inherit_owner = (bool)inherit_owner;
 
+		goto done;
+	}
 	/* You must be the owner to do anything else */
 	r = vhost_dev_check_owner(d);
 	if (r)
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index b95dd84eef2d..f5fcf0b25736 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -235,4 +235,23 @@
  */
 #define VHOST_VDPA_GET_VRING_SIZE	_IOWR(VHOST_VIRTIO, 0x82,	\
 					      struct vhost_vring_state)
+
+/**
+ * VHOST_SET_INHERIT_FROM_OWNER - Set the inherit_owner flag for the vhost device
+ *
+ * @param inherit_owner: An 8-bit value that determines the vhost thread mode
+ *
+ * When inherit_owner is set to 1 (default behavior):
+ *   - The VHOST worker threads inherit their values/checks from
+ *     the thread that owns the VHOST device. The vhost threads will
+ *     be counted in the nproc rlimits.
+ *
+ * When inherit_owner is set to 0:
+ *   - The VHOST worker threads will use the traditional kernel thread (kthread)
+ *     implementation, which may be preferred by older userspace applications that
+ *     do not utilize the newer vhost_task concept.
+ */
+
+#define VHOST_SET_INHERIT_FROM_OWNER _IOW(VHOST_VIRTIO, 0x83, __u8)
+
 #endif
-- 
2.45.0


  parent reply	other threads:[~2024-12-30 12:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30 12:43 [PATCH v5 0/6] vhost: Add support of kthread API Cindy Lu
2024-12-30 12:43 ` [PATCH v5 1/6] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2025-01-02  2:18   ` Jason Wang
2024-12-30 12:43 ` [PATCH v5 2/6] vhost: Add the vhost_worker to support kthread Cindy Lu
2025-01-02  3:19   ` Jason Wang
2025-01-08  2:59     ` Cindy Lu
2024-12-30 12:43 ` [PATCH v5 3/6] vhost: Add the cgroup related function Cindy Lu
2025-01-02  3:29   ` Jason Wang
2025-01-08  2:57     ` Cindy Lu
2025-01-08  7:39       ` Jason Wang
2024-12-30 12:43 ` [PATCH v5 4/6] vhost: Add worker related functions to support kthread Cindy Lu
2025-01-02  3:33   ` Jason Wang
2025-01-08  2:52     ` Cindy Lu
2025-01-08 14:35   ` Stefano Garzarella
2025-01-13  2:31     ` Cindy Lu
2024-12-30 12:43 ` Cindy Lu [this message]
2025-01-02  3:36   ` [PATCH v5 5/6] vhost: Add new UAPI to support change to task mode Jason Wang
2025-01-08  2:51     ` Cindy Lu
2025-01-08 12:20     ` Michael S. Tsirkin
2025-01-08 12:15   ` Michael S. Tsirkin
2024-12-30 12:43 ` [PATCH v5 6/6] vhost_scsi: Add check for inherit_owner status Cindy Lu
2025-01-22 20:18   ` Mike Christie
2025-01-03  1:49 ` [PATCH v5 0/6] vhost: Add support of kthread API Lei Yang
2025-01-08 12:23 ` Michael S. Tsirkin
2025-01-13  2:32   ` Cindy Lu
2025-01-22 21:30 ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241230124445.1850997-6-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®