mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, sgarzare@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH v5 6/6] vhost_scsi: Add check for inherit_owner status
Date: Mon, 30 Dec 2024 20:43:53 +0800	[thread overview]
Message-ID: <20241230124445.1850997-7-lulu@redhat.com> (raw)
In-Reply-To: <20241230124445.1850997-1-lulu@redhat.com>

The vhost_scsi VHOST_NEW_WORKER requires the inherit_owner
setting to be true. So we need to implement a check for this.

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/scsi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 718fa4e0b31e..0d63b6b5c852 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -2086,6 +2086,14 @@ vhost_scsi_ioctl(struct file *f,
 			return -EFAULT;
 		return vhost_scsi_set_features(vs, features);
 	case VHOST_NEW_WORKER:
+		/*
+		 * vhost_tasks will account for worker threads under the parent's
+		 * NPROC value but kthreads do not. To avoid userspace overflowing
+		 * the system with worker threads inherit_owner must be true.
+		 */
+		if (!vs->dev.inherit_owner)
+			return -EFAULT;
+		fallthrough;
 	case VHOST_FREE_WORKER:
 	case VHOST_ATTACH_VRING_WORKER:
 	case VHOST_GET_VRING_WORKER:
-- 
2.45.0


  parent reply	other threads:[~2024-12-30 12:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30 12:43 [PATCH v5 0/6] vhost: Add support of kthread API Cindy Lu
2024-12-30 12:43 ` [PATCH v5 1/6] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2025-01-02  2:18   ` Jason Wang
2024-12-30 12:43 ` [PATCH v5 2/6] vhost: Add the vhost_worker to support kthread Cindy Lu
2025-01-02  3:19   ` Jason Wang
2025-01-08  2:59     ` Cindy Lu
2024-12-30 12:43 ` [PATCH v5 3/6] vhost: Add the cgroup related function Cindy Lu
2025-01-02  3:29   ` Jason Wang
2025-01-08  2:57     ` Cindy Lu
2025-01-08  7:39       ` Jason Wang
2024-12-30 12:43 ` [PATCH v5 4/6] vhost: Add worker related functions to support kthread Cindy Lu
2025-01-02  3:33   ` Jason Wang
2025-01-08  2:52     ` Cindy Lu
2025-01-08 14:35   ` Stefano Garzarella
2025-01-13  2:31     ` Cindy Lu
2024-12-30 12:43 ` [PATCH v5 5/6] vhost: Add new UAPI to support change to task mode Cindy Lu
2025-01-02  3:36   ` Jason Wang
2025-01-08  2:51     ` Cindy Lu
2025-01-08 12:20     ` Michael S. Tsirkin
2025-01-08 12:15   ` Michael S. Tsirkin
2024-12-30 12:43 ` Cindy Lu [this message]
2025-01-22 20:18   ` [PATCH v5 6/6] vhost_scsi: Add check for inherit_owner status Mike Christie
2025-01-03  1:49 ` [PATCH v5 0/6] vhost: Add support of kthread API Lei Yang
2025-01-08 12:23 ` Michael S. Tsirkin
2025-01-13  2:32   ` Cindy Lu
2025-01-22 21:30 ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241230124445.1850997-7-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®