Re: [PATCH net-next v01 1/1] hinic3: module initialization and tx/rx logic

[Gur Stavi <gur.stavi@huawei.com>]

> >
> > We studied previous submissions and followed their example.
> > Were the maintainers wrong to approve Amazon and Microsoft drivers?
>
> It's not a right or wrong question, more a cost/benefit question.
> I'm not sure the community benefits from merging every single company's
> paravirt driver, when virtio exists. I'd say having those drivers
> upstream is somewhere around neutral.
>
> BTW very often guidance for new drivers is set by problems with already
> merged drivers. Not that it's necessarily the case here, just sharing
> some general knowledge about the upstream process.
>
> > I don't understand what the problem is. Please clarify.
>
> Primarily the fact that you keep arguing as if joining the community
> was done by winning a fight. If annotating HW structures with endian
> is beyond your / your teams capabilities, that's okay, just replace
> the "will not be converted" with "are currently not converted" in
> the comment.
>

Ack

> For your reference here are the development stats showing that
> Huawei is the biggest net-taker of code reviews in networking:
> https://lore.kernel.org/all/20241119191608.514ea226@kernel.org/