From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 4/4] drm/msm/dsi: Drop unnecessary -ENOMEM message
Date: Mon, 06 Jan 2025 09:49:07 +0100 [thread overview]
Message-ID: <20250106-drm-msm-cleanups-v1-4-271ff1c00795@linaro.org> (raw)
In-Reply-To: <20250106-drm-msm-cleanups-v1-0-271ff1c00795@linaro.org>
Kernel core already prints detailed report about memory allocation
failures, so drivers should not have their own error messages.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index a3c344b75fc2e90923cd6d26df87b7c05208f736..ab5d6fd53972f62307b0c5b801cca8b2394c5556 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1910,10 +1910,8 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi)
return dev_err_probe(&pdev->dev, ret, "%s: unable to initialize dsi clks\n", __func__);
msm_host->rx_buf = devm_kzalloc(&pdev->dev, SZ_4K, GFP_KERNEL);
- if (!msm_host->rx_buf) {
- pr_err("%s: alloc rx temp buf failed\n", __func__);
+ if (!msm_host->rx_buf)
return -ENOMEM;
- }
ret = devm_pm_opp_set_clkname(&pdev->dev, "byte");
if (ret)
--
2.43.0
next prev parent reply other threads:[~2025-01-06 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:49 [PATCH 0/4] drm/msm/dsi: Minor cleanups Krzysztof Kozlowski
2025-01-06 8:49 ` [PATCH 1/4] drm/msm/dsi: Drop redundant NULL-ifying of clocks on error paths Krzysztof Kozlowski
2025-01-07 2:43 ` Abhinav Kumar
2025-01-06 8:49 ` [PATCH 2/4] drm/msm/dsi: Simplify with dev_err_probe() Krzysztof Kozlowski
2025-01-07 2:56 ` Abhinav Kumar
2025-01-07 6:08 ` Krzysztof Kozlowski
2025-01-06 8:49 ` [PATCH 3/4] drm/msm/dsi: Minor whitespace and style cleanup Krzysztof Kozlowski
2025-01-07 3:00 ` Abhinav Kumar
2025-01-06 8:49 ` Krzysztof Kozlowski [this message]
2025-01-07 3:11 ` [PATCH 4/4] drm/msm/dsi: Drop unnecessary -ENOMEM message Abhinav Kumar
2025-02-14 10:52 ` [PATCH 0/4] drm/msm/dsi: Minor cleanups Krzysztof Kozlowski
2025-02-14 11:30 ` Dmitry Baryshkov
2025-02-14 11:39 ` Krzysztof Kozlowski
2025-02-14 11:47 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106-drm-msm-cleanups-v1-4-271ff1c00795@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®