From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] drm/msm/dsi: Simplify with dev_err_probe()
Date: Mon, 6 Jan 2025 18:56:41 -0800 [thread overview]
Message-ID: <5edcfc62-ee70-48c2-a24a-642a39f83767@quicinc.com> (raw)
In-Reply-To: <20250106-drm-msm-cleanups-v1-2-271ff1c00795@linaro.org>
On 1/6/2025 12:49 AM, Krzysztof Kozlowski wrote:
> dsi_clk_init() and msm_dsi_host_init() are called only from platform
dsi_get_config() as well? OR you didnt want to explicitly mention that
since its called from msm_dsi_host_init().
> driver probe function, so using dev_err_probe is both appropriate and
> beneficial:
> - Properly marks device deferred probe status,
> - Avoids dmesg flood on probe deferrals,
> - Already incorporates printing ERR value,
> - Shows device name (in contrast to pr_err()),
> - Makes code smaller and simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 100 +++++++++++++++----------------------
> 1 file changed, 41 insertions(+), 59 deletions(-)
>
Change LGTM,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
next prev parent reply other threads:[~2025-01-07 2:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:49 [PATCH 0/4] drm/msm/dsi: Minor cleanups Krzysztof Kozlowski
2025-01-06 8:49 ` [PATCH 1/4] drm/msm/dsi: Drop redundant NULL-ifying of clocks on error paths Krzysztof Kozlowski
2025-01-07 2:43 ` Abhinav Kumar
2025-01-06 8:49 ` [PATCH 2/4] drm/msm/dsi: Simplify with dev_err_probe() Krzysztof Kozlowski
2025-01-07 2:56 ` Abhinav Kumar [this message]
2025-01-07 6:08 ` Krzysztof Kozlowski
2025-01-06 8:49 ` [PATCH 3/4] drm/msm/dsi: Minor whitespace and style cleanup Krzysztof Kozlowski
2025-01-07 3:00 ` Abhinav Kumar
2025-01-06 8:49 ` [PATCH 4/4] drm/msm/dsi: Drop unnecessary -ENOMEM message Krzysztof Kozlowski
2025-01-07 3:11 ` Abhinav Kumar
2025-02-14 10:52 ` [PATCH 0/4] drm/msm/dsi: Minor cleanups Krzysztof Kozlowski
2025-02-14 11:30 ` Dmitry Baryshkov
2025-02-14 11:39 ` Krzysztof Kozlowski
2025-02-14 11:47 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5edcfc62-ee70-48c2-a24a-642a39f83767@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®