* [RESEND PATCH v2] HID: Add reserved item tag for main items
@ 2025-01-06 7:49 Tatsuya S
2025-02-07 15:04 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Tatsuya S @ 2025-01-06 7:49 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: Tatsuya S, linux-input, linux-kernel
For main items, separate warning of reserved item tag from
warning of unknown item tag.
This comes from 6.2.2.4 Main Items of Device Class Definition
for HID 1.11 specification.
Signed-off-by: Tatsuya S <tatsuya.s2862@gmail.com>
---
V1 -> V2: Add specification location to commit message.
drivers/hid/hid-core.c | 6 +++++-
include/linux/hid.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 582fd234eec7..98f557fa9e17 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -629,7 +629,11 @@ static int hid_parser_main(struct hid_parser *parser, struct hid_item *item)
ret = hid_add_field(parser, HID_FEATURE_REPORT, data);
break;
default:
- hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag);
+ if (item->tag >= HID_MAIN_ITEM_TAG_RESERVED_MIN &&
+ item->tag <= HID_MAIN_ITEM_TAG_RESERVED_MAX)
+ hid_warn(parser->device, "reserved main item tag 0x%x\n", item->tag);
+ else
+ hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag);
ret = 0;
}
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 121d5b8bc867..e3894f38bd96 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -81,6 +81,8 @@ struct hid_item {
#define HID_MAIN_ITEM_TAG_FEATURE 11
#define HID_MAIN_ITEM_TAG_BEGIN_COLLECTION 10
#define HID_MAIN_ITEM_TAG_END_COLLECTION 12
+#define HID_MAIN_ITEM_TAG_RESERVED_MIN 13
+#define HID_MAIN_ITEM_TAG_RESERVED_MAX 15
/*
* HID report descriptor main item contents
--
2.47.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH v2] HID: Add reserved item tag for main items
2025-01-06 7:49 [RESEND PATCH v2] HID: Add reserved item tag for main items Tatsuya S
@ 2025-02-07 15:04 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2025-02-07 15:04 UTC (permalink / raw)
To: Tatsuya S; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Mon, 6 Jan 2025, Tatsuya S wrote:
> For main items, separate warning of reserved item tag from
> warning of unknown item tag.
> This comes from 6.2.2.4 Main Items of Device Class Definition
> for HID 1.11 specification.
Applied, thank you.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-07 15:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-06 7:49 [RESEND PATCH v2] HID: Add reserved item tag for main items Tatsuya S
2025-02-07 15:04 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®