[PATCH RESEND v2 0/3] arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

[PATCH RESEND v2 0/3] arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

[Ricky Cheung via B4 Relay]

Good evening.

This patch adds support for the XiaoXun JZ0145 v33 4G LTE WiFi modem
based on the MSM8916 chipset by a new manufacturer / vendor for the
Linux Kernel called called XiaoXun BiCheng Technology. Below is some
information about these changes.

Addition of a new vendor prefix
----------

XiaoXun BiCheng Technology is not well known in that they don't seem
to have a presence in the Western world. I purchased my own modem
on TaoBao, which requires stores to registered as businesses, so
I believe it is justified to add it as a vendor prefix. Note that the
company appears to have shut down just this month.

Status of patch
----------

This device shares many similarities to pre-existing devices within
arch/arm64/boot/dts/msm8916-ufi.dtsi, so I am sure most features would
function with the correct firmware on this device.

However, due to the poor quality of these devices, my unit's EMMC has
failed and I cannot conduct further tests. Previous, the modem was
able to boot with devicetree of a UZ801, albeit with LED and Modem
issues, which is addressed in this patch.

I have sent the code for testing to some kind folks on the Internet with
good outcomes, so do consider this code as ready and functional.

This patch was also reviewed over at the msm8916-mainline organization
and deemed ready by the maintainer:

	https://github.com/msm8916-mainline/linux/pull/386

Note that this is my first patch to the LKML, so if there's something I
did wrong / the patch is missing, please point it out.

Best Regards,
Ricky Cheung
Tipz Team

Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/20250114-xiaoxun-jz0145-v33-v1-0-dc51f7ce3bd8@gmail.com

---
Ricky Cheung (3):
      dt-bindings: vendor-prefixes: Add XiaoXun BiCheng Technology
      dt-bindings: arm: qcom: Add XiaoXun JZ0145 v33
      arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

 Documentation/devicetree/bindings/arm/qcom.yaml    |  1 +
 .../devicetree/bindings/vendor-prefixes.yaml       |  2 +
 arch/arm64/boot/dts/qcom/Makefile                  |  1 +
 .../boot/dts/qcom/msm8916-xiaoxun-jz0145-v33.dts   | 66 ++++++++++++++++++++++
 4 files changed, 70 insertions(+)
---
base-commit: d390303b28dabbb91b2d32016a4f72da478733b9
change-id: 20250114-xiaoxun-jz0145-v33-23dc006cf130

Best regards,
-- 
Ricky Cheung <rcheung844@gmail.com>

[PATCH RESEND v2 1/3] dt-bindings: vendor-prefixes: Add XiaoXun BiCheng Technology

[Ricky Cheung via B4 Relay]

From: Ricky Cheung <rcheung844@gmail.com>

Add a vendor prefix for XiaoXun BiCheng Technology, which was an online
store on TaoBao selling 4G LTE WiFi modems.

TaoBao mostly require stores to be operated by companies, so they are
a valid vendor. However, this company has ended operations recently.

Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index b320a39de7fe40ce4d97ed3ea264a5971a3428dd..9bbd21b47201d866ae68e6ae406189266871617f 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1673,6 +1673,8 @@ patternProperties:
     description: Extreme Engineering Solutions (X-ES)
   "^xiaomi,.*":
     description: Xiaomi Technology Co., Ltd.
+  "^xiaoxun,.*":
+    description: XiaoXun BiCheng Technology
   "^xillybus,.*":
     description: Xillybus Ltd.
   "^xingbangda,.*":

-- 
2.47.1

Re: [PATCH RESEND v2 1/3] dt-bindings: vendor-prefixes: Add XiaoXun BiCheng Technology

[Krzysztof Kozlowski]

On Tue, Jan 14, 2025 at 10:46:48PM +0800, Ricky Cheung wrote:
> Add a vendor prefix for XiaoXun BiCheng Technology, which was an online
> store on TaoBao selling 4G LTE WiFi modems.
> 
> TaoBao mostly require stores to be operated by companies, so they are
> a valid vendor. However, this company has ended operations recently.
> 
> Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here. However, there's no
need to repost patches *only* to add the tags. The upstream maintainer
will do that for tags received on the version they apply.

https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof

[PATCH RESEND v2 2/3] dt-bindings: arm: qcom: Add XiaoXun JZ0145 v33

[Ricky Cheung via B4 Relay]

From: Ricky Cheung <rcheung844@gmail.com>

Document the MSM8916-based 4G LTE WiFi modem.

Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 5cb54d69af0b7206e0f6a66023a203b8d7087696..92dd91cb66b7b1b26b013a7d32c20dfe44690569 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -245,6 +245,7 @@ properties:
               - wingtech,wt86518
               - wingtech,wt86528
               - wingtech,wt88047
+              - xiaoxun,jz0145-v33
               - yiming,uz801-v3
           - const: qcom,msm8916
 

-- 
2.47.1

Re: [PATCH RESEND v2 2/3] dt-bindings: arm: qcom: Add XiaoXun JZ0145 v33

[Krzysztof Kozlowski]

On Tue, Jan 14, 2025 at 10:46:49PM +0800, Ricky Cheung wrote:
> Document the MSM8916-based 4G LTE WiFi modem.
> 
> Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH RESEND v2 2/3] dt-bindings: arm: qcom: Add XiaoXun JZ0145 v33

[Yang Xiwen]

On 1/14/2025 10:46 PM, Ricky Cheung via B4 Relay wrote:
> From: Ricky Cheung <rcheung844@gmail.com>
> 
> Document the MSM8916-based 4G LTE WiFi modem.
> 
> Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
> ---
>   Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 5cb54d69af0b7206e0f6a66023a203b8d7087696..92dd91cb66b7b1b26b013a7d32c20dfe44690569 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -245,6 +245,7 @@ properties:
>                 - wingtech,wt86518
>                 - wingtech,wt86528
>                 - wingtech,wt88047
> +              - xiaoxun,jz0145-v33

I've heard that there are QUITE A LOT of jzxx variants made by the 
vendor. They are almost identical and can probably share one dts. Have 
you ever tried your dts on them(i.e. jz02 etc..). I think they are 
compatible. maybe this can be renamed to something more general.

>                 - yiming,uz801-v3
>             - const: qcom,msm8916
>   
> 

-- 
Regards,
Yang Xiwen

[PATCH RESEND v2 3/3] arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

[Ricky Cheung via B4 Relay]

From: Ricky Cheung <rcheung844@gmail.com>

This commit implements support for the JZ0145 v33 WiFi/LTE dongle
based on MSM8916, which was sold by XiaoXun BiCheng Technology.

The stock bootloader could boot with this patch with lk2nd, but only
one CPU core would be enabled. Enablement for all CPU cores require
lk1st and d410c firmware files.

Currently supported / tested:
- All CPU cores
- Buttons
- LEDs
- Modem
- SDHC
- USB Device Mode

Although I do not have UART equipment on hand, UART should function
and is labelled on the PCB of this device.

Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
---
 arch/arm64/boot/dts/qcom/Makefile                  |  1 +
 .../boot/dts/qcom/msm8916-xiaoxun-jz0145-v33.dts   | 66 ++++++++++++++++++++++
 2 files changed, 67 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index ae002c7cf1268a6f848fefdfadbd746091ee517b..ce8d4a731645e012f1222a130f068b62cacaa514 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -58,6 +58,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-thwc-ufi001c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-wingtech-wt86518.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-wingtech-wt86528.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-wingtech-wt88047.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-xiaoxun-jz0145-v33.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-yiming-uz801v3.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8929-wingtech-wt82918hd.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= msm8939-huawei-kiwi.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8916-xiaoxun-jz0145-v33.dts b/arch/arm64/boot/dts/qcom/msm8916-xiaoxun-jz0145-v33.dts
new file mode 100644
index 0000000000000000000000000000000000000000..7f1049e111b37213eeadc6a247d4cf21e7e0cd5f
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8916-xiaoxun-jz0145-v33.dts
@@ -0,0 +1,66 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "msm8916-ufi.dtsi"
+
+/ {
+	model = "JZ0145 v33 4G Modem Stick";
+	compatible = "xiaoxun,jz0145-v33", "qcom,msm8916";
+};
+
+&button_restart {
+	gpios = <&tlmm 37 GPIO_ACTIVE_HIGH>;
+};
+
+&led_b {
+	gpios = <&tlmm 8 GPIO_ACTIVE_HIGH>;
+};
+
+&led_g {
+	gpios = <&tlmm 7 GPIO_ACTIVE_HIGH>;
+};
+
+&led_r {
+	gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
+};
+
+&mpss {
+	pinctrl-0 = <&sim_ctrl_default>;
+	pinctrl-names = "default";
+};
+
+&button_default {
+	pins = "gpio37";
+	bias-pull-down;
+};
+
+&gpio_leds_default {
+	pins = "gpio6", "gpio7", "gpio8";
+};
+
+/* This selects the external SIM card slot by default */
+&tlmm {
+	sim_ctrl_default: sim-ctrl-default-state {
+		esim-sel-pins {
+			pins = "gpio22", "gpio23";
+			function = "gpio";
+			bias-disable;
+			output-low;
+		};
+
+		sim-en-pins {
+			pins = "gpio1";
+			function = "gpio";
+			bias-disable;
+			output-low;
+		};
+
+		sim-sel-pins {
+			pins = "gpio20";
+			function = "gpio";
+			bias-disable;
+			output-high;
+		};
+	};
+};

-- 
2.47.1

[PATCH] Re: arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

[Ricky Cheung]

Hi,

Sorry for sending the whole chain for 3 times, I was still trying to
figure things out. This reply is to inform about the changes in v2.

Changes in v2:
- Fixed indentation in Makefile

Please stick to Message-Id:
	20250114-xiaoxun-jz0145-v33-v2-0-495e986579ce@gmail.com

Best regards,
Ricky Cheung
Tipz Team
-- 
2.47.1

Re: [PATCH RESEND v2 0/3] arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

[Krzysztof Kozlowski]

On Tue, Jan 14, 2025 at 10:46:47PM +0800, Ricky Cheung wrote:
> 
> 	https://github.com/msm8916-mainline/linux/pull/386
> 
> Note that this is my first patch to the LKML, so if there's something I
> did wrong / the patch is missing, please point it out.

Please slow down a bit with submissions, so one patchset per 24h. You
sent three within 30 minutes, not leaving us much time to do review.

Best regards,
Krzysztof

Re: [PATCH RESEND v2 0/3] arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree

[Yang Xiwen]

On 1/14/2025 10:46 PM, Ricky Cheung wrote:
> Good evening.
> 
> This patch adds support for the XiaoXun JZ0145 v33 4G LTE WiFi modem
> based on the MSM8916 chipset by a new manufacturer / vendor for the
> Linux Kernel called called XiaoXun BiCheng Technology. Below is some
> information about these changes.

I'm glad to see another msm8916-ufi.dtsi user in mainline. But this 
patchset still contains some errors and needs to be fixed before getting 
applied.

> 
> Addition of a new vendor prefix
> ----------
> 
> XiaoXun BiCheng Technology is not well known in that they don't seem
> to have a presence in the Western world. I purchased my own modem
> on TaoBao, which requires stores to registered as businesses, so
> I believe it is justified to add it as a vendor prefix. Note that the
> company appears to have shut down just this month.

Be sure to know the real manufacturer rather than a random store. For 
example, we know most Xiaomi phones are actually manufactured and 
designed by Wingtech(闻泰) rather Xiaomi, so the dts for them are 
wingtech-msm8916-xxxx etc.. The same logic applies to the UFI dongles 
too. Try to get the box of your dongle and see if you can find the real 
vendor design the board rather than the company who just sells them.

> 
> Status of patch
> ----------
> 
> This device shares many similarities to pre-existing devices within
> arch/arm64/boot/dts/msm8916-ufi.dtsi, so I am sure most features would
> function with the correct firmware on this device.
> 
> However, due to the poor quality of these devices, my unit's EMMC has
> failed and I cannot conduct further tests. Previous, the modem was
> able to boot with devicetree of a UZ801, albeit with LED and Modem
> issues, which is addressed in this patch.
> 
> I have sent the code for testing to some kind folks on the Internet with
> good outcomes, so do consider this code as ready and functional.
> 
> This patch was also reviewed over at the msm8916-mainline organization
> and deemed ready by the maintainer:
> 
> 	https://github.com/msm8916-mainline/linux/pull/386
> 
> Note that this is my first patch to the LKML, so if there's something I
> did wrong / the patch is missing, please point it out.
> 
> Best Regards,
> Ricky Cheung
> Tipz Team
> 
> Signed-off-by: Ricky Cheung <rcheung844@gmail.com>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/20250114-xiaoxun-jz0145-v33-v1-0-dc51f7ce3bd8@gmail.com
> 
> ---
> Ricky Cheung (3):
>        dt-bindings: vendor-prefixes: Add XiaoXun BiCheng Technology
>        dt-bindings: arm: qcom: Add XiaoXun JZ0145 v33
>        arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree
> 
>   Documentation/devicetree/bindings/arm/qcom.yaml    |  1 +
>   .../devicetree/bindings/vendor-prefixes.yaml       |  2 +
>   arch/arm64/boot/dts/qcom/Makefile                  |  1 +
>   .../boot/dts/qcom/msm8916-xiaoxun-jz0145-v33.dts   | 66 ++++++++++++++++++++++
>   4 files changed, 70 insertions(+)
> ---
> base-commit: d390303b28dabbb91b2d32016a4f72da478733b9
> change-id: 20250114-xiaoxun-jz0145-v33-23dc006cf130
> 
> Best regards,

-- 
Regards,
Yang Xiwen