From: Maxime Ripard <mripard@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: fnkl.kernel@gmail.com, Hector Martin <marcan@marcan.st>,
Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Alyssa Ross <hi@alyssa.is>,
Janne Grunau <j@jannau.net>
Subject: Re: [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver
Date: Thu, 16 Jan 2025 17:01:03 +0100 [thread overview]
Message-ID: <20250116-vivacious-congenial-nightingale-cb2f6d@houat> (raw)
In-Reply-To: <mu7qiybhj7tu5hauk7izfxqlookc3awpknhjk74zwpkbznei4m@kewap6vivzoa>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
Hi Dmitry,
On Wed, Jan 15, 2025 at 12:21:39PM +0200, Dmitry Baryshkov wrote:
> On Tue, Jan 14, 2025 at 10:38:53PM +0100, Sasha Finkelstein via B4 Relay wrote:
> > +static int adp_dsi_host_attach(struct mipi_dsi_host *host,
> > + struct mipi_dsi_device *dev)
> > +{
> > + struct adp_mipi_drv_private *adp = mipi_to_adp(host);
> > + struct drm_bridge *next;
> > +
> > + next = devm_drm_of_get_bridge(adp->dsi.dev, adp->dsi.dev->of_node, 1, 0);
>
> select DRM_PANEL_BRIDGE for this API to be available.
> Also there is an issue of lifetimes. The bridge will be destroyed only
> when MIPI driver is unbound, however the panel can be attached and
> detached several times.
Can you expand on that one a bit more? AFAIK, it's always been unsafe
and we don't have a good mitigation at the moment, so it's unclear to me
what change you want here.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
next prev parent reply other threads:[~2025-01-16 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 21:38 [PATCH v4 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay
2025-01-14 21:38 ` [PATCH v4 1/5] dt-bindings: display: Add Apple pre-DCP " Sasha Finkelstein via B4 Relay
2025-01-15 9:20 ` Krzysztof Kozlowski
2025-01-14 21:38 ` [PATCH v4 2/5] drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay
2025-01-15 10:21 ` Dmitry Baryshkov
2025-01-16 16:01 ` Maxime Ripard [this message]
2025-01-17 3:43 ` Dmitry Baryshkov
2025-01-17 10:23 ` Maxime Ripard
2025-01-17 14:17 ` Sasha Finkelstein
2025-01-17 14:37 ` Maxime Ripard
2025-01-18 21:35 ` Dmitry Baryshkov
2025-01-16 18:52 ` Sasha Finkelstein
2025-01-17 10:23 ` Maxime Ripard
2025-01-17 10:39 ` Thomas Zimmermann
2025-01-14 21:38 ` [PATCH v4 3/5] drm: panel: Add a panel driver for the Summit display Sasha Finkelstein via B4 Relay
2025-01-14 21:38 ` [PATCH v4 4/5] arm64: dts: apple: Add touchbar screen nodes Sasha Finkelstein via B4 Relay
2025-01-15 14:07 ` Nick Chan
2025-01-14 21:38 ` [PATCH v4 5/5] MAINTAINERS: Add entries for touchbar display driver Sasha Finkelstein via B4 Relay
2025-01-18 12:28 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116-vivacious-congenial-nightingale-cb2f6d@houat \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fnkl.kernel@gmail.com \
--cc=hi@alyssa.is \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcan@marcan.st \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=sven@svenpeter.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®