From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>
Subject: Re: [GIT PULL] tracing: Fixes for v6.13-rc7
Date: Thu, 16 Jan 2025 10:10:24 -0500 [thread overview]
Message-ID: <20250116101024.2d8040d0@gandalf.local.home> (raw)
In-Reply-To: <20250116095333.5988c930@gandalf.local.home>
On Thu, 16 Jan 2025 09:53:33 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> But the irqsoff and wakeup latency tracers, when the "display-graph"
> option was set, would use the function graph tracer to calculate the
> times of functions during the latency. The movement of the calltime
> calculation made the value zero for these tracers, and the output
> no longer showed the length of time of each tracer, but instead the
> absolute timestamp of when the function returned (rettime - calltime
> where calltime is now zero).
FYI,
I have a patch that removes the calltime and rettime fields from the
generic structure as they should not be used in the generic code. That is
how I found this bug. I noticed that the irqsoff and wakeup tracers used
that field as well, and when I tested those tracers with the display-graph
option enabled, that's when I noticed the regression.
But that change is a cleanup and not appropriate for an rc release. This
was more of a work around to fix the regression. The proper fix will come
in 6.14.
-- Steve
next prev parent reply other threads:[~2025-01-16 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 14:53 Steven Rostedt
2025-01-16 15:10 ` Steven Rostedt [this message]
2025-01-16 23:02 ` Linus Torvalds
2025-01-16 23:06 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116101024.2d8040d0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=sshegde@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®