[PATCH 1/1] seqlock: add missing parameter documentation for raw_seqcount_try_begin()

[PATCH 1/1] seqlock: add missing parameter documentation for raw_seqcount_try_begin()

[Suren Baghdasaryan]

Add missing documentation for raw_seqcount_try_begin() start parameter.

Fixes: dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20250116170522.23e884d5@canb.auug.org.au/
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
Applies over mm-unstable

 include/linux/seqlock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 22c2c48b4265..b783a3a7ed62 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -322,6 +322,7 @@ SEQCOUNT_LOCKNAME(mutex,        struct mutex,    true,     mutex)
  * raw_seqcount_try_begin() - begin a seqcount_t read critical section
  *                            w/o lockdep and w/o counter stabilization
  * @s: Pointer to seqcount_t or any of the seqcount_LOCKNAME_t variants
+ * @start: count to be passed to read_seqcount_retry()
  *
  * Similar to raw_seqcount_begin(), except it enables eliding the critical
  * section entirely if odd, instead of doing the speculation knowing it will

base-commit: 4637fa5d47a49c977116321cc575ea22215df22d
-- 
2.48.0.rc2.279.g1de40edade-goog

Re: [PATCH 1/1] seqlock: add missing parameter documentation for raw_seqcount_try_begin()

[Waiman Long]

On 1/16/25 1:27 PM, Suren Baghdasaryan wrote:
> Add missing documentation for raw_seqcount_try_begin() start parameter.
>
> Fixes: dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/all/20250116170522.23e884d5@canb.auug.org.au/
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> ---
> Applies over mm-unstable
>
>   include/linux/seqlock.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> index 22c2c48b4265..b783a3a7ed62 100644
> --- a/include/linux/seqlock.h
> +++ b/include/linux/seqlock.h
> @@ -322,6 +322,7 @@ SEQCOUNT_LOCKNAME(mutex,        struct mutex,    true,     mutex)
>    * raw_seqcount_try_begin() - begin a seqcount_t read critical section
>    *                            w/o lockdep and w/o counter stabilization
>    * @s: Pointer to seqcount_t or any of the seqcount_LOCKNAME_t variants
> + * @start: count to be passed to read_seqcount_retry()
>    *
>    * Similar to raw_seqcount_begin(), except it enables eliding the critical
>    * section entirely if odd, instead of doing the speculation knowing it will
>
> base-commit: 4637fa5d47a49c977116321cc575ea22215df22d

Acked-by: Waiman Long <longman@redhat.com>

The tip tree also has the "seqlock: add raw_seqcount_try_begin" commit 
with a different hash - 96450ead1652.

Cheers, Longman

Re: [PATCH 1/1] seqlock: add missing parameter documentation for raw_seqcount_try_begin()

[Andrew Morton]

On Thu, 16 Jan 2025 14:28:26 -0500 Waiman Long <llong@redhat.com> wrote:

> >
> > base-commit: 4637fa5d47a49c977116321cc575ea22215df22d
> 
> Acked-by: Waiman Long <longman@redhat.com>
> 
> The tip tree also has the "seqlock: add raw_seqcount_try_begin" commit 
> with a different hash - 96450ead1652.

Yup, thanks.  An awkward dependency thing.  It'll sort itself out
during the merge window.

Now I'm wondering why we didn't just put that very simple patch straight
into mainline then be happy.  Oh well.