mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zihan zhou <15645113830zzh@gmail.com>
To: peterz@infradead.org
Cc: 15645113830zzh@gmail.com, bsegall@google.com,
	dietmar.eggemann@arm.com, juri.lelli@redhat.com,
	linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com,
	rostedt@goodmis.org, vincent.guittot@linaro.org,
	vschneid@redhat.com, yaowenchao@jd.com, yaozhenguo@jd.com,
	zhouzihan30@jd.com
Subject: Re: [PATCH V2] sched: Forward deadline for early tick
Date: Mon, 20 Jan 2025 15:44:49 +0800	[thread overview]
Message-ID: <20250120074448.48435-1-15645113830zzh@gmail.com> (raw)
In-Reply-To: <20250117113813.GA8603@noisy.programming.kicks-ass.net>

Thanks for your reply.

> > >
> > > In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable
> > > tasks" table, but not all tasks in the table are runnable.
> > > It is inappropriate to refer to this table as "runnable tasks", so here it
> > > is changed to "Tasks on CPU %d", like:
> > 
> > We have used replaced runnable by queued in fair scheduler
> 
> Right, but also 'tasks on cpu' is equally wrong -- but really, if you're
> looking at sched/debug you have to know what you're doing anyway, so why
> bother with trivial stuff like this?

Sorry, I just wanted to participate more in the kernel community. While
debugging the scheduler, I found this wording error. It doesn't really
affect anything, it just looks a bit awkward.

By the way, I am confused why 'tasks on cpu' is wrong. I think that
the tasks in the table are on a certain CPU, maybe they are sleeping,
but at least they were running on this CPU at the last moment. 

Looking forward to your answer. Of course, this matter doesn't seem
important, and I will try to understand it myself in the future.



  reply	other threads:[~2025-01-20  7:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17  2:22 [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug zihan zhou
2025-01-17  8:32 ` Vincent Guittot
2025-01-17 11:38   ` Peter Zijlstra
2025-01-20  7:44     ` zihan zhou [this message]
2025-01-20  7:55       ` [PATCH V2] sched: Forward deadline for early tick zihan zhou
2025-01-20  7:49     ` [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug zihan zhou
  -- strict thread matches above, loose matches on Subject: below --
2024-12-25  5:40 [PATCH V2] sched: Forward deadline for early tick zihan zhou
2025-01-02 10:00 ` Vincent Guittot
2025-01-09  5:48   ` zihan zhou
2025-01-14 10:16     ` Vincent Guittot
2025-01-16  8:12       ` zihan zhou
2025-01-17  8:18         ` Vincent Guittot
2025-01-20  7:38           ` zihan zhou
2025-01-20 11:42             ` Honglei Wang
2025-01-20 13:39               ` Vincent Guittot
2025-01-21  2:46                 ` zihan zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120074448.48435-1-15645113830zzh@gmail.com \
    --to=15645113830zzh@gmail.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=yaowenchao@jd.com \
    --cc=yaozhenguo@jd.com \
    --cc=zhouzihan30@jd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®